From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3F157A0C45; Wed, 22 Sep 2021 13:20:33 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 58F3041198; Wed, 22 Sep 2021 13:20:32 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 532F641196; Wed, 22 Sep 2021 13:20:31 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id CFE337F4E2; Wed, 22 Sep 2021 14:20:30 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru CFE337F4E2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1632309630; bh=PCnzsxS6bohEFQGWSv1O+3vLQkqQzLnQ3udyLMMb3BA=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=u89cK9YxsOFevSFF2Ijp+PA/4450UboJYFSJ8v6kjL0EfE1U4lLE/dl4iOKvtgv1e GrfKQ+bQZK6E+XZyXIH6PMURhVAhoqRPTyp1Wisy2UDkcw+9LTGiROrdYZk4S88bbx vPwvuEZGmjlcYldzC52I1ktZdInHeKk0Z+13ygSQ= To: Maxime Coquelin , dev@dpdk.org, chenbo.xia@intel.com, amorenoz@redhat.com, david.marchand@redhat.com, ferruh.yigit@intel.com, michaelba@nvidia.com, viacheslavo@nvidia.com, xiaoyun.li@intel.com Cc: stable@dpdk.org, nelio.laranjeiro@6wind.com, yvugenfi@redhat.com, ybendito@redhat.com References: <20210922095742.229262-1-maxime.coquelin@redhat.com> <20210922095742.229262-2-maxime.coquelin@redhat.com> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: <7238dea1-f48f-26e1-60ce-025853b4dae4@oktetlabs.ru> Date: Wed, 22 Sep 2021 14:20:30 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210922095742.229262-2-maxime.coquelin@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 1/5] net/virtio: add initial RSS support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/22/21 12:57 PM, Maxime Coquelin wrote: > Provide the capability to update the hash key, hash types > and RETA table on the fly (without needing to stop/start > the device). However, the key length and the number of RETA > entries are fixed to 40B and 128 entries respectively. This > is done in order to simplify the design, but may be > revisited later as the Virtio spec provides this > flexibility. > > Note that only VIRTIO_NET_F_RSS support is implemented, > VIRTIO_NET_F_HASH_REPORT, which would enable reporting the > packet RSS hash calculated by the device into mbuf.rss, is > not yet supported. > > Regarding the default RSS configuration, it has been > chosen to use the default Intel ixgbe key as default key, > and default RETA is a simple modulo between the hash and > the number of Rx queues. > > Signed-off-by: Maxime Coquelin RSS may be configured on rte_eth_dev_configure() stage using eth_conf->rx_adv_conf.rss_conf. It looks like the patch does not handle it.