From: Thomas Monjalon <thomas@monjalon.net>
To: "Wiles, Keith" <keith.wiles@intel.com>,
Raslan Darawsheh <rasland@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Shahaf Shuler <shahafs@mellanox.com>,
Ori Kam <orika@mellanox.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH v5 1/3] net/tap: add queue and port ids in Rx/Tx queues structures
Date: Wed, 10 Oct 2018 16:07:47 +0200 [thread overview]
Message-ID: <7239433.uTLSZrmg9m@xps> (raw)
In-Reply-To: <1A466485-DCE8-40ED-9DDB-E66A0DB2B4A0@intel.com>
10/10/2018 14:50, Wiles, Keith:
>
> > On Oct 10, 2018, at 2:03 AM, Raslan Darawsheh <rasland@mellanox.com> wrote:
> >
> > Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
>
> This title for the patch is the what we did not why we did it, should that be changed? To me it does not convey the reason or we would need to add a more complete comment body text to explain why we wanted the change. It is a bit of nit picking.
I think the question "why" must be answered in the body.
next prev parent reply other threads:[~2018-10-10 14:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 7:03 Raslan Darawsheh
2018-10-10 7:03 ` [dpdk-dev] [PATCH v5 2/3] net/tap: move fds of Rx/Tx queues to be in process private Raslan Darawsheh
2018-10-10 7:03 ` [dpdk-dev] [PATCH v5 3/3] net/tap: add queues when attaching from secondary process Raslan Darawsheh
2018-10-10 12:47 ` Wiles, Keith
2018-10-10 14:39 ` Raslan Darawsheh
2018-10-10 12:50 ` [dpdk-dev] [PATCH v5 1/3] net/tap: add queue and port ids in Rx/Tx queues structures Wiles, Keith
2018-10-10 14:07 ` Thomas Monjalon [this message]
2018-10-10 14:40 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7239433.uTLSZrmg9m@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=keith.wiles@intel.com \
--cc=orika@mellanox.com \
--cc=rasland@mellanox.com \
--cc=shahafs@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).