From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 2C1861B508
 for <dev@dpdk.org>; Wed, 10 Oct 2018 16:07:51 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id AF4AA21A1E;
 Wed, 10 Oct 2018 10:07:50 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute1.internal (MEProxy); Wed, 10 Oct 2018 10:07:50 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=mesmtp;
 bh=MTLRsrrriOUFhu65+xc9jNP1+a+7yGA4w7Gkh8lHj94=; b=KZuDn2VmVtn1
 zrfTZv3WuQ3K98AWTEPV1i0XM8VnNU4eA76K+5zUvTBDaey/JgJz0EBy8kAqYSdG
 jWyhyzFSgvAQtHosJPVG2bjxK4ZKLbTAXSitmdMX83Gmb5J7ISN130TJRc4TUpA1
 ZS2iXFyg9w/U2RkxEABUwHxT5yGLka4=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm1; bh=MTLRsrrriOUFhu65+xc9jNP1+a+7yGA4w7Gkh8lHj
 94=; b=odYvaXl62loE+w21H4XItb5CU4eIZ0NSOYWJnUM5HThrQlBcbhcI0TUd8
 njFhBQbP/azANIvnPN9x7TXHyML9R/pgslTqYTcB1h7V7UfYHLgclx4uuOQw1zjf
 eCKHrtbxLND6rCyVyiYNBcxeRtIE/naA3PiIJUNarwhocv0HQ+LtWpMPbQZQA/rf
 TuBn4C5tK3K/TDbzWa0Tq1O1cKxzNlrNuujHR1wa/RUjGuRINSRWorqPeJgGYdlc
 wVnkaFgPV/FWkkGSsG3XEP2TUt4lUbG0o5ViCjFi/ZwWW4GvKjQFwoTgS0kOB9bb
 SWcmllIZMzREP7OKvfhChqvsRp0Rg==
X-ME-Sender: <xms:tge-W5CTjcm4XbZr1cuUjENp_UsCZTpLVlcNP9qEewoBqAMZtg96Fg>
X-ME-Proxy: <xmx:tge-W1xqngUFX5e0axsMx7zBDZ77QuwiUX0VTT-ZXt5zotzYm7mKDw>
 <xmx:tge-W-CHT2u8cEDwMy-6DLx5tySfynPki3hkL1yODubaeMJYxMPoPQ>
 <xmx:tge-W0wbuxbTuGhJ2ccGtu-Nk1gbjSRR698oFpGHB7lHXCTOctatLA>
 <xmx:tge-W7NvKfb3Z71rRjEfdHsehNH-x8332zXrRyChnjFIHKqlx9YoMg>
 <xmx:tge-W9GSIrDPJjHLAUQQigwKeQo7id5lg43U59k68qircgGWH2QNcQ>
 <xmx:tge-W8VY5DTulSSvhB0uV_CIgvgmtsMyz1O6AaCcFCqOzf2_ZR2mmg>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 4E115102ED;
 Wed, 10 Oct 2018 10:07:49 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: "Wiles, Keith" <keith.wiles@intel.com>,
 Raslan Darawsheh <rasland@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Shahaf Shuler <shahafs@mellanox.com>,
 Ori Kam <orika@mellanox.com>, "Yigit, Ferruh" <ferruh.yigit@intel.com>
Date: Wed, 10 Oct 2018 16:07:47 +0200
Message-ID: <7239433.uTLSZrmg9m@xps>
In-Reply-To: <1A466485-DCE8-40ED-9DDB-E66A0DB2B4A0@intel.com>
References: <1539154988-20652-1-git-send-email-rasland@mellanox.com>
 <1A466485-DCE8-40ED-9DDB-E66A0DB2B4A0@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v5 1/3] net/tap: add queue and port ids in
	Rx/Tx queues structures
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 10 Oct 2018 14:07:51 -0000

10/10/2018 14:50, Wiles, Keith:
> 
> > On Oct 10, 2018, at 2:03 AM, Raslan Darawsheh <rasland@mellanox.com> wrote:
> > 
> > Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
> 
> This title for the patch is the what we did not why we did it, should that be changed? To me it does not convey the reason or we would need to add a more complete comment body text to explain why we wanted the change. It is a bit of nit picking.

I think the question "why" must be answered in the body.