From: Thomas Monjalon <thomas@monjalon.net>
To: "Sachin Saxena (OSS)" <sachin.saxena@oss.nxp.com>
Cc: dev@dpdk.org, ferruh.yigit@intel.com
Subject: Re: [dpdk-dev] [PATCH v1 2/4] net/dpaa2: release port upon close
Date: Mon, 28 Sep 2020 11:06:24 +0200 [thread overview]
Message-ID: <7243044.bp78lGCCmC@thomas> (raw)
In-Reply-To: <20200928085713.13560-3-sachin.saxena@oss.nxp.com>
28/09/2020 10:57, Sachin Saxena (OSS):
> + /* With new implementation of .close, port private data
> + * will also be release by close callback.
> + */
> dpaa2_dev_close(eth_dev);
I think this comment is weird.
next prev parent reply other threads:[~2020-09-28 9:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 8:57 [dpdk-dev] [PATCH v1 0/4] Align device close operation with new behavior Sachin Saxena (OSS)
2020-09-28 8:57 ` [dpdk-dev] [PATCH v1 1/4] net/dpaa: release port upon close Sachin Saxena (OSS)
2020-09-28 8:57 ` [dpdk-dev] [PATCH v1 2/4] net/dpaa2: " Sachin Saxena (OSS)
2020-09-28 9:06 ` Thomas Monjalon [this message]
2020-09-28 10:54 ` [dpdk-dev] [PATCH v2] " Sachin Saxena (OSS)
2020-09-28 8:57 ` [dpdk-dev] [PATCH v1 3/4] net/pfe: " Sachin Saxena (OSS)
2020-09-28 8:57 ` [dpdk-dev] [PATCH v1 4/4] net/enetc: " Sachin Saxena (OSS)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7243044.bp78lGCCmC@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=sachin.saxena@oss.nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).