From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E8B81A034F; Mon, 29 Mar 2021 09:19:33 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7934740151; Mon, 29 Mar 2021 09:19:33 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id 101CB40042 for ; Mon, 29 Mar 2021 09:19:32 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id AB2AE5C00B0; Mon, 29 Mar 2021 03:19:30 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 29 Mar 2021 03:19:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= H2XlJGySQHOM7C6MwuBl+rxuNZe7ZUPwSaU/nd8MB9c=; b=dP+1qMToq22Z9JeD jiCsZMmwW/JGKjoTXRhje4ZAn1+JQ42GEOrABW3rC+ayz0hZZkfSPEvV5CcQE91p NOF9TmqaFOOUKFrb/h+32k2G4VAJ5/KQiDHd13xIZaFi+Dwt85sQvxh6/l9iQq/Y BpYp4qLZHK5iRkD+Q74NGDj3ohbDl9AtFLCEhT8ZJP7stfZBujr9Gg+YgzdvA3EY 0woqK8bQc4RCwixn/Y/8hzr38kCvxV6+otHhlMuKYe1RG/jiTQR0srcrgVBH4iqv 3DlSlAcrsZ1w9GTfolJor7tmHVdokRtPfr/7qSybIU3P4UGwHOD4fV4Yjhk1oiBI SodURQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=H2XlJGySQHOM7C6MwuBl+rxuNZe7ZUPwSaU/nd8MB 9c=; b=iJ5E6g/wg21rewWNhziozm3uMPDBW17gaVwXZIR8MoIfYnZZxzzTsc6lp 9QI82uN1EQ2o0+dzlyNUJ0zSu6/wsKSBCkkf2bnH3rQklkdTyfZJvSmhfUSwDZx3 B7Rts9sv2xVOHcfFDJj0wZWhurJrck1MVMuyLvl6T0iojULSJ1esi0Iz9yml5Bl8 IFzTDKzOUvQBGNAjmeqnUPo/4qHN0VQgQ8Umgm96gsBVENprbwfrGBVjJKA+emvk FhFwiZu35xsKWPhhtgk9BASkY7TK7qoW9YWEFmLRqqONhl1gifg6J2pNNz+Y7uCC txFUjteawLFclE4IvLI4EwkliSg+A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudehjedguddujecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 309D4240054; Mon, 29 Mar 2021 03:19:29 -0400 (EDT) From: Thomas Monjalon To: Huisong Li Cc: dev@dpdk.org, ferruh.yigit@intel.com, andrew.rybchenko@oktetlabs.ru, ajit.khaparde@broadcom.com, jerinj@marvell.com Date: Mon, 29 Mar 2021 09:19:28 +0200 Message-ID: <7245184.973KLNHvPo@thomas> In-Reply-To: <9105928.7imIDBDKWL@thomas> References: <2a9f3c44-44da-854b-8b25-772a3570baa4@huawei.com> <9105928.7imIDBDKWL@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] Questions about reporting auto-negotiation capability X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 29/03/2021 09:03, Thomas Monjalon: > 29/03/2021 06:02, Huisong Li: > > 'speed_capa' in struct rte_eth_dev_info is defined as follows: > > > > uint32_t speed_capa; /**< Supported speeds bitmap (ETH_LINK_SPEED_). */ > > > > > > Most PMD drivers use this field to report the speeds capability > > supported by the device to the upper-layer app. > > > > But it seems that few NICs report their auto-negotiation capability > > through this field. If NIC also uses it to report > > their auto-negotiation capability through this field, and should set it > > to ETH_LINK_SPEED_AUTONEG(0) based on > > the definition of ETH_LINK_SPEED_xxx. In this case, it conflicts the > > report of the speeds capability . > > > > I don't know how to correctly report the auto-negotiation capability of > > the device. Thanks for your reply. > > ETH_LINK_SPEED_AUTONEG is not for capabilities. > Anyway, if it is set, it changes nothing (0) in the bitmap. > I see mlx5 is wrongly using it. > > speed_capa is only for enumerating speeds. I see some drivers are advertising ETH_LINK_SPEED_FIXED in speed_capa if the device cannot support autonegotiation. Should we add a note in doxygen?