From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AF295A04B7; Mon, 21 Sep 2020 08:19:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 911491D8CC; Mon, 21 Sep 2020 08:19:39 +0200 (CEST) Received: from mailgw01.pantheon.sk (mailgw01.pantheon.sk [46.229.239.26]) by dpdk.org (Postfix) with ESMTP id 954351C0DB for ; Mon, 21 Sep 2020 08:19:37 +0200 (CEST) Received: from mailgw01.pantheon.sk (localhost.localdomain [127.0.0.1]) by mailgw01.pantheon.sk (Proxmox) with ESMTP id 4D6302022AC; Mon, 21 Sep 2020 08:19:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; h=cc:cc:content-transfer-encoding:content-type:content-type :date:from:from:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=dkim; bh=MEgE2yf/n5IQHR2RC2ib zLQarOOoCVX2MvvfkkCQ04k=; b=oG9FQIoaurOuwKg3xKYxFYGrXph267qxsivj ++5dwqGJI7Ep/31zi667YAwhgJOuQd9kqlh+pZfK49mkD/+yAj6Am0+U17qR5Lz+ yuwfxlfUgqzF4caeH4//b5JyQaCwTWMaJBi8dU0b/apSfm/DtI2udMwcyZcmSfLt 0yMyOZS9KJYlIyIPSk9RRBv2R+JbmzWw/5M9yJgixB1SvKqm8medeO/w95Ciizao y4bhEA5t8SJteOaRnzWNCXC83ZGCuRyuDT4tGbvYHePSoX/5KOpNkZwIc0VENXsY 2CHZodZK6nuLTKhknajPTx+FRD93QIAUFq7JdI10mPloeKPU4Q== From: =?iso-8859-2?Q?Juraj_Linke=B9?= To: Phil Yang , "david.marchand@redhat.com" , "dev@dpdk.org" CC: Honnappa Nagarahalli , Ruifeng Wang , nd , nd Thread-Topic: [dpdk-dev] [PATCH] devtools: fix ninja break under default DESTDIR path Thread-Index: AQHWVb2kRcH6C/VVVkqEID1E/cG8sqltF+1QgAR874CAAX0rEA== Date: Mon, 21 Sep 2020 06:19:36 +0000 Message-ID: <7256fccd84d8416ea46285e20ad6c99c@pantheon.tech> References: <1594277585-15281-1-git-send-email-phil.yang@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.101.4.10] Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] devtools: fix ninja break under default DESTDIR path X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Phil Yang > Sent: Sunday, September 20, 2020 11:32 AM > To: Juraj Linke=B9 ; david.marchand@redhat.co= m; > dev@dpdk.org > Cc: Honnappa Nagarahalli ; Ruifeng Wang > ; nd ; nd > Subject: RE: [dpdk-dev] [PATCH] devtools: fix ninja break under default D= ESTDIR > path >=20 > Juraj Linke=B9 writes: >=20 > > > Subject: [dpdk-dev] [PATCH] devtools: fix ninja break under default > > DESTDIR > > > path > > > > > > If DPDK_ABI_REF_DIR is not set, the default DESTDIR is a relative pat= h. > > > This will break ninja in the ABI check test. > > > > > > > The commit message is not very clear. The problem is we're specifying > > ninja's destination dir in variable DESTDIR when invoking ninja > > install. If the DESTDIR is not an absolute path, ninja complains (when > > invoking install). This isn't > Yes, this defect is due to 'ninja install' not happy with the relative pa= th. > Will reword the commit message in the next version. >=20 > > directly related to DPDK_ABI_REF_DIR, it's more a problem with how we > > call install_target. > If we have set 'DPDK_ABI_REF_DIR' before the test, 'abiref' should be an > absolute path, but the default 'abiref' value is a relative path. > So should we keep them align? >=20 > > > > > Fixes: 777014e56d07 ("devtools: add ABI checks") > > > > > > Signed-off-by: Phil Yang > > > --- > > > devtools/test-meson-builds.sh | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson- > > builds.sh index > > > a87de63..2bfcaca 100755 > > > --- a/devtools/test-meson-builds.sh > > > +++ b/devtools/test-meson-builds.sh > > > @@ -143,7 +143,7 @@ build () # > > file> > > > config $srcdir $builds_dir/$targetdir $cross --werror $* > > > compile $builds_dir/$targetdir > > > if [ -n "$DPDK_ABI_REF_VERSION" ]; then > > > - abirefdir=3D${DPDK_ABI_REF_DIR:- > > > reference}/$DPDK_ABI_REF_VERSION > > > + abirefdir=3D${DPDK_ABI_REF_DIR:- > > > $(pwd)/reference}/$DPDK_ABI_REF_VERSION > > > if [ ! -d $abirefdir/$targetdir ]; then > > > # clone current sources > > > if [ ! -d $abirefdir/src ]; then > > > -- > > > 2.7.4 > > > > > > > install_target on line 160 is called improperly. Let's fix it so that > > it matches line > > 169: > > install_target $abirefdir/build $(readlink -f $abirefdir/$targetdir) >=20 > If so we need to call readlink at line #161 as well as it does at line #1= 71. >=20 > > > > This way we don't need to add $(pwd). >=20 > If you don't prefer $(pwd), we can do it like this: > abirefdir=3D$(readlink -f ${DPDK_ABI_REF_DIR:- > reference}/$DPDK_ABI_REF_VERSION) >=20 I mostly wanted the code to be consistent and since readlink was already in= the code I pointed that out. I think your last proposal is the best of the= two worlds, but let's change the code everywhere (i.e. lines 170-174 as we= ll). > Thanks, > Phil >=20 >=20