Re: [PATCH] net/iavf: fix segmentation offload buffer size

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 2/15/2022 12:44 PM, Ferruh Yigit wrote:
> On 2/15/2022 12:30 PM, Nicolau, Radu wrote:
>>
>> On 2/15/2022 11:19 AM, Ferruh Yigit wrote:
>>> On 2/15/2022 10:47 AM, Nicolau, Radu wrote:
>>>>
>>>> On 2/15/2022 10:06 AM, Ferruh Yigit wrote:
>>>>> On 2/10/2022 1:09 PM, Radu Nicolau wrote:
>>>>>> This reverts commit ff8b8bcd2ebe, which resulted in incorrect buffer size
>>>>>> being computed for TSO packets.
>>>>>>
>>>>>> Fixes: ff8b8bcd2ebe ("net/iavf: fix segmentation offload condition")
>>>>>>
>>>>>
>>>>> Commit 'ff8b8bcd2ebe' was already fixing segmentation offload,
>>>>> are we having the initial issue back when this patch reverted?
>>>>> Is there a fix for that initial issue?
>>>> The initial issue was around a very specific usecase - IPsec transport mode TSO and it is very likely back with this revert. But it's a much less severe impact than general traffic TSO.
>>>
>>> Got it, so this revert brings back an issue, should
>>> we document this in the commit log of this patch?
>>> Plus should we create a Bugzilla etc to record the
>>> introduced issue?
>>
>> I plan to follow up with a fix shortly.
>>

Or does it make sense to combine that fix with this patch?

>> As for the commit message, since this was not merged to the LTS and main, do we really need it?
>>
> 
> Not for the LTS but for main repo. We know merging this patch
> will introduce an previous issue back but that is not obvious
> from the commit log.
> 
> I think it helps to document, in commit log, what issue this
> commit brings.