From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B1092A00C5; Tue, 15 Feb 2022 13:48:39 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 453FD41145; Tue, 15 Feb 2022 13:48:39 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 3F614410F7 for ; Tue, 15 Feb 2022 13:48:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644929317; x=1676465317; h=message-id:date:from:to:cc:references:subject: in-reply-to:content-transfer-encoding:mime-version; bh=iZMhBYROvVGqFvjIxirkbwU9Ls19rrIRt1F2+pNw99Y=; b=m7M9vjjrNpYsmLCPSx3Fdf4FX8DpKVZsekwp/8mR6orEZ0v9D60Y5Lzj tYH3Qo1ZcCen8YdnTJhieX8wXgw2pMmMOKHmZ5uzV6dAYPXUpfsgbYjhy QAKaL/VuY4EkS39DTrcjxOenWUp1MacUchf32sR2KMWuLIZC3lEFVhzvf 0q7JE490n8fY7cQAMmRT3ySHq33biPz+w2hpiuXz/nN2vlWFNEegSBiru Crof2PYvh0mz5rqG2Ksw0xr10X2ud8+SwJKx6t+7dvw0U8hRStPupHZwE Ub+bXR9NGVCQdLQWRyPPCRyl72rfVtBX4GnvwzVbURllg5F5iizoDXQoW A==; X-IronPort-AV: E=McAfee;i="6200,9189,10258"; a="336774964" X-IronPort-AV: E=Sophos;i="5.88,370,1635231600"; d="scan'208";a="336774964" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2022 04:48:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,370,1635231600"; d="scan'208";a="497098480" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga006.jf.intel.com with ESMTP; 15 Feb 2022 04:48:36 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 15 Feb 2022 04:48:35 -0800 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 15 Feb 2022 04:48:35 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 15 Feb 2022 04:48:35 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.173) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 15 Feb 2022 04:48:34 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UOP4zfVuOoZheeYzHuAZwF0w5AYpr2iDxMoRm+pLcvWRyirwRU3M5fJuAgB5trohzjbsJQ1A7AupWKz0pe5WxACsBk3PfIVcTNeAQSTmXvda8Dm3U6RN5/yy3swyLguccf419Fgng+yZUmag06MjzlY3X/1NCzZ+tZhMwDqJbZG5rRZtfN4mRLCwu4pAdSTjPUQmi3cpPDKxEGJyVo2sg3jKDGY61FHMUdRMczi86kwOCT/4qe1vjzgRCakk6Vvt0rUr840KjVTPk93uZ+vLa6aNQBymNVT2oRalHz7gNkLkARagMMkMxpdigzrXHLMbUL3KFoCbkXftEEhkIa0qqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4tgv/EpbBud86LGm1qI4nYzKAde3UrUsfMbEvujBoEI=; b=giY1r7W/PiI2Zu0jz/KcjQ8v+5G2UXyeA8fr2aduNe+xLWBQeYbKiYSZS0sHtPaTYiBgIOYkLEWoojkhj9h5lcm4Cw8rhgT9wZPuWf0DMh7h07gD1K/kTruDrwuIr9GGxDelXDCxK1N87QIobOrqGqa7/ghCBYlz7b6LsPtOny/VMvrwRwXZgyV/QRmm6TEPvIjVgjO6j8k5heJhsEdsK+WEoMbGQsSjq5dnXVEk+pZ6GExeacIBGXVFFcJ3fqlqiYO9cy5RS/s/CkW4V3PkBaHrt+jdvdICCrnf2f2yn2iDUJ13roWcM6RyL3owGG0N1j9YgUwawsp9vUOG7aXrAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by MW5PR11MB5929.namprd11.prod.outlook.com (2603:10b6:303:194::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.17; Tue, 15 Feb 2022 12:48:27 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2%4]) with mapi id 15.20.4975.019; Tue, 15 Feb 2022 12:48:27 +0000 Message-ID: <72602dd6-b020-13cd-df70-13a06a57d9a7@intel.com> Date: Tue, 15 Feb 2022 12:48:21 +0000 Content-Language: en-US From: Ferruh Yigit To: "Nicolau, Radu" , Jingjing Wu , Beilei Xing CC: , , Kevin Traynor , Luca Boccassi References: <20220210130923.1442905-1-radu.nicolau@intel.com> <05a27976-6664-190c-38b7-9b63c7294973@intel.com> <23e5a111-9402-d6ce-a076-5dbcb24f5937@intel.com> <0e492107-2325-8f79-7a7f-ad652c40c741@intel.com> <61a3edb7-3d5c-1df8-52bd-26f4a951ad5b@intel.com> Subject: Re: [PATCH] net/iavf: fix segmentation offload buffer size X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0514.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:272::21) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fddd3360-522c-47dc-43be-08d9f0817613 X-MS-TrafficTypeDiagnostic: MW5PR11MB5929:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:972; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +FQlKFuiASU0ru3fYi64L/x6LJ5psqgc41jPoM59VyTeJ+OKu4vfxwQdnn+h9PLI+8KQPSFC8x1h/lcdyzVhPbBNT7bk4f961okdELcsff3aUKgntJZVUtWYqd3B/NWjCrk9KYv/DIJ4Uj05aqFY6NvueEmqyVwVE6445yGDDUz+jTgetT9taoX4ZCo+/jK/L5K/29uevzc2NX6QpE+hVNZl70+jkKq7Dk/DfSAj3LyDlVXiCUGfOa1p+KH3xHKUAIvCrujHCVrlzfBGpPLgDAKavECgKS5AGqi0xMCYionoWFDRYJp1LR6wNm38R8bMW9nX9gxv/jMjZbKSIJhFsByKc5n0zDSMAoTUtGwRUdC+f4zy1DCrorEYWJrcePSlVRqGc+6f+fx2WOsuYzCmf9vrvoEnIqlFrNcvYltFuJnr6Eo6UKGYW1gtamOay6l69szMcwgt1kWE6pHSX8YZqfwaYnbUn/VW0unc+UOVFaBDmpAnjTn8swYtewyJUJw/rtRorFufqZAZzgn9dMXmXk60LrGnCyE1d1Ex1Po0M4bs72ur6BzfjdRbtBXp8YqYEnI/86T2lIm1ZbkjFScZUqrSr/WykUqpsyHKpe1MK6rCv5eeI++pFKOR9l9bIiVgwl2Uf252I9Y3kJr18U9deqVbMXIMHWhtPQaz1fGHaf8BWvtCgfkPon753htNFW7Cgip4kLRHbeIZB0m6Y5kCcQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(38100700002)(2906002)(316002)(66556008)(110136005)(66476007)(4326008)(8936002)(82960400001)(54906003)(66946007)(5660300002)(44832011)(8676002)(6486002)(31696002)(83380400001)(508600001)(6636002)(36756003)(53546011)(6506007)(6666004)(186003)(26005)(6512007)(2616005)(31686004)(86362001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UkpSY0RkYWNvMm5NN0dGVlV0bVFhMXh1MktJWks5UHptdVdCbndxOWFOT0Mw?= =?utf-8?B?WldlRy9KS1hRZ2syM2R4RHAwNGlWMEdFdUdUS0J2blZvQ2YwMmk5aEVUY2d6?= =?utf-8?B?Y1JNR1ZscHJCMExFLzhBY0dzeFdYbHo4eWFzYXZWRElYaDRXUERCTG5PY1RF?= =?utf-8?B?Z3BaaVlSbm5kNkN2SkJnUUxhSmYvMGtJZmt2SHJEd3FRdk91and0TXdoTUxE?= =?utf-8?B?dVFMQ3dvVWJ3WHRXMGRHYktPTENoN0pHUHA4S3BUNHNoNUZFQWlzdVBrMGg0?= =?utf-8?B?NjhlUnQxTzZPSC90R1d5QWEybXJTSmZhd3NLWlJRTlFiU0d6TGdWNGtNbjds?= =?utf-8?B?OVZ6OXlkWERWdWl0OC9tUURLbXhoUmhDcHdQV0NsT2N6V3NGZ01CRmo3Ung4?= =?utf-8?B?dXRvZ3ZGU3NBNEdKY1hhSjZ4eDF6alRVblhjOW91Uk1hcFNHTmxQcW51Slhi?= =?utf-8?B?OVh3TExKVjRyNkMvdXN0MytUSkYvMnV0N3MwVFAvUm1DVXdzRTBIb011aDEz?= =?utf-8?B?REFRVE9JbnZ5ZlNCeW1zYXcvUlE1ZnNoS0N0MUFSbS9QMnp1elU0QWtzR00x?= =?utf-8?B?U1B6QlFJc29RbmdialVFaCtLdVpBRW1TK0Q2bVJYeGh2djZmT3NSbi8wUFoz?= =?utf-8?B?K2dUNGFiZ0x2MktCT0J4d1Bxdmp4SkJwMjhDRU00QU44MFQwdmI5TUh2NUFG?= =?utf-8?B?Rmc1NGxTUTVmeXo2Umc1cHRmWWxxWlA0ZFNCM2hsbUVhank3bzF0Wm1vbnNE?= =?utf-8?B?dElpVWZ3U3RXL1dOaVlxL3NIOWRXL0JOTy9jQlVlMzRTbGZQMC9BZ2VvOExK?= =?utf-8?B?WUttSUVFRzltZW4xaERRN056ZzdOVy83ZlVRTmZ1RWNYdVl5NTJlMGZQbnk4?= =?utf-8?B?UHhJZ1JhdWt5K0M4SWN6NlI2L1oxY1lUT25kRlJRYlZNdmYxd29hMmJKVXVU?= =?utf-8?B?OEpFN2FrYkwzVjZwNjFvdEczd0E5OERQV09KNE9PR0NiaFc4dlVLc0JCdDRT?= =?utf-8?B?bnVoVkdOWWJvUFdIQ2RrRkpCbGo5bWR3Szd3THRkdWo5ekFnUkxQRVpPbUxq?= =?utf-8?B?SE9YZThuMVV2Y1N3T2M5K25KYU1BdUx4VGJtb0NWL013V25GQkZFL0ZvN3JH?= =?utf-8?B?NzEwRm9wUTFpVnJkQTlPbVFHNERDbXpkcG9TKzVFUE1zWUl3YU9NQjYrS0o4?= =?utf-8?B?MThjTExUeE5ZNEFSM0FjTVB5UEtlQkEzWXFXN3BlZm9QZU1laVJZYkZxMmhF?= =?utf-8?B?QThyamY5MG1SM0tmSWVHdjVTeVZzMHRGLyt6MWdBM3hyNXY0YzlQd3dBQVJI?= =?utf-8?B?dlU0OXUxRmVqZWY3aTNpbEY3eWZhTi9RMXBiTkRSaldxQklCMElWMTdoMU96?= =?utf-8?B?SXA5UTlBV3I3UEpsNjBYeVhYd0tTeEpLS21ueGtxWFE0cTdJY0xHalYraVMv?= =?utf-8?B?VEU5Y3Q0Wmk0dGcvRGRLRVByY3JISTRMa3N5NGVOWm53L2tyaTRodG5jSkZD?= =?utf-8?B?QndGK0pBenpOcjJhUG9WdU41WnAvU2I2VGMzUW1mWGxGbWJZMWF3N2pSK2dS?= =?utf-8?B?WDZiZHhKTkJWamY0bjNja2J3RThWLzNBZ01rdCtRUC8zSmJmbUdZUkxXb2dI?= =?utf-8?B?Q2pIY20vL2JORUhaaW4zRlRseWZKS0dxdFZWM2JWQXNyTXNiSnRiZTZkZmMx?= =?utf-8?B?K2xOWkI4KzRiNEc5aUdYY2V3WWJ4TUtQc3k0M3BHaDVqUWVZUFpJOE5KMmRW?= =?utf-8?B?SEpQVVZCNmtGZWQvQ3hnemp2dDBLQzBYL2ZTRVk4a25RMndJU05iZkVYNmRm?= =?utf-8?B?YlhTYW5mN3NwajBzZ2ZrbDdqdzllbFBOWWlYeFNBRmgrQzM0bFo2RmRhVHUr?= =?utf-8?B?SFl6ZlJlRUxUOHFlUXFkcU9TNklPV1g5WG5PekdnT1hVWS9HVjdlK2FaUjZL?= =?utf-8?B?d1JmRGxaV0o3L2RnMkdJREp0S3VXaHlxNktvb04wUnY4RGRBNEduMEpnaXcz?= =?utf-8?B?Ty9UVGZzWFRwNmVSb0IrWnVtd2dLRklmeWNKaUVTR1o0Z1NSSTVPSFJpL3Zz?= =?utf-8?B?SmczWXdGVm5ISEpwYkZWN1NxVHZVb2cyVjF1SUhPTEI1UEFvYjRqNkcveUFW?= =?utf-8?B?K3ZrVjFTMTJvSEw5emZVTzFmK25yRVJNVFFWM1R0TWUxRW9OQmYwOURkTUdM?= =?utf-8?Q?VsdSdswauTF8IP/su6Ra9yI=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: fddd3360-522c-47dc-43be-08d9f0817613 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 12:48:27.4244 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VvZeWYJbnSjUQAaceyW1wdPSKvgXrUmg+OYrQNvkXZ/3huFmmncs4L67cdk7dgdeCMjdnKw0nPBdrAAhuZcKSA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR11MB5929 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/15/2022 12:44 PM, Ferruh Yigit wrote: > On 2/15/2022 12:30 PM, Nicolau, Radu wrote: >> >> On 2/15/2022 11:19 AM, Ferruh Yigit wrote: >>> On 2/15/2022 10:47 AM, Nicolau, Radu wrote: >>>> >>>> On 2/15/2022 10:06 AM, Ferruh Yigit wrote: >>>>> On 2/10/2022 1:09 PM, Radu Nicolau wrote: >>>>>> This reverts commit ff8b8bcd2ebe, which resulted in incorrect buffer size >>>>>> being computed for TSO packets. >>>>>> >>>>>> Fixes: ff8b8bcd2ebe ("net/iavf: fix segmentation offload condition") >>>>>> >>>>> >>>>> Commit 'ff8b8bcd2ebe' was already fixing segmentation offload, >>>>> are we having the initial issue back when this patch reverted? >>>>> Is there a fix for that initial issue? >>>> The initial issue was around a very specific usecase - IPsec transport mode TSO and it is very likely back with this revert. But it's a much less severe impact than general traffic TSO. >>> >>> Got it, so this revert brings back an issue, should >>> we document this in the commit log of this patch? >>> Plus should we create a Bugzilla etc to record the >>> introduced issue? >> >> I plan to follow up with a fix shortly. >> Or does it make sense to combine that fix with this patch? >> As for the commit message, since this was not merged to the LTS and main, do we really need it? >> > > Not for the LTS but for main repo. We know merging this patch > will introduce an previous issue back but that is not obvious > from the commit log. > > I think it helps to document, in commit log, what issue this > commit brings.