DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Mohsin Kazmi <mohsin.kazmi14@gmail.com>
Cc: dev@dpdk.org, stable@dpdk.org, olivier.matz@6wind.com,
	david.marchand@redhat.com, maxime.coquelin@redhat.com,
	andrew.rybchenko@oktetlabs.ru, ferruh.yigit@intel.com
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v3] net: fix Intel-specific Prepare the outer ipv4 hdr for checksum
Date: Thu, 22 Jul 2021 21:56:25 +0200	[thread overview]
Message-ID: <7265315.64hUE0sMR9@thomas> (raw)
In-Reply-To: <20210707094019.40945-1-mohsin.kazmi14@gmail.com>

+Cc more people for reviews.

07/07/2021 11:40, Mohsin Kazmi:
> Preparation the headers for the hardware offload
> misses the outer ipv4 checksum offload.
> It results in bad checksum computed by hardware NIC.
> 
> This patch fixes the issue by setting the outer ipv4
> checksum field to 0.

nit: please write "IPv4" here and below.

> Fixes: 4fb7e803eb1a ("ethdev: add Tx preparation")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Mohsin Kazmi <mohsin.kazmi14@gmail.com>
> Acked-by: Qi Zhang <qi.z.zhang@intel.com>
[...]
> @@ -125,11 +125,22 @@ rte_net_intel_cksum_flags_prepare(struct rte_mbuf *m, uint64_t ol_flags)
>  	 * Mainly it is required to avoid fragmented headers check if
>  	 * no offloads are requested.
>  	 */
> -	if (!(ol_flags & (PKT_TX_IP_CKSUM | PKT_TX_L4_MASK | PKT_TX_TCP_SEG)))
> +	if (!(ol_flags & (PKT_TX_IP_CKSUM | PKT_TX_L4_MASK | PKT_TX_TCP_SEG |
> +			  PKT_TX_OUTER_IP_CKSUM)))
>  		return 0;
>  
> -	if (ol_flags & (PKT_TX_OUTER_IPV4 | PKT_TX_OUTER_IPV6))
> +	if (ol_flags & (PKT_TX_OUTER_IPV4 | PKT_TX_OUTER_IPV6)) {
>  		inner_l3_offset += m->outer_l2_len + m->outer_l3_len;
> +		/*
> +		 * prepare outer ipv4 header checksum by setting it to 0,
> +		 * in order to be computed by hardware NICs.
> +		 */
> +		if (ol_flags & PKT_TX_OUTER_IP_CKSUM) {
> +			ipv4_hdr = rte_pktmbuf_mtod_offset(m,
> +					struct rte_ipv4_hdr *, m->outer_l2_len);
> +			ipv4_hdr->hdr_checksum = 0;
> +		}
> +	}




  reply	other threads:[~2021-07-22 19:56 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-30 11:04 [dpdk-dev] [PATCH v2] net: prepare " Mohsin Kazmi
2021-06-30 14:09 ` Olivier Matz
2021-07-07  9:14   ` Mohsin Kazmi
2021-07-22 19:53     ` Thomas Monjalon
2021-08-03 12:29       ` Mohsin Kazmi
2021-07-07  9:40 ` [dpdk-dev] [PATCH v3] net: fix Intel-specific Prepare " Mohsin Kazmi
2021-07-22 19:56   ` Thomas Monjalon [this message]
2021-07-27 12:52     ` [dpdk-dev] [dpdk-stable] " Olivier Matz
2021-07-28 15:46   ` [dpdk-dev] " Andrew Rybchenko
2021-07-30 11:11     ` Olivier Matz
2021-07-31 12:49       ` Andrew Rybchenko
2021-08-03 12:49         ` Mohsin Kazmi
2021-08-27 13:44           ` Mohsin Kazmi
2021-09-07 10:49   ` [dpdk-dev] [PATCH v4] net: fix Intel-specific Prepare the outer IPv4 " Mohsin Kazmi
2021-09-15 10:39     ` Ferruh Yigit
2021-09-15 11:04     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7265315.64hUE0sMR9@thomas \
    --to=thomas@monjalon.net \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=mohsin.kazmi14@gmail.com \
    --cc=olivier.matz@6wind.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).