From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D95E8A04B5; Thu, 1 Oct 2020 11:49:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3CF8F1DA33; Thu, 1 Oct 2020 11:49:26 +0200 (CEST) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id D6BB51D6FE for ; Thu, 1 Oct 2020 11:49:22 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 61392814; Thu, 1 Oct 2020 05:49:20 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 01 Oct 2020 05:49:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= ylczYowJogexWPJJyqcb8gNQPqfN/8dZqWeehzPhgKQ=; b=tehzHGH1+kLt2mjJ +atpevVGvHzl7cJDchMF4CfYXWuKelPI2zfaeWfG71LmWx9JS471hRrOosiguuNE IxT4fwGM1TfD/T9e/7HGcIjw4SQjC1z3zwi5aBfIG/qRxjHsPyyojMDNsSm0/W7D +iMnc1pPGdSyg4FGRXgCzWBN781qFYRwuIjOfDAACWK/dgDfVycS6D0Ls8nHJHw8 bVZY1mg5bXnmpT2dunrs++9NytbqiT3/LClr1RAWgMzf/rEFfpJjRRSQuq1xi1Nv uZAefVGps+8chw0mz5bcqvM6aRY/Xdz5FZK8Ez7PXz0yS77sK47BXpToSNc/kEuq nt0hxw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=ylczYowJogexWPJJyqcb8gNQPqfN/8dZqWeehzPhg KQ=; b=lng+Dv52EmR4/8+ZM0UmuXY4GDzutA16B+ExiTq6H8ADiUCh4p1R7ysRy f5hhRtCZlhUUtH33CH4iuNTz3OCa4hs9PiG14AH3YClQ3DIMacR9rJ/NzaaboCqm A4y+laHLDpOhS5VJUGh+d53Zn9Q8PT76VipB2kALW6bBVnaICgi5wotA/jX8Ey6H rRw+6FF+WmcTMGoA1TbbZf40xm00A8sJYXRqXTd/baKxeC8Ig8qSuox7bxj2TlBR jj2mywo1nQWbEtV6A3YmTSFDe/jIFWj3/FfbsgjFX1minI/jc67HFp3kOSHwv75j EDV3CRfY46Psd2MDHfq4fhc9MkVFg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrfeeggddvtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 3E152306467E; Thu, 1 Oct 2020 05:49:19 -0400 (EDT) From: Thomas Monjalon To: "Power, Ciara" Cc: "dev@dpdk.org" , "Mcnamara, John" , "Kovacevic, Marko" Date: Thu, 01 Oct 2020 11:49:18 +0200 Message-ID: <7270461.l2NZe9DxIN@thomas> In-Reply-To: References: <20200807123009.21266-1-ciara.power@intel.com> <3051248.mg5JyDbmDi@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 03/20] doc: remove references to make from Linux guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 01/10/2020 10:36, Power, Ciara: >From: Thomas Monjalon > > > >Hi, > > > >Below are some comments. If you agree, I will do the changes myself while > >pushing to the main branch. > > > > > >21/09/2020 15:59, Ciara Power: > >> Make is no longer supported for compiling DPDK, references are now > >> removed in the documentation. > >> > >> Signed-off-by: Ciara Power > >> Reviewed-by: Bruce Richardson > >> --- > >> doc/guides/linux_gsg/build_dpdk.rst | 16 +++++++++++----- > >> doc/guides/linux_gsg/build_sample_apps.rst | 18 +++--------------- > >> doc/guides/linux_gsg/enable_func.rst | 13 +++++-------- > >> doc/guides/linux_gsg/linux_drivers.rst | 18 +++++++++++------- > >> doc/guides/linux_gsg/sys_reqs.rst | 6 +----- > >> 5 files changed, 31 insertions(+), 40 deletions(-) > >> > >> diff --git a/doc/guides/linux_gsg/build_dpdk.rst > >> b/doc/guides/linux_gsg/build_dpdk.rst > >> index a895e1b0f4..85d04520bf 100644 > >> --- a/doc/guides/linux_gsg/build_dpdk.rst > >> +++ b/doc/guides/linux_gsg/build_dpdk.rst > >> @@ -76,6 +76,8 @@ and the last step causing the dynamic loader `ld.so` > >to update its cache to take > >> distributions, `/usr/local/lib` and `/usr/local/lib64` should be added > >> to a file in `/etc/ld.so.conf.d/` before running `ldconfig`. > >> > >> +.. _adjusting_build_options: > >> + > > > >extra blank line > > Blank line here, and below, were added based on the contributing guide - " Add 2 blank lines before each section header." > Okay to remove if that has changed. Yes, the recommendation is 2 blank lines to separate a paragraph from the next title. But here it is an anchor for the next title, so it should be grouped together. > >> Adjusting Build Options > >> ~~~~~~~~~~~~~~~~~~~~~~~ > >> @@ -112,6 +114,9 @@ dependencies are met on the current system are > >built. > >> When `-Dexamples=all` is set as a meson option, meson will check each > >> example application to see if it can be built, and add all which can be built > >to the list of tasks in the ninja build configuration file. > >> > >> +.. _building_app_using_installed_dpdk: > >> + > >> + > > > >extra blank line > > > >> Building Applications Using Installed DPDK > >> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > >> > >> @@ -135,11 +140,12 @@ and the sources for that build are stored in > >``$(SRCS-y)``. > >> > >> .. note:: > >> > >> - Unlike with the older make build system, the meson system is not > >> - designed to be used directly from a build directory. Instead it is > >> - recommended that it be installed either system-wide or to a known > >> - location in the user's home directory. The install location can be set > >> - using the `--prefix` meson option (default: `/usr/local`). > >> + Unlike with the make build system present used in older DPDK releases, > >> + the meson system is not designed to be used directly from a build > >> + directory. Instead it is recommended that it be installed either > >> + system-wide or to a known location in the user's home directory. > >> + The install location can be set using the `--prefix` meson option > >> + (default: `/usr/local`). > > > >I prefer the first version. > >The words "system present used" look weird. > >Anyway, if any reword is needed, better to change only the impacted line and > >keep the rest of the line wrapping untouched. > > > I think this was a typo on the first line, should have been either "present" or "used", not both. OK will fix. [...] > >> --- a/doc/guides/linux_gsg/enable_func.rst > >> +++ b/doc/guides/linux_gsg/enable_func.rst > >[...] > >> @@ -128,13 +130,8 @@ Loading the DPDK KNI Kernel Module > >> ---------------------------------- > >> > >> To run the DPDK Kernel NIC Interface (KNI) sample application, an extra > >kernel module (the kni module) must be loaded into the running kernel. > >> -The module is found in the kmod sub-directory of the DPDK target > >directory. > >> -Similar to the loading of the ``igb_uio`` module, this module should > >> be loaded using the insmod command as shown below -(assuming that the > >current directory is the DPDK target directory): > >> - > >> -.. code-block:: console > >> - > >> - insmod kmod/rte_kni.ko > >> +The module is found in the kernel/linux sub-directory of the DPDK build > >directory. > >> +This can be enabled in the same way as the ``igb_uio`` module, please see > >:ref:`load_uio` for details. > > > >The only relevant info in "load_uio" chapter is to use insmod. > >I think it is better to keep some lines above: > > > >It should be loaded using the insmod command:: > > > > insmod kmod/rte_kni.ko > > I think this should be the updated path: > " /kernel/linux/kni/rte_kni.ko" Yes of course. Thanks