* [dpdk-dev] [PATCH] config: remove unused macro
@ 2018-09-17 7:39 Qi Zhang
2018-09-17 8:24 ` Bruce Richardson
0 siblings, 1 reply; 3+ messages in thread
From: Qi Zhang @ 2018-09-17 7:39 UTC (permalink / raw)
To: bruce.richardson; +Cc: dev, Qi Zhang, stable
RTE_LIBRTE_I40E_ITR_INTERVAL is not used. So it should also be removed
in config/rte_config.h for meson+ninjia build.
Fixes: 864a800d706d ("net/i40e: remove VF interrupt handler")
Cc: stable@dpdk.org
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
config/rte_config.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/config/rte_config.h b/config/rte_config.h
index a8e479774..f03c526ba 100644
--- a/config/rte_config.h
+++ b/config/rte_config.h
@@ -106,8 +106,6 @@
#define RTE_LIBRTE_I40E_QUEUE_NUM_PER_PF 64
#define RTE_LIBRTE_I40E_QUEUE_NUM_PER_VF 4
#define RTE_LIBRTE_I40E_QUEUE_NUM_PER_VM 4
-/* interval up to 8160 us, aligned to 2 (or default value) */
-#define RTE_LIBRTE_I40E_ITR_INTERVAL -1
/* Ring net PMD settings */
#define RTE_PMD_RING_MAX_RX_RINGS 16
--
2.13.6
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] config: remove unused macro
2018-09-17 7:39 [dpdk-dev] [PATCH] config: remove unused macro Qi Zhang
@ 2018-09-17 8:24 ` Bruce Richardson
2018-09-19 13:56 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Bruce Richardson @ 2018-09-17 8:24 UTC (permalink / raw)
To: Qi Zhang; +Cc: dev, stable
On Mon, Sep 17, 2018 at 03:39:32PM +0800, Qi Zhang wrote:
> RTE_LIBRTE_I40E_ITR_INTERVAL is not used. So it should also be removed
> in config/rte_config.h for meson+ninjia build.
>
> Fixes: 864a800d706d ("net/i40e: remove VF interrupt handler")
> Cc: stable@dpdk.org
>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
I like code removal.
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH] config: remove unused macro
2018-09-17 8:24 ` Bruce Richardson
@ 2018-09-19 13:56 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2018-09-19 13:56 UTC (permalink / raw)
To: Qi Zhang; +Cc: stable, Bruce Richardson, dev
17/09/2018 10:24, Bruce Richardson:
> On Mon, Sep 17, 2018 at 03:39:32PM +0800, Qi Zhang wrote:
> > RTE_LIBRTE_I40E_ITR_INTERVAL is not used. So it should also be removed
> > in config/rte_config.h for meson+ninjia build.
> >
> > Fixes: 864a800d706d ("net/i40e: remove VF interrupt handler")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
>
> I like code removal.
>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-09-19 13:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-17 7:39 [dpdk-dev] [PATCH] config: remove unused macro Qi Zhang
2018-09-17 8:24 ` Bruce Richardson
2018-09-19 13:56 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).