From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 65487A034F; Tue, 6 Apr 2021 12:36:43 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2B0B6140E1E; Tue, 6 Apr 2021 12:36:43 +0200 (CEST) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mails.dpdk.org (Postfix) with ESMTP id 0D71740F35 for ; Tue, 6 Apr 2021 12:36:41 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id D93F71290; Tue, 6 Apr 2021 06:36:39 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 06 Apr 2021 06:36:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= s1B0Tebqu8mFoWjCGqoZ0qRU1IU2pyF30dPrgSt52Uc=; b=fmZrYtqLDbQYp2Gb dzbaR9Vw+GWkZIiug7mUP/ZgtJ5DfLFQFlabcaQSO7i2tnC+vRHM453hB7v0ERFX NX4BoSm0gevcIjki5xpHzbj5yuehB2lVr54gUO/piKmwKnpCEfCcwXRK0MqUuxUa u/aXwnu5Db3E3z7UhfnI9JxHL5hY+VnRazvPWxWAm6LS2DaxTiIhFQlZIFVSIma6 1Zl1e+IfGwexkwe7D4ZjOPLvVFz713etu+1DhCsRwC1dyq3h8OFnC/BqqrSdUbBu AXqF77Gid0/nH9KyKNP8Dm+NK9XmE0UXL0ne1tL9RgL3siSzGS5D+zWOjBb84dRw 5t3L2Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=s1B0Tebqu8mFoWjCGqoZ0qRU1IU2pyF30dPrgSt52 Uc=; b=r0DBMUEBHejRx5AvTZe7Msa28dMzxg2enCmE0jjaJaNR7Ob89lWnK0lc9 mLTszWaEieZrRhLRwlT4XXM3pAeO+RjRSs9OUeLgy6NP43rPEieaxXtn4qE1en0C jciuS31wsqIv7ga8NMu3UKUQaR/pXFU8acBJ4FoUZFQbUjnmzRi1/XHo0nFtDhKD QwtpTec4AL2tRJ+pAh8Cx5+/8UvIO/iCGoYTCsXRUgVNzotz7iJookaOPCoN8aGk dlzGfiuiumQYU9dQBi7FF4ps4TBD8fvIC5brylAscqxPSiJPRWuC9l7mabSc4E8O FfN7QNSJEOcoQ0ZtzrlnCkusUlh2w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudejgedgfeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepffdvffejueetleefieeludduuefgteejleevfeekjeefieegheet ffdvkeefgedunecuffhomhgrihhnpeguphgukhdrohhrghenucfkphepjeejrddufeegrd dvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhf rhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id AFADB24005D; Tue, 6 Apr 2021 06:36:38 -0400 (EDT) From: Thomas Monjalon To: David Marchand Cc: dev@dpdk.org, Ciara Power , Bruce Richardson Date: Tue, 06 Apr 2021 12:36:37 +0200 Message-ID: <7288240.ftS4rKpjl2@thomas> In-Reply-To: <20210406101838.GA551@bricha3-MOBL.ger.corp.intel.com> References: <20210406092545.24465-1-david.marchand@redhat.com> <20210406101838.GA551@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal: fix telemetry logtype registration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 06/04/2021 12:18, Bruce Richardson: > On Tue, Apr 06, 2021 at 11:25:45AM +0200, David Marchand wrote: > > rte_log_register_type_and_pick_level() returns an int. > > Casting to a uin32_t will make us miss the -1 passed in case of failure. > > > > Fixes: 37b881a96194 ("telemetry: use log function from pointer") > > > > Signed-off-by: David Marchand > > --- > Acked-by: Bruce Richardson Good catch, I missed it when doing the patch "log: choose EAL log type on registration failure" https://patches.dpdk.org/project/dpdk/patch/20210405100301.657768-2-thomas@monjalon.net/ About the title, I would not say it fixes the registration. It is more about catching registration failure with a fallback.