From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2AC48A00C2; Fri, 14 Oct 2022 12:03:40 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1982642D41; Fri, 14 Oct 2022 12:03:40 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 3C17242CF8 for ; Fri, 14 Oct 2022 12:03:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665741818; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+lrSx+PewVbw0yZW7u58xdMpK86EPAHUHiIx1lMkLUQ=; b=dqOxKX6GFpdre/o4m/pQKbh7PZL2Bkv65oTySwvpO7P6jwHGiitDpZCoDa9EixrrllcDoH 7iyshcJ5esc4hpADi6lrHX2wknqrodLgb81hyu0VuTExfZzsGHFzIRaC7qZO2VdfBx24Q/ XJeX4NJ6NSs6VgQ81/gr2bWnw8YUWrw= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-594-w4AZHqfPPUKBNDLwHxikNQ-1; Fri, 14 Oct 2022 06:03:33 -0400 X-MC-Unique: w4AZHqfPPUKBNDLwHxikNQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4D585857FAC; Fri, 14 Oct 2022 10:03:22 +0000 (UTC) Received: from [10.39.208.28] (unknown [10.39.208.28]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 91E7E40CF8F0; Fri, 14 Oct 2022 10:03:17 +0000 (UTC) Message-ID: <7288e942-687a-ba84-d972-f6e1bda4d367@redhat.com> Date: Fri, 14 Oct 2022 12:03:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v3 13/30] baseband/acc100: reset pointer after rte_free To: Hernan Vargas , dev@dpdk.org, gakhil@marvell.com, trix@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com, stable@dpdk.org References: <20221012025346.204394-1-hernan.vargas@intel.com> <20221012025346.204394-14-hernan.vargas@intel.com> From: Maxime Coquelin In-Reply-To: <20221012025346.204394-14-hernan.vargas@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/12/22 04:53, Hernan Vargas wrote: > Set local pointer to NULL after rte_free. > This needs to be set explicitly since logic may check for null pointers. > > Fixes: 060e7672930 ("baseband/acc100: add queue configuration") > Cc: stable@dpdk.org > > Signed-off-by: Hernan Vargas No new line > Reviewed-by: Maxime Coquelin > --- > drivers/baseband/acc/rte_acc100_pmd.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c > index c8dffda8a4..3914aa7814 100644 > --- a/drivers/baseband/acc/rte_acc100_pmd.c > +++ b/drivers/baseband/acc/rte_acc100_pmd.c > @@ -610,6 +610,9 @@ acc100_dev_close(struct rte_bbdev *dev) > rte_free(d->info_ring); > rte_free(d->sw_rings_base); > d->sw_rings_base = NULL; > + d->tail_ptrs = NULL; > + d->info_ring = NULL; > + d->harq_layout = NULL; > } > /* Ensure all in flight HW transactions are completed */ > usleep(ACC_LONG_WAIT);