From: Thomas Monjalon <thomas@monjalon.net>
To: declan.doherty@intel.com
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>,
Tomasz Kulasek <tomaszx.kulasek@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] net/bonding: fix link status check
Date: Tue, 06 Feb 2018 21:52:48 +0100 [thread overview]
Message-ID: <7290841.LMfcIyB1JH@xps> (raw)
In-Reply-To: <581f7aef-7dc6-22dc-f177-049e9384c051@intel.com>
17/01/2018 17:02, Ferruh Yigit:
> On 11/29/2017 3:42 PM, Tomasz Kulasek wrote:
> > Some devices needs more time to initialize and bring interface up. When
> > link is down the link properties are not valid, e.g. link_speed is
> > reported as 0 and this is not a valid speed for slave as well as for whole
> > bonding.
> >
> > During NIC (and bonding) initialization there's concurrency between
> > updating link status and adding slave to the bonding.
> >
> > This patch:
> >
> > - adds delay before configuring bonding (if link is down) to be sure that
> > link status of new slave is valid,
> > - propagates information about link status from first slave with link up
> > instead of first slave at all, to be sure that link speed is valid.
> >
> > Fixes: 6abd94d72ab5 ("net/bonding: fix check slaves link properties")
> > Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>
> > ---
> > v2 changes:
> > - Checkpatch warnings,
> > - Improved code style
> Hi Declan,
>
> Any comment on this patch?
Any news?
next prev parent reply other threads:[~2018-02-06 20:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-29 14:53 [dpdk-dev] [PATCH] " Tomasz Kulasek
2017-11-29 15:42 ` [dpdk-dev] [PATCH v2] " Tomasz Kulasek
2018-01-17 16:02 ` Ferruh Yigit
2018-02-06 20:52 ` Thomas Monjalon [this message]
2018-02-12 18:26 ` Chas Williams
2018-06-13 16:10 ` Ferruh Yigit
2018-06-18 8:39 ` Ferruh Yigit
2018-02-16 20:13 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7290841.LMfcIyB1JH@xps \
--to=thomas@monjalon.net \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=tomaszx.kulasek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).