From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 1B1C41B415 for ; Tue, 6 Feb 2018 21:52:53 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 6968720C08; Tue, 6 Feb 2018 15:52:53 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Tue, 06 Feb 2018 15:52:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=5REleDZBaEXGPkf6i4gUevvCJ8 /mW+wCYBcBXaNigoE=; b=Vj4j5z3lyLU61jbcr3+D9woqDA6zfVAB1VWw5bHY4y 4zLEqgxgnfp+RuNGVdI0P/hasyJ1sA0t1dKXLJHCZfy1f2j39qsaWZ9vasAeKehF LGXYU8IRPADb17Nd1CR4FQSKNcb9unTsoQynGLi6KLLsS2TVw3cp2II1BOj6nQJr o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=5REleD ZBaEXGPkf6i4gUevvCJ8/mW+wCYBcBXaNigoE=; b=OId2lq6BKHoq94U0U8oe2w j2yI645SZxLJ0kLXZh606QX7cl2Np8K+nVLEzqrFs/dUaAXBwD35gL0eWQ1XjSF5 KLOYm4Ae57x7c571+VPVOkaDWFopMiNjqRuV7xdPsdK/3QCHUGsGo+AIWElnEvit ZUfpeIUgSIhXr10MFPO+z0BUPg6NYcOaIYzhqD3cZ50WDyJVO4Fq1H0sBQggJUzi bWm+xfcPnTlXiCw5DQPK3G8ccyBmjGgrSREP0Vxdrzm703W68Ofgs342r4Dw4qeb EQlZ5h/Wb9PQNCko1CI4p5of1A1M0CSN3LvF7I9ifCCGo5N/obPI+fgGysCN+zPw == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 1F20A24804; Tue, 6 Feb 2018 15:52:53 -0500 (EST) From: Thomas Monjalon To: declan.doherty@intel.com Cc: dev@dpdk.org, Ferruh Yigit , Tomasz Kulasek Date: Tue, 06 Feb 2018 21:52:48 +0100 Message-ID: <7290841.LMfcIyB1JH@xps> In-Reply-To: <581f7aef-7dc6-22dc-f177-049e9384c051@intel.com> References: <20171129145349.43448-1-tomaszx.kulasek@intel.com> <20171129154200.14436-1-tomaszx.kulasek@intel.com> <581f7aef-7dc6-22dc-f177-049e9384c051@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] net/bonding: fix link status check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Feb 2018 20:52:54 -0000 17/01/2018 17:02, Ferruh Yigit: > On 11/29/2017 3:42 PM, Tomasz Kulasek wrote: > > Some devices needs more time to initialize and bring interface up. When > > link is down the link properties are not valid, e.g. link_speed is > > reported as 0 and this is not a valid speed for slave as well as for whole > > bonding. > > > > During NIC (and bonding) initialization there's concurrency between > > updating link status and adding slave to the bonding. > > > > This patch: > > > > - adds delay before configuring bonding (if link is down) to be sure that > > link status of new slave is valid, > > - propagates information about link status from first slave with link up > > instead of first slave at all, to be sure that link speed is valid. > > > > Fixes: 6abd94d72ab5 ("net/bonding: fix check slaves link properties") > > Signed-off-by: Tomasz Kulasek > > --- > > v2 changes: > > - Checkpatch warnings, > > - Improved code style > Hi Declan, > > Any comment on this patch? Any news?