From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 0CE07A046B for ; Wed, 29 May 2019 08:48:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0F0BF2C55; Wed, 29 May 2019 08:48:27 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 0BA6C1D7 for ; Wed, 29 May 2019 08:48:26 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5D88B81E14; Wed, 29 May 2019 06:48:21 +0000 (UTC) Received: from [10.36.112.24] (ovpn-112-24.ams2.redhat.com [10.36.112.24]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 528DF5D9C3; Wed, 29 May 2019 06:48:16 +0000 (UTC) To: Lance Richardson , dev@dpdk.org Cc: ajit.khaparde@broadcom.com, ferruh.yigit@intel.com References: <20190521213953.25425-1-ajit.khaparde@broadcom.com> <20190528192339.10903-1-lance.richardson@broadcom.com> <20190528192339.10903-5-lance.richardson@broadcom.com> From: Maxime Coquelin Message-ID: <7293818a-8104-6dbc-a772-e86e7bea2fa8@redhat.com> Date: Wed, 29 May 2019 08:48:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190528192339.10903-5-lance.richardson@broadcom.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Wed, 29 May 2019 06:48:24 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v3 4/8] net/bnxt: implement vector mode driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 5/28/19 9:23 PM, Lance Richardson wrote: > diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c > index 5b3932b7b..bccba445a 100644 > --- a/drivers/net/bnxt/bnxt_ethdev.c > +++ b/drivers/net/bnxt/bnxt_ethdev.c > @@ -638,13 +638,73 @@ static int bnxt_scattered_rx(struct rte_eth_dev *eth_dev) > > buf_size = (uint16_t)(rte_pktmbuf_data_room_size(rxq->mb_pool) - > RTE_PKTMBUF_HEADROOM); > - if (eth_dev->data->dev_conf.rxmode.max_rx_pkt_len + > - VLAN_TAG_SIZE * BNXT_NUM_VLANS > buf_size) > + if (eth_dev->data->dev_conf.rxmode.max_rx_pkt_len > buf_size) > return 1; > } > return 0; > } It seems you forgot to squash this in patch 3.