From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3B6F7A0562; Mon, 3 May 2021 23:35:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C9ACD40150; Mon, 3 May 2021 23:35:25 +0200 (CEST) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mails.dpdk.org (Postfix) with ESMTP id 4DB154014E for ; Mon, 3 May 2021 23:35:24 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 1F1661B25; Mon, 3 May 2021 17:35:23 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Mon, 03 May 2021 17:35:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= a6vKIbTY/uESf5DZF3WQl6xp3Om4B1+vzZZUTxxv6wA=; b=Xt9PrBfjOkoAb81z TP/lzNS/scUqRL8ZUzmI/Y1Mv5WC2LGvyUSSEqRcCyYHDSBZAdkMf/bM8HvIscvD FD2zeYXjfiuJGux61mNePswXc2hNge8wzz3Rm10ZeRA2QhniUw0eo2H1EIIMKRI9 1yBaKLwoHFjO+kSZN6purv6ShEhHRjGyB1ke40B/IHhVGAenpmE/3vxo28Xxtnqu C43ZzgMEmMNtgO71yUszbB59DnbeqQhRihIHoXAFuF45d0NaJxU8nTHuX+nUnZJM XiAFYoeadkjzJ3W2gfuzU+QOPq8iVMHh9rLqv+N2/0tBKrqXwppWZMyKMu3JkUCc L4o8Gw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=a6vKIbTY/uESf5DZF3WQl6xp3Om4B1+vzZZUTxxv6 wA=; b=Ri8gVlNrKl3ppk3huferSx4juc4khkoBpOpw10FXQr6qO4vO2Sqk/UHNd SPUr2zZDOkkmg+mPJe81zDnjIaBpygYi0yQt49irmrpCGgyqE4fX1YwJpO/uD7OY 5Gk43e4POq3JT/v/b52FJILgUMyxBXVH/SoB+yYecCTT9RFJlQaxt4LPOU7q8eNL /iChQQDrbWtpCdUpxxCljXREKgDYHc0dQEeao5cL5MpZvCQMDSKiSFC5SqQfrxUq ZWC/Wfl3IbXvcaLigR+Ch22JM3lw4oMewt/3CoG2OHy42oG/e2wq4jUFpohlK6TJ wVRbTNySM+DqmteMsFytY02wm+AdA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdefgedgudeihecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 3 May 2021 17:35:21 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, kevin.laatz@intel.com, sunil.pai.g@intel.com, jiayu.hu@intel.com Date: Mon, 03 May 2021 23:35:20 +0200 Message-ID: <7298907.SmeENqnXTm@thomas> In-Reply-To: <20210430150637.362610-10-bruce.richardson@intel.com> References: <20210318182042.43658-1-bruce.richardson@intel.com> <20210430150637.362610-1-bruce.richardson@intel.com> <20210430150637.362610-10-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 09/12] raw/ioat: move idxd functions to separate file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 30/04/2021 17:06, Bruce Richardson: > Split the rte_ioat_rawdev_fns.h file into two separate headers, so that the > data structures for the original ioat devices and the newer idxd ones can > be kept separate from each other. This makes code management and rework > easier. > > Signed-off-by: Bruce Richardson > --- > --- /dev/null > +++ b/drivers/raw/ioat/rte_idxd_rawdev_fns.h > @@ -0,0 +1,275 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2021 Intel Corporation > + */ > +#ifndef _RTE_IDXD_RAWDEV_FNS_H_ > +#define _RTE_IDXD_RAWDEV_FNS_H_ Please add a doxygen @file to explain the purpose of this file. The same is needed for rte_ioat_rawdev_fns.h. We miss the explanation of the difference between ioat and idxd.