DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Harold Huang <baymaxhuang@gmail.com>, <dev@dpdk.org>
Cc: <stable@dpdk.org>, Liron Himi <lironh@marvell.com>
Subject: Re: [PATCH] net/kni: initialize rte_kni_conf to 0 before using it
Date: Fri, 4 Mar 2022 14:27:22 +0000	[thread overview]
Message-ID: <72a6e129-1da1-5c00-b582-a55db54fbd9c@intel.com> (raw)
In-Reply-To: <20220303021803.382374-1-baymaxhuang@gmail.com>

On 3/3/2022 2:18 AM, Harold Huang wrote:
> When kni driver calls eth_kni_start to start device, some fields such as
> min_mtu and max_mtu of rte_kni_conf are not initialized. It will cause
> kni_ioctl_create create a kni netdevice with a random min_mtu and max_mtu
> value. This is unexpected and sometimes we could not change the kni
> device mtu with ip link command.
> 
> Fixes: ff1e35fb5f83 ("kni: calculate MTU from mbuf size")
> Cc: stable@dpdk.org
> Signed-off-by: Harold Huang <baymaxhuang@gmail.com>
> ---
>   drivers/net/kni/rte_eth_kni.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/kni/rte_eth_kni.c b/drivers/net/kni/rte_eth_kni.c
> index c428caf441..ba58d9dbae 100644
> --- a/drivers/net/kni/rte_eth_kni.c
> +++ b/drivers/net/kni/rte_eth_kni.c
> @@ -124,7 +124,7 @@ eth_kni_start(struct rte_eth_dev *dev)
>   	struct pmd_internals *internals = dev->data->dev_private;
>   	uint16_t port_id = dev->data->port_id;
>   	struct rte_mempool *mb_pool;
> -	struct rte_kni_conf conf;
> +	struct rte_kni_conf conf = { 0 };

This is causing build error [1], updated in next-net [2] to fix.

Normally '{ 0 }' should be universal zero-initializer, but I guess
it fails because of old compiler version:
gcc 4.8.5 "cc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-44)"


[1]
FAILED: drivers/a715181@@tmp_rte_net_kni@sta/net_kni_rte_eth_kni.c.o
../drivers/net/kni/rte_eth_kni.c: In function 'eth_kni_start':
../drivers/net/kni/rte_eth_kni.c:127:9:
	error: missing braces around initializer [-Werror=missing-braces]
   struct rte_kni_conf conf = { 0 };
          ^

[2]
struct rte_kni_conf conf = {{0}};

>   	const char *name = dev->device->name + 4; /* remove net_ */
>   
>   	mb_pool = internals->rx_queues[0].mb_pool;


      parent reply	other threads:[~2022-03-04 14:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-02 12:33 Harold Huang
2022-03-02 18:16 ` Ferruh Yigit
2022-03-03  1:57   ` Harold Huang
2022-03-03  2:18 ` Harold Huang
2022-03-03 11:31   ` Ferruh Yigit
2022-03-04 14:27   ` Ferruh Yigit [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=72a6e129-1da1-5c00-b582-a55db54fbd9c@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=baymaxhuang@gmail.com \
    --cc=dev@dpdk.org \
    --cc=lironh@marvell.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).