DPDK patches and discussions
 help / color / mirror / Atom feed
From: huangdengdui <huangdengdui@huawei.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: <dev@dpdk.org>, <lihuisong@huawei.com>, <fengchengwen@huawei.com>,
	<liuyonglong@huawei.com>
Subject: Re: [PATCH 6/6] net/hns3: VF support multi-TCs configure
Date: Tue, 1 Jul 2025 17:05:11 +0800	[thread overview]
Message-ID: <72d2d4b5-ccc6-4afc-9031-06e2671f6393@huawei.com> (raw)
In-Reply-To: <20250629104055.0b38c168@hermes.local>


On 2025/6/30 1:40, Stephen Hemminger wrote:
> On Wed, 11 Jun 2025 16:19:00 +0800
> Dengdui Huang <huangdengdui@huawei.com> wrote:
> 
>> +#pragma pack(1)
>> +#define HNS3_MBX_PRIO_SHIFT	4
>> +#define HNS3_MBX_PRIO_MASK	0xFu
>> +struct hns3_mbx_tc_config {
>> +	/*
>> +	 * Each four bits correspond to one priority's TC.
>> +	 * Bit0-3 correspond to priority-0's TC, bit4-7 correspond to
>> +	 * priority-1's TC, and so on.
>> +	 */
>> +	uint32_t prio_tc_map;
>> +	uint8_t tc_dwrr[HNS3_MAX_TC_NUM];
>> +	uint8_t num_tc;
>> +	/*
>> +	 * Each bit correspond to one TC's scheduling mode, 0 means SP
>> +	 * scheduling mode, 1 means DWRR scheduling mode.
>> +	 * Bit0 corresponds to TC0, bit1 corresponds to TC1, and so on.
>> +	 */
>> +	uint8_t tc_sch_mode;
>>  };
>> +#pragma pack()
>>  
> 
> DPDK has portable macros for packing __rte_packed_begin and __rte_packed_end.
> Please change to using those macros.
> Then rebase, retest and resubmit this patcheset

Okay, I have modified and pushed the new version.

  reply	other threads:[~2025-07-01  9:05 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-11  8:18 [PATCH 0/6] net/hns3: VF support multi-TCs Dengdui Huang
2025-06-11  8:18 ` [PATCH 1/6] net/hns3: fix VF fail to config queue TC Dengdui Huang
2025-06-11  8:18 ` [PATCH 2/6] net/hns3: remove duplicate struct field Dengdui Huang
2025-06-11  8:18 ` [PATCH 3/6] net/hns3: refactor DCB module code Dengdui Huang
2025-06-11  8:18 ` [PATCH 4/6] net/hns3: VF support parse max TC number Dengdui Huang
2025-06-11  8:18 ` [PATCH 5/6] net/hns3: VF support discover multi-TCs capability Dengdui Huang
2025-06-11  8:19 ` [PATCH 6/6] net/hns3: VF support multi-TCs configure Dengdui Huang
2025-06-29 17:40   ` Stephen Hemminger
2025-07-01  9:05     ` huangdengdui [this message]
2025-06-25  6:46 ` [PATCH 0/6] net/hns3: VF support multi-TCs huangdengdui
2025-07-01  6:45 ` [PATCH v2 " Dengdui Huang
2025-07-01  6:45   ` [PATCH v2 1/6] net/hns3: fix VF fail to config queue TC Dengdui Huang
2025-07-01  6:45   ` [PATCH v2 2/6] net/hns3: remove duplicate struct field Dengdui Huang
2025-07-01  6:45   ` [PATCH v2 3/6] net/hns3: refactor DCB module code Dengdui Huang
2025-07-01  6:45   ` [PATCH v2 4/6] net/hns3: VF support parse max TC number Dengdui Huang
2025-07-01  6:45   ` [PATCH v2 5/6] net/hns3: VF support discover multi-TCs capability Dengdui Huang
2025-07-01  6:45   ` [PATCH v2 6/6] net/hns3: VF support multi-TCs configure Dengdui Huang
2025-07-01  9:09 ` [PATCH v3 0/6] net/hns3: VF support multi-TCs Dengdui Huang
2025-07-01  9:09   ` [PATCH v3 1/6] net/hns3: fix VF fail to config queue TC Dengdui Huang
2025-07-01  9:10   ` [PATCH v3 2/6] net/hns3: remove duplicate struct field Dengdui Huang
2025-07-01  9:10   ` [PATCH v3 3/6] net/hns3: refactor DCB module code Dengdui Huang
2025-07-01  9:10   ` [PATCH v3 4/6] net/hns3: VF support parse max TC number Dengdui Huang
2025-07-01  9:10   ` [PATCH v3 5/6] net/hns3: VF support discover multi-TCs capability Dengdui Huang
2025-07-01  9:10   ` [PATCH v3 6/6] net/hns3: VF support multi-TCs configure Dengdui Huang
2025-07-01 15:16 ` [PATCH 0/6] net/hns3: VF support multi-TCs Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=72d2d4b5-ccc6-4afc-9031-06e2671f6393@huawei.com \
    --to=huangdengdui@huawei.com \
    --cc=dev@dpdk.org \
    --cc=fengchengwen@huawei.com \
    --cc=lihuisong@huawei.com \
    --cc=liuyonglong@huawei.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).