From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0059.outbound.protection.outlook.com [104.47.1.59]) by dpdk.org (Postfix) with ESMTP id 47F8D137C for ; Tue, 18 Sep 2018 14:44:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SkQ0I4WLy26DhW2f0P+yVb+tYsMix5fwLXJWK5G4YlU=; b=Dd9qW5MEzVfxrhNLus0rIT9jgfIbsCEBQlNLZC3YBwOdyNSjltTKv0HmdXMotl09+pp//vTsaPIuYk7LjtFYwY60iFXZ3KIfAMPz8Y2mbxdRaPvCIOXiGMqPBpYi4Iqe2EkaZe+gEDnSAGE+wnzMZ5FWrsczU/Rv+seYGFUnK5w= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; Received: from [10.232.134.144] (14.143.30.134) by VI1PR04MB4893.eurprd04.prod.outlook.com (2603:10a6:803:56::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1143.17; Tue, 18 Sep 2018 12:44:20 +0000 To: Joseph@dpdk.org, "Joseph, Anoob" , Pablo de Lara , Thomas Monjalon Cc: "Dwivedi, Ankur" , "Jacob, Jerin" , "Athreya, Narayana Prasad" , "dev@dpdk.org" , "Murthy, Nidadavolu" , "Dabilpuram, Nithin" , "Jayaraman, Ragothaman" , "Srinivasan, Srisivasubramanian" , "Tejasree, Kondoj" References: <1528476325-15585-1-git-send-email-anoob.joseph@caviumnetworks.com> <1536033560-21541-1-git-send-email-ajoseph@caviumnetworks.com> <1536033560-21541-2-git-send-email-ajoseph@caviumnetworks.com> <8421735d-1357-e444-9924-390f23827f3e@nxp.com> <95e172a1-2f81-3e8f-7fba-8373e64428d8@caviumnetworks.com> <06b2d39f-5d9a-d1e2-f3bb-5238e40e6406@nxp.com> <23e3b8a8-32f9-cd91-bef9-c03eff0d4e46@caviumnetworks.com> <9354973e-1d6e-522f-b4f3-bd767db498a3@caviumnetworks.com> From: Akhil Goyal Message-ID: <72fa8f89-0a3a-afe5-7c85-1477c5b14698@nxp.com> Date: Tue, 18 Sep 2018 18:14:08 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <9354973e-1d6e-522f-b4f3-bd767db498a3@caviumnetworks.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [14.143.30.134] X-ClientProxiedBy: BM1PR0101CA0043.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:1a::29) To VI1PR04MB4893.eurprd04.prod.outlook.com (2603:10a6:803:56::26) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7d7501c4-7759-40b6-5f53-08d61d6475ac X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534165)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:VI1PR04MB4893; X-Microsoft-Exchange-Diagnostics: 1; VI1PR04MB4893; 3:HVxYSiwzA9olZehPCA1gMlc5Ys4jX3sJsMv4HE3Q/33KYjuzo3q6+sX+E9QQ6d5HldxWfn642nhQiwW/3gKqLS8EL5UfEZnjLnZ7Ktb2mMht6E2jI3qa7uzOp/0Zb4JQI7fVZAMEiAQqTtqUlTysMyfxPZdR53wpoDxR3cU6MjSAqiUNSZZ2WBSfYSPdTT/sXX8Uzkw0mbdELxrjSHc9BZOhqMeyQlHCHw3kCQWkwvjOCXBdLajae5wiY82pzYbl; 25:qcitlRea8ipdZ5qlhSLGhDxnyrEnL78Z0Nn74o3B5gTnzhLkhCfu8JKfbHDBB1b/kAdVyFNQgnWPvAwVU7xzFywYo9fnnIO3txQTnLuSUk7PoIbGCwjEuNOmS66Y1pq7NKmSE1wJjbsIxatb2EhnXC0ju2H/xfg1p7ou46M8zT/v/Gog13Jwqkn5/50nT5G/kORm/7KFFMTH6L8jkkAAOcUJoqH/ZLd1xn5PsizUsq0JgiWoKY6sT6qlxQMtzXG2Dz7+Xh4tbKl7TIG2HAbunlVe2i0dqFfET5Kl8uTbsZi/ufM87A96Vt+r1ex3GGSAeY92ZE0A0Ku2ZP94scUG6Q==; 31:R57ejAMJMbVlLQK5hjTVto8KgmqYFiAiirIi5I7Y3W697nMtdAHTL9bvOq9YilYQas72MlKkMXPksw9LZnbQxsVhw1bMN6AmXAAYFhMnGVbUTd+9D+zjgEm2GjfcQraNuSvj9TezXQ1j23BSpApF4V0h5cYzL1xupuwDu7hwOnpj7CJo+5pLDMUxTdfONBalfEloMlP/4fWZb1eCbuwP4u1iB5jbZRhvejtWnfassIo= X-MS-TrafficTypeDiagnostic: VI1PR04MB4893: X-Microsoft-Exchange-Diagnostics: 1; VI1PR04MB4893; 20:rq1gTwRIAPNPiwbGY2mdj27g8bhyraf4QtNzFQDgKkekqG4vN9ww/RTIj8S4E8gy5kF2xwewlXHBT58Dd5WZwR8mHLbL5W8gt65dDIRBGgtqkfp137CJ8XnP6AG+5MS+xY33vwJhuGEIMw7K5JGk3tHvylOhXCwu91Q5Q2poRDh0JrpzbUDZZoD2iUhqYS6up9BTCFyuDD+OlHqRr7YjTG73769K82Sg76MU006akWO+b9+qAgn9eBWk5BVqhehxEgqE4lysuUmb2M4qpsh1b+6j6dxfILFCv9SVmvZ62CpGj3ax9gmYW5sJHp2qHzIfn2/+PwajkVSLG3x6aBMJUPwKjIdZz6Jw2d9KhGctNKh5rjEJlNc3kag2bXt9ZvGrHCq/mVKwLheel/NHMlvT2ZdoTSlfG++szqOzXXFBKcjfd252o3BXz41V5EU1g48DzZBARG/SnPwavuc3VL3Tw/mQo77QalxOxlbP8s4+xf9LkG++fnSh70z0Xzep/dzo; 4:RZnVuTza4KfZ8hKWcG80wZJeHCHFS+zbQyvtboXYVptqjp79rZO7YT1JO0LqdC23G0/LimFs5xX6cPPE0jHsKvapNB0joVdmSoPDqcdPrA+KSYZ6rzWwVvpdsP5ttIAEL6sf+v4ShhWh+8HiJ+cZmuHJcFASSSJIEF3NpH2qBFZPB9Oihs2h3zACoN3OWZ0FJDtgfpeGhH8Fjf3fAoJaL5ZzkEMtT6YhqrFBuF0nkFxSrSj4vZ8JSKXilgrepAFIhUlIjyoqKTPKjoxqUixBQA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231355)(944501410)(52105095)(93006095)(93001095)(3002001)(10201501046)(6055026)(149027)(150027)(6041310)(20161123564045)(20161123558120)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(201708071742011)(7699050); SRVR:VI1PR04MB4893; BCL:0; PCL:0; RULEID:; SRVR:VI1PR04MB4893; X-Forefront-PRVS: 0799B1B2D7 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(376002)(346002)(136003)(396003)(366004)(39860400002)(199004)(189003)(51444003)(5660300001)(53936002)(2486003)(58126008)(110136005)(76176011)(23676004)(52146003)(16576012)(6486002)(53546011)(478600001)(7736002)(3846002)(6666003)(64126003)(6116002)(50466002)(486006)(105586002)(54906003)(476003)(2616005)(5009440100003)(106356001)(229853002)(305945005)(44832011)(11346002)(6246003)(97736004)(52116002)(65956001)(66066001)(65806001)(31686004)(956004)(67846002)(14444005)(2906002)(316002)(7416002)(4326008)(81156014)(81166006)(86362001)(47776003)(36756003)(26005)(93886005)(68736007)(3260700006)(446003)(77096007)(186003)(386003)(8936002)(31696002)(65826007)(8676002)(16526019)(25786009)(2870700001)(110426005); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB4893; H:[10.232.134.144]; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtWSTFQUjA0TUI0ODkzOzIzOnEyd1BCUW5rYTJ3M3BHeHE4Wkh4MFd2MFZS?= =?utf-8?B?TnVjd2hpNDl6RHlRN2JPRlRwUEJWSE84bmtFZVFGWGk4dHJxSjNVN1RuSkVh?= =?utf-8?B?OUZNVzdUQUdXRk95MlhKbGduK3lNcVRMS1hCZ1V0SkFJenZUMFRxWGJ2Qjcv?= =?utf-8?B?TXhpWS9WUGR5Nk8rR2tJY2tjL2FGY0JoVThDdzlPSE1kckhYNm1GTnZqREhM?= =?utf-8?B?c3RDcXh5d1hZRUhIcDZCQmEyUjNvSVhZRTdIYUNrVlp1bnVFRnc0ZWlTMWdD?= =?utf-8?B?MlV6VE5Wb0prY1VPcnZCeTlzc0FTamJOV2ZvS3c3d1BUK3N0QTVWU2g5aHlL?= =?utf-8?B?NitDNDMyZEJTQWQzZlRPVlBhZklwYVhrOEJBYWFzbmtHZDdxMUN4T1NIa1NH?= =?utf-8?B?N2N6RmxTNWtaa2lxTHhnTVQ2Q0dwcENWaDZLYmtMQ05Nc2QwSUVkQ2pjZEtX?= =?utf-8?B?dExKNi9QNlZ0VkJJdkViNXp3djZBWDNXM3RyMm93cGRsZFpUWVp2dnp2VkpY?= =?utf-8?B?NVpvUStqaG9OZjNIQm4vYW1MTlM0OWRuZEpZeDU1ZXZSVG80bzR2Y3o1L2lh?= =?utf-8?B?MDNHUmdvcVVreDFxSHQ4dkVTNzNYZTduM2lFQVhVcTdwOU5FbWFtL0Y2c3gz?= =?utf-8?B?eDFCVXliOWZRV3JDWlRRRWpBVFNHbXhScW9McGF4QTBGMldKOUFDUVNXalN2?= =?utf-8?B?WUpuVzJJV29SK3pWeUV3Y25abHZhcndRaWFRV210WVdBSStvV1ZVQ1VZL215?= =?utf-8?B?N0czbUtFVmMyY0tBWHZ3MWZDeVFJcVVwT0RBSVpNMG5tWk1FM0RtdGkweFZ4?= =?utf-8?B?dkpvMCtuK2R4QlIzc1VralhBM1FyTE9renlNaFNEWDRoSldadjhFaHRvV1JZ?= =?utf-8?B?WElWZE80MmZXVC96N0ZUVUxydDlOaFFXUUR2QzB6RzN4RFVYSitja2Z4ajlh?= =?utf-8?B?RXZ5UnN3RklZYTRJd3VSbi9yZ2YzRFhacDQ1UHIrU2Eya0xWVUxmN2FMc3hO?= =?utf-8?B?Smd5M2V1YmdtU0lPRGtDZFJ5b2x4elFGNnE3R2I3Z2x4bzNSM3FmRHVISEZL?= =?utf-8?B?MkNOU3pVOHZ6WVhMQkdGNkVXTWhOUTdOMzR0dkoyZDRKNVJQNG11Y2hidGhC?= =?utf-8?B?VE9GcTZuTDlZU1Q4VU5xWkR6QXdqV1NJUjUralNXaUJZdnlxcTM5d09SN2c3?= =?utf-8?B?dDRITGQ2c2ZGc0N5ZWd3amFEbHpybEd5TlFpVkpYREttZnF6bE9DWkVDR3Bw?= =?utf-8?B?MnhWNFFIU2FoT0J2Q2pSdTY5Unc2a1pUT3ZDVyt2RlNhSE9vVG15dHRQOTJ5?= =?utf-8?B?UHdmZFVHcVJHM1Jua3R0OHpaaXljRE56M2ZEMFo5UEoxQWY1aHVHMVlnOGln?= =?utf-8?B?QXBQQWJSV1RSU1RDczNiWG1pQjdUbzVlZTdjNTRBOXNtU0xVWExiZ1NYR2Vt?= =?utf-8?B?NUxVNEZ1b3Bid3JQWExvNHZuQzRuYy9XVVp4SXFHRzc3MWlyOVZ3b1ZhUENw?= =?utf-8?B?R2hZK04rMGZqNlAzUUsvU2VKVlgvWEdreitWbDJVWXdoQlZGM2REZ3YvbkFM?= =?utf-8?B?L0QwaWZHOUsyV0t3bjlrQllUaVNiL2MrMm5Ta283UW9raEEyT0d5dVprSzUx?= =?utf-8?B?QWtBc3IyYXhVWTFNTTdrWEUrdWNScmxNMDdtV2o1cTRhb2J4SUsvNGhCR1V4?= =?utf-8?B?WWpWR0lnaDg4UXJOZ2ZXTHg1Y05hd2krVmp0MzM3bEVhN2V1MjdIUzhEUnpq?= =?utf-8?B?eGdrVnZoclVEdHJKcUh0VnJ5THpOSnNlb1BiaS9nbm9yYlU4cGVFYjRiR1ZS?= =?utf-8?B?d3kzRVJZMndxUzFQeTF4MDdRVWhyZUw2a2FsOEE2RW1HNEs0WGkwUlh1blBq?= =?utf-8?B?UCtXdUl4aTdpbWZtMVNwU0pWSFBkYUVvOTZRMVk5emx4L2lHSUNHTUtKNkZX?= =?utf-8?B?cjd3TUdWdS9nT1JGRW5hQmsvcENsT3Ridk8xNk4wbjB1cmZQTS8zelZvYnlJ?= =?utf-8?B?LzFIMGRyOTZOM2M0N2llZENIUDZ3UmtlY0ZkaHpHNEVmRDNzSUF4anBiK1d5?= =?utf-8?B?VnRQejF3YnRSZk05SGx6bVc3dEdpRTlMbm90UHNsOW9TRlFlMitSWnByOTNS?= =?utf-8?B?L1orTnRLaGE2QWJGd0ZkTWRwUEVVWjA1R0tiU2xaZjNTakpxdktyamJUamhQ?= =?utf-8?Q?qt46UxS7fVEIxik28TyrufgcJYLcHxWNHIbiS3Wb60=3D?= X-Microsoft-Antispam-Message-Info: AaRObQ353f9CIrbzeafL0ktRk9Z81ElCy63CbTQ2kexzLfj4pVjdif4VLP6fo6VNT+xrMkL13MYsPXaZpKSVMmkeThaX8TfpxcxFyjNJDXLaTlmnqAq+yp4B8xdIM1xfCnY/Q2XWKExDEeLia3EsWuyL423HcGWaTJxAtGitSVDTfMPZ0yUs5nhfwpFHCmqEjcmMC6679OLTYRg1r23qDyQWcpVuERJhrofEETGcJAReKllTQ2/u4/fdAzm/KdY5gYB4MOjmkPJpm//czGQl2EHHZwJJ+RB00Hay7sOd5HgYheH8TvcCfn0KO5FVmpaP/w8VhLv+domaJ/azPUqFNd0121/92Le2I3vmhC8p0NI= X-Microsoft-Exchange-Diagnostics: 1; VI1PR04MB4893; 6:lrHiJDIhbLBNrFe69WPt0kz2Nw/lRgQ1rbOmo97ZzSPVNeLo0C5CrIqXXPAwPVIhf0qcBVCFITztyqngyMPhI2hXKbFIgw0dmZGLwuZoSlwAllRTpUmYWsCK3zHJI4PgDIaT2LYM7WrMWIMxxrdTbLUA79ePm1eGLVxxHC/uMO/4PZ271spRsIwllWX0zwmt8XMkQWTvm0IIsSC7OH6m8mjR22LzuQ3kfKBMYejVk0MsPeYdNi8dmTDQJMAEzIaSrgP2/drkyy0a56Z4teEwOg9IeTC1UHRMySCJnMSo07lMTgDzbg3eJ9uUrjAqb2f4ZCHkX4vk8JZnsYa6w8VhzuodvHfDOoNS8mHSCTTvVtp63zC82/HIF0q1zVaWvgtuAAluARk3fnq8mnIqSxfHJ79YtDKr1LPDLlnsDFxu/Sv8bEXXwEGDnhK0sPAExkzov32RjI/kmQSS7OxM8tCxLw==; 5:gZTzTx/rR2UJkGF4tbbusE303kaggdGAyiJNBZ0i8ZqqtoD2EQrBK5QfQS6vw9SWHc5dhrUk1kdtmM4SRKdcKNAnEEeQuVRl7vaXR56/AXl+/dLs9SWSbFlQoaXQCyrGar7+myMC1I8SyJn0KaVBBNO8RRv5h6iJQkqX3PJga9c=; 7:lsYyLOl5Fi0NJqrNbspXVQyg+xylTTBn5X2BZSI/RLpRIB6kTnpROEro4wRvFqJ25evldV2iXFB0GSeC8Sm00yQbHgf/y0Lw8uiiiEybZIt+89uj5bWi8i8RkvALHovMKgDnfLrg1slz9CerfJPnsFwjIQHvo6ZBr44VVfsJbs5wo/M9Ab4iZ1EUqmi66f0hJu5tg65OkfD5gHgoeL3apToAcBowd1uEgaoS4QvyiAP4NDs0mAovw3ZzGObJjod5 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2018 12:44:20.4076 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7d7501c4-7759-40b6-5f53-08d61d6475ac X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4893 Subject: Re: [dpdk-dev] [PATCH v2 01/33] config: add Cavium OcteonTX crypto PMD skeleton X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Sep 2018 12:44:24 -0000 On 9/18/2018 6:10 PM, Joseph@dpdk.org wrote: > Hi Akhil, > > On 18-09-2018 18:01, Akhil Goyal wrote: >> External Email >> >> Hi Anoob, >> >> On 9/17/2018 7:43 PM, Joseph, Anoob wrote: >>> Hi Akhil, >>> >>> >>> On 17-09-2018 17:50, Akhil Goyal wrote: >>>> External Email >>>> >>>> On 9/17/2018 5:12 PM, Joseph, Anoob wrote: >>>> >>>>> Hi Akhil, >>>>> On 17-09-2018 16:07, Akhil Goyal wrote: >>>>>> External Email >>>>>>>> I think it would be better to squash the makefile related >>>>>>>> changes in >>>>>>>> the 3/33 patch as the code >>>>>>>> is actually added in that and here the code is not getting compiled >>>>>>>> here. >>>>>>> So the changes in the following files has to be moved to patch 3/33? >>>>>>>    drivers/crypto/Makefile >>>>>>>    drivers/crypto/meson.build >>>>>>>    drivers/crypto/octeontx/Makefile >>>>>>>    drivers/crypto/octeontx/meson.build >>>>>>>    mk/rte.app.mk >>>>>>> I think this patch will just have MAINTAINER edit (even that >>>>>>> might be >>>>>>> required to be moved to 3/33?) & changes to config/common_base, >>>>>>> after >>>>>>> that. Is that fine? >>>>>> In my opinion, you do not need this patch as separate one. >>>>>> config/common_base can also be added in the 3/33. >>>>> In that case 02/33 patch would become the first patch right? The same >>>>> problem would be there too, I guess. The macros added in that patch >>>>> gets >>>>> used only in 03/33 patch. Is that fine? >>>> I think that would be fine. Better to have a 03/33 patch before 02/33 >>>> if it doesn't have dependencies. >>> 03/33 patch is dependent on 02/33 patch. Shall I proceed with merging >>> 01/33 to 03/33 and make 02/33 the first patch? >>>>> The first patch would be a shell patch for most PMD additions. That's >>>>> the reason we started this way. If you want it changed, will do so. >>>>> Please do let me know what will be the right approach. >>>> For the makefiles, you would be compiling the empty files which does >>>> not have any code. That does not make any sense to me. >>> With 01/33 there won't be any files compiled. We are just adding the >>> library (which would be empty) >>>> Normally, when we submit a new PMD, we add the basic PMD probe/remove >>>> in the first patch and add it into build system. Maintainers is also >>>> updated for the new PMD. >>>> >>>> Further ops are added later in the patchset. >>>> >>>> Hardware specific header files/ functions are added before they are >>>> used in the driver in a single/multiple logical patches. >>>> >>>> In the end, documentation is added along with release note and >>>> MAINTAINERS update for documentation files. >>> I shall proceed with merging 01/33 to 03/33, if you can confirm making >>> 02/33 the first patch is fine. Or please do let me know if you have >>> any other suggestions. >>> >> I see that the 2/33 is adding the logging macros. I believe that can >> also be merged in the 03/33. > ./devtools/check-git-log.sh was giving me issues when one patch was > having edits in both drivers/common/cpt & drivers/crypto/octeontx. > That's the reason it was separated out. Many patches had to be divided > because of this. Oh,  my bad... I missed that this is a separate driver. I thought it was for the same driver. It would be fine to have 02/33 as your first patch as Thomas also suggested. >> Also I missed one comment on the documentation patch.. Please add your >> pmd doc entry in index.rst as well. > Will fix this in v3. > > Thanks, > Anoob