From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0062.outbound.protection.outlook.com [104.47.37.62]) by dpdk.org (Postfix) with ESMTP id 7D1EF38EB for ; Thu, 29 Sep 2016 16:21:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=mmelgnfDolHK0HtiU8hw+i2wMweF3QKZRErOKGDSX04=; b=MSzmWRk07gv+QIVQlfhjxLq+0XZu68vDTuc/J1Tbs7d6luRAzoyBV/FPcJqEoaZypB0ylPEp+fl70tfYu0YTyIF3Lm6/WBNMxfhINjmENCjxVpIlRcY1kB9VYdBlCvB8ElNYxHsynICy+7KNn8apWWysq9MOi5odzWeDrd6nfUw= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Maciej.Czekaj@cavium.com; Received: from [10.0.0.58] (31.172.191.173) by DM5PR07MB2891.namprd07.prod.outlook.com (10.168.102.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.639.5; Thu, 29 Sep 2016 14:21:34 +0000 From: Maciej Czekaj To: Ferruh Yigit , Kamil Rytarowski , References: <1472230448-17490-1-git-send-email-krytarowski@caviumnetworks.com> <1472230448-17490-2-git-send-email-krytarowski@caviumnetworks.com> <568fafa1-53f3-980b-9ca4-e086980651b2@intel.com> CC: , , , , Kamil Rytarowski Message-ID: <73022a0f-4c27-17b0-a9e3-187a869d2a8d@caviumnetworks.com> Date: Thu, 29 Sep 2016 16:21:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <568fafa1-53f3-980b-9ca4-e086980651b2@intel.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [31.172.191.173] X-ClientProxiedBy: AM3PR06CA039.eurprd06.prod.outlook.com (10.141.192.157) To DM5PR07MB2891.namprd07.prod.outlook.com (10.168.102.145) X-MS-Office365-Filtering-Correlation-Id: 8a3d7cfe-a6f1-48b3-141d-08d3e873eb8b X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB2891; 2:JDxvHV7x2la1XWP2ZS575ui+lXDZ+pLzMJhfBmmxr8Ju7Qv1z/3oRB85KOVfD8LwKLzwOvBmvqmrNvPHVGhR1mhqqOPceqP5CtZkRmUFT81HH7TvwiQ+cYyLi/rbO2YVflMxSFuf64oNIPOtQEV23FlNI2VykFCWCeVnvf8OpnUFlYTPbtVGYlvS4fte0Pqj; 3:9jmVNKjKfmkg0GSY+cnpF8RKvMYYiyjoLOipbMjtHzQlBtY33+3IVOg3Kpn/YbU5mev7VQy8QN+aXDFHFnSfCb7eLPUFQBwZeDdu7UG6v4GRwMRulyYeFw3E25Q9yHYz; 25:ybdNNvBs9e1vW/k5sxIbp+N+mB5+59qNmTGLSt3+tDuzJjCHV3QLApCDPlf93RMM3OF1wQ1kxwbMIJimHrbu1z5dW83w3NQrI8WkUsJktEGwu64WfhNiQP2UHCQ2s5jFQP2xvDaTFzq6YEOpa8GpcAkeDdLp2TTC7zbeLoOggf7t7bB+b4qCPQuEk0SzIXyu7h3AsLm3LLXj6xh1sP2Igc0rCwMdqOu+wZJGZGqNjXr1BZqiIX1beS1gCNkkGPcDS8ZcpX/5ODG1jhQYdXipAM0Osk8gr8+0Qp638Bl4ybrLxtUL1A6r00LEMRjsfpIIRD8fGHzRKLaweSqUqfiHbDvOvWMwH8ZnOSJ2qVK/ne4gKk1el08jtgyJ1LWEAmdvF5CtF/Uqp6rSbPIewfrjfyxhbL6z7brf4nLOQvgnuRY= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM5PR07MB2891; X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB2891; 31:HXEy+EAXxhZh6nI2Ao0LfWCM2MQi1lSbEg+cPjrzwmAuW6mRhnjiUy7EJAD8P8LDyxTHV4kLDx0sLSV1Lrmbzm7uyiY1bKvXKMDxZqXBx8LXY45xf2LmExDqcYHnSSFBIdy23xhdBfyqSwbzAWBwtKb8yeCbuHAs2lnjruM2o6xubzqcL0V2f8+YrRBH45sGwy/QKinSUv8099abX2WtrUgwZegc1+e3z7mj1lSy6mo=; 20:zUD7bjVwh8/77E9+yANyljq2XQXnVk21V7bRAIUBrIthcrAi1l5wLOHOGGT54M8fy1p4DfA9jTwUSWcTdZPD2USIt0aA6fkJnlvO19Sm0UejM1KD4itdg+ONM/Ac3UsDWRYomk66xqbM5TgP7uN/jBXa+iTxnGVM7aQgx/haSt9r5vVHHskWqfRsvfv77h82ZYTiG+9IccHMbP3tifEyfCB+dvJqmBf6V1bB6uMdlDHHP2MxKuHqLKnn+4/NERg3aUNVqjocKGI/6o2ldAGTN2/1z9FXFihJjkbAzW6sR1hYMbE02d9ekhtj3qOculnblMpaPOBWBV4F/RcQG7AxnKrAxjmxX39BcRvuGJ1JiOFMEdG5Chxvo1ZNk9b+K2ZY3Zv8oS5c2D28OsEjYJWyYOOMRXR+0PGevL1QLnCXfFdocYwyR2cUIzSdxyqx4+hBfjmrsA5eg19rIGCXAuY+a3/Y7vvun2oAddOb7kyYThRaQQgtjMG9vgGZG6WQTcFK7uLmEYakSk+YbMH6W4ciuQKIdiRdviIcjO2Jz+c+7bA71rrR25kH1rjHDQ/ym3WZT5jmSXAnXwLJuJ8wrkqXqHw6FVjTOv3Bn7NdtKyxvmU= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001); SRVR:DM5PR07MB2891; BCL:0; PCL:0; RULEID:; SRVR:DM5PR07MB2891; X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB2891; 4:fg7vZUL6lKT8sbxarlI6yB453Nkt7J/uR48CivX+qtnYaCUyp97brvlRwUYWsOzu+AhUSPZpLb4upVwna3QVskkI9dypjx1kGn3IUrtXCXjspE3YiFULoaGCmAB9IhSDP2XypYQmkNseuuHjAjoQS2j+v5tEnBd3e6R8pahuDsGRHXpYZs0GjkKKvSWP9rMq1YnsiLQ+cqSuj8EAqm1RCRzoW6ygmuENfYTkPKpnkRFCoF0meU+E31GJenN4Y6b/3fedS/V7GpdJBWVtgkkLEth34xc3KnL4+BWe2s5LlswAD/a81UNPqLjcKBtNYuY5FYzsZYdXuRQwTb8M30Io/xl7Xwe/jLanTU4u/6RBds5h/VZuzTL375JaVpdEXilOklI4/gfpxt5iXoQnpouPtw== X-Forefront-PRVS: 00808B16F3 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6049001)(6009001)(7916002)(189002)(199003)(24454002)(377454003)(101416001)(68736007)(83506001)(5660300001)(81166006)(81156014)(42186005)(105586002)(4001350100001)(7846002)(305945005)(31686004)(65826007)(97736004)(5001770100001)(6666003)(76176999)(106356001)(77096005)(189998001)(92566002)(4326007)(2906002)(47776003)(54356999)(3846002)(230700001)(6116002)(33646002)(50986999)(65956001)(64126003)(8676002)(19580405001)(23746002)(65806001)(36756003)(66066001)(42882006)(2950100002)(50466002)(31696002)(4001430100002)(7736002)(107886002)(19580395003)(586003); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR07MB2891; H:[10.0.0.58]; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; DM5PR07MB2891; 23:+ICbVjBwiy9JA5XvXCaRV5Q3ClHFj9o1N+yDd?= =?Windows-1252?Q?hp9XH9Uw20AwFk9nPSxvi4iIqhtsBG+1A5+4xH4k9RfpafwKlZQ4Y5mC?= =?Windows-1252?Q?BL797kA52Kxdmx81Gws/kliD4IU7qRlUnN2HQBEtCsKhMYx2oQJPio9D?= =?Windows-1252?Q?haFKaRZXvt7q7jgc73jGEefqp/peYGDOd4Zkfx9yG2WO63XVzLX4VoGI?= =?Windows-1252?Q?GqRl+AEeP2cJU4zwfTQfxoCfxk3iS/9xPOY4KpoEYnLk/PEe+7i+915c?= =?Windows-1252?Q?mg2TeGRG358681eyhLMWf22tsQtZ5ZY1DqUyDWjZOhcXS6fsxWvig+P7?= =?Windows-1252?Q?1LeAcKVkymxHEtkcXhsJzsC6mFIWCMjBxeZDhLfAubzYeas401giMoch?= =?Windows-1252?Q?F1tFY4uxPpWBRBzWcvAQp5DzBQXoa066j5tbkcZ4+iaqH86TwPVG/ouu?= =?Windows-1252?Q?ssvVpLOmZ5HFwtLgePrKsqDcIPnFN6WB4uApXWIVNehvpdniJqgzJtaM?= =?Windows-1252?Q?FEluA2QeZbeEj03SGv83beuuqSzFGW8jR1hjt0UxrMDt+SDaQPZcx9lF?= =?Windows-1252?Q?ObmJytgpbfgW9IYZyfO2YUbH5A75CZpoyxu+hry/8oju1lfsyqNj/7Xv?= =?Windows-1252?Q?sWqRG/e2T9kOtukFh7dh6aOav3D1AssYoBZtfdh9dYLLSFnjnwypwhhK?= =?Windows-1252?Q?iyqWsZFrAOr7FJCJ4mSdFO5AQoBjntZqqHjW1e1CCi61cUme8k0vc6VP?= =?Windows-1252?Q?9IDI2xJhPJZoWd+jfy0OBjoEg4Np7BfTNi0CGjDlHrjl6g+vhHJ9/ell?= =?Windows-1252?Q?Q3HR0n1upwEJfX74xH/JrKekEQr4+2eOBN2JIbAiEKuSp/aojJI7PO71?= =?Windows-1252?Q?QWMjCyCxuHfqmAvcWD8ISO04TRo7JiaXrwlBGtMG8vU16psjv5ts0e92?= =?Windows-1252?Q?4L6C2l2hb18BvBVwtRPdBFZqIz2T++X4Fr7owxYSwalp0hZxUfTXv755?= =?Windows-1252?Q?OfvEOSPXF8hZwuMXjBmA10lB8ZXbsAaL2Bx+cHWmA4Evbn1caejtPExg?= =?Windows-1252?Q?SKv/S/IcGtgJcGnWhV54yLS3RlIV8JbLP9YEDheKlyiv0Mktnl4UBlZJ?= =?Windows-1252?Q?ayjTkn85wPKWZlCzbZXM8RQjPGS1pHNTe531C7oPw4WjoimM7Zo4mEmB?= =?Windows-1252?Q?7pLy35lZ/mp+ZdCopZwMLAzYayTjO3Vrr/tylQBZ5MmFENNTQngE8A4f?= =?Windows-1252?Q?Fzk3yc8CUSG07zmbxq6/H7mWtnLZ3kHwDD3JSwnYhDTm4COLkrGjvBFT?= =?Windows-1252?Q?Mgyagq5Vx8oKe3+Rr8WXMl5QxFd8POWiDijc6bgbiaUvQWLXtYV2iAJp?= =?Windows-1252?Q?OmqnYeG87iOrQrbi3p5146JdClxU+S0McGNgfON/AfDqMIlovHNAlTdH?= =?Windows-1252?Q?wdVJ/6XQQPHiLytvR6vYzjMoa+FbD/ZJNiaWJgoYuinFyAq3viRgaMHY?= =?Windows-1252?Q?CqMbS8=3D?= X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB2891; 6:Chbho+STp+nlyKXxBUNaTtAF0Y1OLy90N8rt/SmXzU1RwtPQdKk9zIaxfbAX2QC50yNRlwe+/+VT7gUf8IhkZjS/94yt6jonwSElgrY6qk0YvInGfCwTjLmoUJutFLwmbDy+x0m3+N5VzodLMkrqQQvU4I+KvQskE5kM4N3WMJx9TN7TXk54sGT9R9/TiVA0elvS/2+8F8PH+GQAfTUIB/8s3HbxsxIIse7cNhGGEZEjoLVoqQYBUm7ZvPK7RS2+ol47HUUHx8LYRvTAcxJFumJY0MtM87LsCvVrHIElyjQ=; 5:5Q1Bmgb7bs4kMqsVAu9UJBDLSROV07GW3ThXp5bLVs7GD5PQhDocLYkE3EhwSUW6vNO7RvadsjtJzWMPbgo7PDpVVJ2Bx8/8876X8yljxtuQyL0Fmx1FmHqrtNnY/GAhajP3tW9YEXIupruXmxql6Q==; 24:MN3U866SaZY1mSRb+2fvBhL43yNgcM+16DyolxWnE2JN/FS4m8ZH2kICn4jgh/rULq/OG4kPIOGuJWAUZKK6P6KF/uLEjpuq4HMzydYOiCI=; 7:ytJQ0/8fPyC1EHGZSKJmjp4MyfgXnWhiT9dhVm7UXYh6Lt8V8jSn6BF82O/nFnQzp690g3e3TZb9ejoCy92EEr7jHsqPdhTjFxKdG49y/ccq6m4ObGxlEjY9j5BTqHfc0RBNRVSCxQT1dI9UTaOeokW8JDXMb9q/etmR6fUhDpKrFWRzYFxZNRAFKyYpPoLustlvFzzFz/urs0peL6YLT09suNijcTPIRFmpj1xxxbUTIUd2znXiJZWTWbyshVjjMxsWc+38R6mb/QRCYBpRqRbu+bPEcdi3xxjZwHNPMiJhjIwD5rjQ/aAc193znP6h SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2016 14:21:34.5533 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR07MB2891 Subject: Re: [dpdk-dev] [PATCH 01/13] net/thunderx: cleanup the driver before adding new features X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Sep 2016 14:21:38 -0000 > On 8/26/2016 5:53 PM, Kamil Rytarowski wrote: >> From: Kamil Rytarowski >> >> Refactored features: >> - enable nicvf_qset_rbdr_precharge to handle handle secondary queue sets > double "handle" Will fix comment in v2. > >> - rte_free already handles NULL pointer >> - check mempool flags to predict being contiguous in memory >> - allow to use mempool with multiple memory chunks > > I am not able to find the implementation for this. As commented below, it is not true so will remove that point in v2. > >> - simplify local construct of accessing nb_rx_queus > s/nb_rx_queus/nb_rx_queues Will fix comment in v2. > >> >> Signed-off-by: Maciej Czekaj >> Signed-off-by: Kamil Rytarowski >> Signed-off-by: Zyta Szpak >> Signed-off-by: Slawomir Rosek >> Signed-off-by: Radoslaw Biernacki >> Signed-off-by: Jerin Jacob >> --- >> drivers/net/thunderx/base/nicvf_hw.c | 10 +++++----- >> drivers/net/thunderx/base/nicvf_hw.h | 6 +++--- >> drivers/net/thunderx/nicvf_ethdev.c | 32 ++++++++++++-------------------- >> 3 files changed, 20 insertions(+), 28 deletions(-) >> >> diff --git a/drivers/net/thunderx/base/nicvf_hw.c b/drivers/net/thunderx/base/nicvf_hw.c >> index 4bdd183..1f08ef2 100644 >> --- a/drivers/net/thunderx/base/nicvf_hw.c >> +++ b/drivers/net/thunderx/base/nicvf_hw.c >> @@ -141,7 +141,7 @@ nicvf_base_init(struct nicvf *nic) >> return NICVF_ERR_BASE_INIT; >> >> if (nicvf_hw_version(nic) == PCI_SUB_DEVICE_ID_CN88XX_PASS2_NICVF) >> - nic->hwcap |= NICVF_CAP_TUNNEL_PARSING; >> + nic->hwcap |= NICVF_CAP_TUNNEL_PARSING | NICVF_CAP_CQE_RX2; > > is this new flag NICVF_CAP_CQE_RX2 flag described in commit log? > >> >> if (nicvf_hw_version(nic) == PCI_SUB_DEVICE_ID_CN81XX_NICVF) >> nic->hwcap |= NICVF_CAP_TUNNEL_PARSING | NICVF_CAP_CQE_RX2; >> @@ -497,9 +497,9 @@ nicvf_qsize_rbdr_roundup(uint32_t val) >> } >> >> int >> -nicvf_qset_rbdr_precharge(struct nicvf *nic, uint16_t ridx, >> - rbdr_pool_get_handler handler, >> - void *opaque, uint32_t max_buffs) >> +nicvf_qset_rbdr_precharge(void *dev, struct nicvf *nic, >> + uint16_t ridx, rbdr_pool_get_handler handler, >> + uint32_t max_buffs) >> { >> struct rbdr_entry_t *desc, *desc0; >> struct nicvf_rbdr *rbdr = nic->rbdr; >> @@ -514,7 +514,7 @@ nicvf_qset_rbdr_precharge(struct nicvf *nic, uint16_t ridx, >> if (count >= max_buffs) >> break; >> desc0 = desc + count; >> - phy = handler(opaque); >> + phy = handler(dev, nic); >> if (phy) { >> desc0->full_addr = phy; >> count++; >> diff --git a/drivers/net/thunderx/base/nicvf_hw.h b/drivers/net/thunderx/base/nicvf_hw.h >> index a6cda82..2b8738b 100644 >> --- a/drivers/net/thunderx/base/nicvf_hw.h >> +++ b/drivers/net/thunderx/base/nicvf_hw.h >> @@ -85,7 +85,7 @@ enum nicvf_err_e { >> NICVF_ERR_RSS_GET_SZ, /* -8171 */ >> }; >> >> -typedef nicvf_phys_addr_t (*rbdr_pool_get_handler)(void *opaque); >> +typedef nicvf_phys_addr_t (*rbdr_pool_get_handler)(void *dev, void *opaque); >> >> struct nicvf_hw_rx_qstats { >> uint64_t q_rx_bytes; >> @@ -194,8 +194,8 @@ int nicvf_qset_reclaim(struct nicvf *nic); >> >> int nicvf_qset_rbdr_config(struct nicvf *nic, uint16_t qidx); >> int nicvf_qset_rbdr_reclaim(struct nicvf *nic, uint16_t qidx); >> -int nicvf_qset_rbdr_precharge(struct nicvf *nic, uint16_t ridx, >> - rbdr_pool_get_handler handler, void *opaque, >> +int nicvf_qset_rbdr_precharge(void *dev, struct nicvf *nic, >> + uint16_t ridx, rbdr_pool_get_handler handler, >> uint32_t max_buffs); >> int nicvf_qset_rbdr_active(struct nicvf *nic, uint16_t qidx); >> >> diff --git a/drivers/net/thunderx/nicvf_ethdev.c b/drivers/net/thunderx/nicvf_ethdev.c >> index 4402f6a..48f2cd2 100644 >> --- a/drivers/net/thunderx/nicvf_ethdev.c >> +++ b/drivers/net/thunderx/nicvf_ethdev.c >> @@ -691,7 +691,7 @@ nicvf_configure_cpi(struct rte_eth_dev *dev) >> int ret; >> >> /* Count started rx queues */ >> - for (qidx = qcnt = 0; qidx < nic->eth_dev->data->nb_rx_queues; qidx++) >> + for (qidx = qcnt = 0; qidx < dev->data->nb_rx_queues; qidx++) >> if (dev->data->rx_queue_state[qidx] == >> RTE_ETH_QUEUE_STATE_STARTED) >> qcnt++; >> @@ -1023,12 +1023,9 @@ nicvf_stop_rx_queue(struct rte_eth_dev *dev, uint16_t qidx) >> static void >> nicvf_dev_rx_queue_release(void *rx_queue) >> { >> - struct nicvf_rxq *rxq = rx_queue; >> - >> PMD_INIT_FUNC_TRACE(); >> >> - if (rxq) >> - rte_free(rxq); >> + rte_free(rx_queue); >> } >> >> static int >> @@ -1087,9 +1084,9 @@ nicvf_dev_rx_queue_setup(struct rte_eth_dev *dev, uint16_t qidx, >> PMD_DRV_LOG(WARNING, "socket_id expected %d, configured %d", >> socket_id, nic->node); >> >> - /* Mempool memory should be contiguous */ >> - if (mp->nb_mem_chunks != 1) { >> - PMD_INIT_LOG(ERR, "Non contiguous mempool, check huge page sz"); >> + /* Mempool memory must be contiguous */ >> + if (mp->flags & MEMPOOL_F_NO_PHYS_CONTIG) { > > If you need continuous memory, this check is not enough. > Not having this flag doesn't guaranties that memory is continuous, this > flag can be set but still can have multiple mem_chunks. And there is no > guarantee that mem_chunks are continuous. True, we need both checks: mp->nb_mem_chunks == 1 && !MEMPOOL_F_NO_PHYS_CONTIG. Will fix in v2. > >> + PMD_INIT_LOG(ERR, "Mempool memory must be contiguous"); >> return -EINVAL; >> } >> >> @@ -1212,15 +1209,16 @@ nicvf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) >> } >> >> static nicvf_phys_addr_t >> -rbdr_rte_mempool_get(void *opaque) >> +rbdr_rte_mempool_get(void *dev, void *opaque) >> { >> uint16_t qidx; >> uintptr_t mbuf; >> struct nicvf_rxq *rxq; >> - struct nicvf *nic = nicvf_pmd_priv((struct rte_eth_dev *)opaque); >> + struct rte_eth_dev *eth_dev = (struct rte_eth_dev *)dev; >> + struct nicvf *nic __rte_unused = (struct nicvf *)opaque; >> >> - for (qidx = 0; qidx < nic->eth_dev->data->nb_rx_queues; qidx++) { >> - rxq = nic->eth_dev->data->rx_queues[qidx]; >> + for (qidx = 0; qidx < eth_dev->data->nb_rx_queues; qidx++) { >> + rxq = eth_dev->data->rx_queues[qidx]; >> /* Maintain equal buffer count across all pools */ >> if (rxq->precharge_cnt >= rxq->qlen_mask) >> continue; >> @@ -1354,8 +1352,8 @@ nicvf_dev_start(struct rte_eth_dev *dev) >> } >> >> /* Fill rte_mempool buffers in RBDR pool and precharge it */ >> - ret = nicvf_qset_rbdr_precharge(nic, 0, rbdr_rte_mempool_get, >> - dev, total_rxq_desc); >> + ret = nicvf_qset_rbdr_precharge(dev, nic, 0, rbdr_rte_mempool_get, >> + total_rxq_desc); >> if (ret) { >> PMD_INIT_LOG(ERR, "Failed to fill rbdr %d", ret); >> goto qset_rbdr_reclaim; >> @@ -1721,12 +1719,6 @@ nicvf_eth_dev_init(struct rte_eth_dev *eth_dev) >> goto malloc_fail; >> } >> >> - ret = nicvf_mbox_get_rss_size(nic); >> - if (ret) { >> - PMD_INIT_LOG(ERR, "Failed to get rss table size"); >> - goto malloc_fail; >> - } >> - > > Is removing mbox_get_rss_size() mentioned in commit log? This chage remove spare function call but is not mentioned. Will add a comment in v2. >> PMD_INIT_LOG(INFO, "Port %d (%x:%x) mac=%02x:%02x:%02x:%02x:%02x:%02x", >> eth_dev->data->port_id, nic->vendor_id, nic->device_id, >> nic->mac_addr[0], nic->mac_addr[1], nic->mac_addr[2], >> > > >