From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F03E6A0543; Wed, 12 Oct 2022 18:19:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CA3A740156; Wed, 12 Oct 2022 18:19:57 +0200 (CEST) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by mails.dpdk.org (Postfix) with ESMTP id 2431540041 for ; Wed, 12 Oct 2022 18:19:56 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id B0F423200944; Wed, 12 Oct 2022 12:19:54 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 12 Oct 2022 12:19:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1665591594; x= 1665677994; bh=StohBNh+0ac+gYpltr0v/WOskMw++EqWM17vSb4LF3I=; b=l ygFgOk+V0bVb4cDBrFiQJlC/e9rVHGvD0CIq8ozKXF/DIWQyPpH8JEnk+mTMZc+c i6Hoq3HCMYZyErXcxqWsGeys6dWq1GsnzpfJKs5nCQS1pFMAN13V1AReu7xbJGZl uM7o5TT2FEzCBiFBmPeSS7Fr2rWNkO4JAvqF9h2X2S+bVpWLQgx5Mqm84Zzh2EzT +8N5OjFJ5QtNfBTP9jb7Y6NPLBo4/g5k9pejBtOxHgUmSz04ZDtd+BZHPt7cfPtp oxtOoXeSqpw/3uhx3o092MXi89RvS005qqxkXoeVnuh+lcTM2CUgPgwsTEGe9bEJ pjUpbp47Hy3xRb8Wpb6zA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1665591594; x= 1665677994; bh=StohBNh+0ac+gYpltr0v/WOskMw++EqWM17vSb4LF3I=; b=b OtS0Dr2vimQxw0otzTqhQdFEe3p7Lkcm4TP0gpOEOjxv7hL+wKOhenTGSMRzC5UY cRIQ+Z4hbUohsWSnX/ZX1Wi6sQHvY5P0d//qKeBQ3R/jK74mgrAvMBVIDWAqjjYJ 4RS+utfjEY22ZXFKGgqu+T3Qvp8BUZ+7V/eN8ba1+JC8JdTomhoonJcvoI4U2qI+ G03aF++2lzohrCBZ7Fh4Upr4mvuRV8uVrTEWFZAHsR7412H+EBM8ORqX93jUVNTi Ll6E0Be77d8UuphPSym7fv4hrilQ2uKQYhzazxwiwp72cvgz1C6EUmwdVC4I2iSo naaeS6GxBKCxd9Q9V+abw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeejkedguddttdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddt ieekgfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 12 Oct 2022 12:19:53 -0400 (EDT) From: Thomas Monjalon To: Ankur Dwivedi Cc: "dev@dpdk.org" , Akhil Goyal , "royzhang1980@gmail.com" , Amit Prakash Shukla , Jerin Jacob Kollanukkaran , "david.marchand@redhat.com" Subject: Re: [EXT] Re: [PATCH v2] devtools: add tracepoint check in checkpatch Date: Wed, 12 Oct 2022 18:19:52 +0200 Message-ID: <7317480.ejJDZkT8p0@thomas> In-Reply-To: References: <20221012092337.5988-1-adwivedi@marvell.com> <6793875.kQq0lBPeGt@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 12/10/2022 17:16, Ankur Dwivedi: > > >-----Original Message----- > >From: Thomas Monjalon > >Sent: Wednesday, October 12, 2022 6:39 PM > >To: Ankur Dwivedi > >Cc: dev@dpdk.org; Akhil Goyal ; > >royzhang1980@gmail.com; Amit Prakash Shukla ; > >Jerin Jacob Kollanukkaran ; Ankur Dwivedi > >; david.marchand@redhat.com > >Subject: [EXT] Re: [PATCH v2] devtools: add tracepoint check in checkpatch > > > >External Email > > > >---------------------------------------------------------------------- > >12/10/2022 13:45, Ankur Dwivedi: > >> devtools/check-symbol-change.sh | 76 +------------------------------- > >> devtools/check-tracepoint.py | 52 ++++++++++++++++++++++ > >> devtools/check-tracepoint.sh | 66 ++++++++++++++++++++++++++++ > >> devtools/checkpatches.sh | 9 ++++ > >> devtools/common-func.sh | 77 +++++++++++++++++++++++++++++++++ > >> devtools/trace-skiplist.txt | 0 > > > >Before diving into this proposal, > >I would like a split of the patch for the rework (and move) of check-symbol- > >change.sh alone. > Will split the patch in next version. > > > >In general I see too many files added: > > check-tracepoint.py and check-tracepoint.sh common-func.sh is > >probably a bad name. > Regarding common-func.sh name, I am thinking of renaming it to common.sh or helper.sh, considering there may be more common shell routines in future. Otherwise it can be renamed to build-map.sh considering it will contain only build_map_changes() function. > Please suggest a suitable name if my suggested names are bad. > > Will try to combine check-tracepoint.py and check-tracepoint.sh. There are many very different scripts in devtools. Having a very common script won't work well. Please keep scripts specialized. If you need a script to check symbol, it should include "symbol" in its name.