* [dpdk-dev] [PATCH] app/testpmd: fix runtime dead code @ 2017-09-29 12:56 Michal Jastrzebski 2017-09-29 14:25 ` Wu, Jingjing 2017-10-12 19:28 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit 0 siblings, 2 replies; 4+ messages in thread From: Michal Jastrzebski @ 2017-09-29 12:56 UTC (permalink / raw) To: jingjing.wu; +Cc: dev, deepak.k.jain, Tomasz Kulasek, andrey.chilikin, stable From: Tomasz Kulasek <tomaszx.kulasek@intel.com> Coverity reports DEADCODE, as assumes that RTE_LIBRTE_I40E_PMD is defined and function compiles entirely. The fix is about to place printf function into #else branch of conditional compilation, since it is known at compile time if i40e is supported. No need to check it at runtime. Coverity issue: 158646 Fixes: 37a56cce7b8e ("app/testpmd: enable DDP get info feature") Cc: andrey.chilikin@intel.com Cc: stable@dpdk.org Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com> --- app/test-pmd/cmdline.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index ccdf239..c604dac 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -13414,8 +13414,8 @@ struct cmd_ddp_info_result { struct cmd_ddp_info_result *res = parsed_result; uint8_t *pkg; uint32_t pkg_size; - int ret = -ENOTSUP; #ifdef RTE_LIBRTE_I40E_PMD + int ret; uint32_t i; uint8_t *buff; uint32_t buff_size; @@ -13495,10 +13495,9 @@ struct cmd_ddp_info_result { free(devs); } } - ret = 0; +#else + printf("Function not supported in PMD driver\n"); #endif - if (ret == -ENOTSUP) - printf("Function not supported in PMD driver\n"); close_ddp_package_file(pkg); } -- 1.9.1 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] app/testpmd: fix runtime dead code 2017-09-29 12:56 [dpdk-dev] [PATCH] app/testpmd: fix runtime dead code Michal Jastrzebski @ 2017-09-29 14:25 ` Wu, Jingjing 2017-10-12 19:28 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit 1 sibling, 0 replies; 4+ messages in thread From: Wu, Jingjing @ 2017-09-29 14:25 UTC (permalink / raw) To: Jastrzebski, MichalX K Cc: dev, Jain, Deepak K, Kulasek, TomaszX, Chilikin, Andrey, stable > -----Original Message----- > From: Jastrzebski, MichalX K > Sent: Friday, September 29, 2017 8:57 PM > To: Wu, Jingjing <jingjing.wu@intel.com> > Cc: dev@dpdk.org; Jain, Deepak K <deepak.k.jain@intel.com>; Kulasek, TomaszX > <tomaszx.kulasek@intel.com>; Chilikin, Andrey <andrey.chilikin@intel.com>; > stable@dpdk.org > Subject: [PATCH] app/testpmd: fix runtime dead code > > From: Tomasz Kulasek <tomaszx.kulasek@intel.com> > > Coverity reports DEADCODE, as assumes that RTE_LIBRTE_I40E_PMD > is defined and function compiles entirely. > The fix is about to place printf function into #else branch > of conditional compilation, since it is known at compile > time if i40e is supported. No need to check it at runtime. > > Coverity issue: 158646 > Fixes: 37a56cce7b8e ("app/testpmd: enable DDP get info feature") > Cc: andrey.chilikin@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com> Acked-by: Jingjing Wu <jingjing.wu@intel.com> ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix runtime dead code 2017-09-29 12:56 [dpdk-dev] [PATCH] app/testpmd: fix runtime dead code Michal Jastrzebski 2017-09-29 14:25 ` Wu, Jingjing @ 2017-10-12 19:28 ` Ferruh Yigit 2017-10-13 1:36 ` Wu, Jingjing 1 sibling, 1 reply; 4+ messages in thread From: Ferruh Yigit @ 2017-10-12 19:28 UTC (permalink / raw) To: Michal Jastrzebski, jingjing.wu Cc: dev, deepak.k.jain, Tomasz Kulasek, andrey.chilikin, stable On 9/29/2017 1:56 PM, Michal Jastrzebski wrote: > From: Tomasz Kulasek <tomaszx.kulasek@intel.com> > > Coverity reports DEADCODE, as assumes that RTE_LIBRTE_I40E_PMD > is defined and function compiles entirely. > The fix is about to place printf function into #else branch > of conditional compilation, since it is known at compile > time if i40e is supported. No need to check it at runtime. This is to highlight this is not supported other than defined PMD, and used like this in similar functions, I am for keeping this and marking coverity item as false positive. Hi Jingjing, What do you think, if you have strong opinion to get this, I will. Thanks, ferruh > > Coverity issue: 158646 > Fixes: 37a56cce7b8e ("app/testpmd: enable DDP get info feature") > Cc: andrey.chilikin@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com> > --- > app/test-pmd/cmdline.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > index ccdf239..c604dac 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -13414,8 +13414,8 @@ struct cmd_ddp_info_result { > struct cmd_ddp_info_result *res = parsed_result; > uint8_t *pkg; > uint32_t pkg_size; > - int ret = -ENOTSUP; > #ifdef RTE_LIBRTE_I40E_PMD > + int ret; > uint32_t i; > uint8_t *buff; > uint32_t buff_size; > @@ -13495,10 +13495,9 @@ struct cmd_ddp_info_result { > free(devs); > } > } > - ret = 0; > +#else > + printf("Function not supported in PMD driver\n"); > #endif > - if (ret == -ENOTSUP) > - printf("Function not supported in PMD driver\n"); > close_ddp_package_file(pkg); > } > > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix runtime dead code 2017-10-12 19:28 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit @ 2017-10-13 1:36 ` Wu, Jingjing 0 siblings, 0 replies; 4+ messages in thread From: Wu, Jingjing @ 2017-10-13 1:36 UTC (permalink / raw) To: Yigit, Ferruh, Jastrzebski, MichalX K Cc: dev, Jain, Deepak K, Kulasek, TomaszX, Chilikin, Andrey, stable > -----Original Message----- > From: Yigit, Ferruh > Sent: Friday, October 13, 2017 3:28 AM > To: Jastrzebski, MichalX K <michalx.k.jastrzebski@intel.com>; Wu, Jingjing > <jingjing.wu@intel.com> > Cc: dev@dpdk.org; Jain, Deepak K <deepak.k.jain@intel.com>; Kulasek, > TomaszX <tomaszx.kulasek@intel.com>; Chilikin, Andrey > <andrey.chilikin@intel.com>; stable@dpdk.org > Subject: Re: [dpdk-stable] [PATCH] app/testpmd: fix runtime dead code > > On 9/29/2017 1:56 PM, Michal Jastrzebski wrote: > > From: Tomasz Kulasek <tomaszx.kulasek@intel.com> > > > > Coverity reports DEADCODE, as assumes that RTE_LIBRTE_I40E_PMD is > > defined and function compiles entirely. > > The fix is about to place printf function into #else branch of > > conditional compilation, since it is known at compile time if i40e is > > supported. No need to check it at runtime. > > This is to highlight this is not supported other than defined PMD, and used like > this in similar functions, I am for keeping this and marking coverity item as > false positive. > > Hi Jingjing, > > What do you think, if you have strong opinion to get this, I will. > > Thanks, > ferruh > > > Hi, Ferruh Checked other funcs called PMD specific API. And it seems all of them handle That in the same way. So, to keep consistent, we may not need to apply this patch. I agree with you to mark coverity item to no problem. Thanks Jingjing ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-10-13 1:36 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-09-29 12:56 [dpdk-dev] [PATCH] app/testpmd: fix runtime dead code Michal Jastrzebski 2017-09-29 14:25 ` Wu, Jingjing 2017-10-12 19:28 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit 2017-10-13 1:36 ` Wu, Jingjing
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).