From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id A362A1B950 for ; Fri, 11 Jan 2019 08:56:24 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us3.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id C19A448005F; Fri, 11 Jan 2019 07:56:22 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 11 Jan 2019 07:56:15 +0000 To: Stephen Hemminger , Rami Rosen CC: Thomas Monjalon , =?UTF-8?Q?Morten_Br=c3=b8rup?= , , , References: <98CBD80474FA8B44BF855DF32C47DC35B425B1@smartserver.smartshare.dk> <98CBD80474FA8B44BF855DF32C47DC35B425B8@smartserver.smartshare.dk> <3446539.r5cUhzCBca@xps> <20190110161158.0177a203@hermes.lan> From: Andrew Rybchenko Message-ID: <73285400-c67b-48cf-88be-b20bb05b5484@solarflare.com> Date: Fri, 11 Jan 2019 10:56:11 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190110161158.0177a203@hermes.lan> Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24352.003 X-TM-AS-Result: No-6.435300-8.000000-10 X-TMASE-MatchedRID: oTBA/+sdKaYOwH4pD14DsPHkpkyUphL9NNBFtVEGTH31yFIyxT4nyx1+ 1w+IaNZTUsWlqTR/AknpOB+xwXzcRDI0UzRdrW2osaPcs3T4TL2BHKTJ+sfXGQUbMEI5YEIz807 t+VEWpeYgZIcq73TEpZJTzjwz+Gzox7hajJv6RUXIOn6NK8S1ayXdp9l6EkRZ52VTYrkmb1uCAE CxRbm5ZM4ffyU1s6hMXEjZllf2bhffX2sZfyOJoZ4CIKY/Hg3AtOt1ofVlaoJlgn288nW9IHzRz XQdd7Y5joczmuoPCq3hTcXtMjA8FlyA0w4U48Iyr4MXnwQMJ2XolBwouikBFfcbGAY8hMk80bJs GNhqE4H2dQjzIILUTqY4DPFLPd3JFSuA/erTRoQfwV6sBPR0lg== X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--6.435300-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24352.003 X-MDID: 1547193384-pPBeM2E8WdJJ Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [RFC] function to parse packet headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jan 2019 07:56:25 -0000 On 1/11/19 3:11 AM, Stephen Hemminger wrote: > On Thu, 10 Jan 2019 03:03:24 +0200 > Rami Rosen wrote: > >> Hi, Morten, >> >>> And regarding avoiding code duplicity, I'm pursuing Olivier about merging >> packet header validation into rte_net_get_ptype() instead of writing a >> separate function. >>> >> This seems also a good alternative. >> +1 >> >> Regards, >> Rami Rosen >> > +1 > All drivers that don't have hardware support for getting l2/l3 and ptype > information should be calling rte_net_get_ptype() already. Is it documented somewhere?