From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 985F3A00C3; Tue, 1 Feb 2022 12:13:35 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 167C940698; Tue, 1 Feb 2022 12:13:35 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 9C1F440691 for <dev@dpdk.org>; Tue, 1 Feb 2022 12:13:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643714013; x=1675250013; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=FoitznpIDOlGblMaG55tcfuImN4mRvYYsZJBywJmD7Q=; b=mi/9Z48uampJ/gYbkEyXz4h9GC0zCDB92Op5XaWRYfuBMZAzbYVzOvYn r3OC+VENi8LuINo053IWnuWfcJknrzg+oZp9VwItXmIm7leXWc6XHk6Jm kHV3sA+9k1uqI7nHPns8IsEfX2OPrZQ5ZQsu7Lk1pSr4c5UX181UmMvgj 64fVOawmoFLG6lVK41Sj8ThphJxOGzlztgoq6DRhb3KPVGapH+ql0vSM5 HIjh97VRqQiNt9dhjoUNEQcdp8SIJ3aOT4JAasIzyWnwKcavICEemV59E Kr/2Mq4/jHyk99b9dglCO24ooqGQR3Zwp4HyTua6yY6K4YxvalJwUc25W A==; X-IronPort-AV: E=McAfee;i="6200,9189,10244"; a="308400775" X-IronPort-AV: E=Sophos;i="5.88,333,1635231600"; d="scan'208";a="308400775" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2022 03:13:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,333,1635231600"; d="scan'208";a="565560701" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga001.jf.intel.com with ESMTP; 01 Feb 2022 03:13:32 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 1 Feb 2022 03:13:32 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 1 Feb 2022 03:13:31 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 1 Feb 2022 03:13:31 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 1 Feb 2022 03:13:31 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YJSmkuDExATIcJeGk2JkB6ZRuDs05QRtZY4JrjV4geDqIWpLsk6evj1o7qaI0bww+LctMv5zuck/Oi4ikGZFX1Dgrp9C9Yi2r7OldIfUS/dCmjDSqDxgvHA+95WLMZKf5fgktEnbdbiNiGdhE22Ww4y2JplY8bkuMQq4Y5yKFddWFDo0QBEDH60/6mBmUyWx0AJ4GSq3IkLIowVMz1Yr46L7lyrWeLChBfUZfE3l94l0bt/xid8JgfhH8vY8Bwrchpr215xMbDAHmIzyQl2U0Zto4GwmGsyA0JePzf6IfNCgLmJ4obxzqoU8p7sMDleAJVqaq3ScTBg9nd7SQdaV1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0unkjXpGfwqoYCcvPw70Rec7KvnewyebQF/iqDS2v1w=; b=HyabIzIG6JFEi+xZLR5RVYkM4gpmYlqiRVqx7bqb8tietiheVa5knnPRoaunIGkHuNaqABVAczrLXI3a5sLmZr36rvNLxXQ7e80Iw0zoEzSS/zaq3usjEIDWn1n9qCXZ6D8ha62OUj6ywiRKa9tT3paUACwqIx8D6o2zd0xvKSp/5dQW3h9/klTdkXyIK6uZalQI/E8vEsvPVoKxLAU6r6w3Jna81TCMtE1qDDuQk64FTp97qOWM4wZPmZNcYIhbm5077nFCrwgtTImkOCS82y8ICnq6hqag10YlEoY2I1znwzZaqN8uCZMk6FzdAvEkMYk4VMYU3q0jf/sxMzq1aQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4888.namprd11.prod.outlook.com (2603:10b6:510:32::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.17; Tue, 1 Feb 2022 11:13:30 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e%7]) with mapi id 15.20.4930.022; Tue, 1 Feb 2022 11:13:30 +0000 Message-ID: <732be32d-cd20-234e-7906-bd6770c30215@intel.com> Date: Tue, 1 Feb 2022 11:13:24 +0000 Content-Language: en-US To: Sean Zhang <xiazhang@nvidia.com>, <thomas@monjalon.net>, Ori Kam <orika@nvidia.com> CC: <dev@dpdk.org> References: <20211230030817.15264-2-xiazhang@nvidia.com> <20220126084404.40178-1-xiazhang@nvidia.com> From: Ferruh Yigit <ferruh.yigit@intel.com> Subject: Re: [v1 0/4] Add support for GRE optional fields matching X-User: ferruhy In-Reply-To: <20220126084404.40178-1-xiazhang@nvidia.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0030.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ae::15) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 71f5ce7b-ee8c-46e9-f6e5-08d9e573e069 X-MS-TrafficTypeDiagnostic: PH0PR11MB4888:EE_ X-Microsoft-Antispam-PRVS: <PH0PR11MB4888020E2112BF00F0A5B6E095269@PH0PR11MB4888.namprd11.prod.outlook.com> X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fYYQTVtiIeuqtxHmv2HrANgOuvxAH4HrKKA3EJP40s/RALIK/GHHPrgPWtyLQk7tkwmjcnslu76PjpfiTjYG//v8elD5p5cffTrVJU9zxzWaiFe3t/Upwor/7IC5lT/4kEdo/DGSvmGIotAMVOxxOK4Kx2bVr/Gc8d4ewfms4lSibacCpcRhtRhb8Hr7BBVqiJXhKtBW//HBCHtrpJakjJmeAxJaw2R9sRTP8aZ/jMWm6e+Id7y7+ELtn+ZLc2J8CRWuyFXhDsPSaS1O6aO1pgoGIwYQZoMh7cFrmM7fQNOdzd3gamVLlNMNEX/Zt3SDyju76NWwkiS5auQ24gVwSQGtXEs26C0VtE1epBk20hfYn/tc4gpiJAaSB2v4TPulbUzQfbnntPHrsl0k5681VJ3nbn6r7PmOjg9ZLdVlsMfFDAsudpaBR/hSPmRexdsDNjmEaam7BaoC9Mo4723b38lHp47BPNLggzIhOigfCBbx2Cbu3RMtUH7/bao+pOkLFQPbpgqiqHvNJZZwUEpPWCYu4iAekkOKItMtG6xt6ZzqfQ19oNeGhh4m0US5Vl9D8WmgdV5k2cIMfC0Ba1LDU8zRhgjAZp7HXZ5iFnJlDQ0OjLKVe+r2554lkVhdYnEPrrWgwJqThhGUXi4tzGyLMmB/ZQ4/1KfrmwRXakdf9yyapePngsxJ8Z2F9MNjRlIrqsee2KbLJbTZfdl3yfAarQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(31696002)(6506007)(6666004)(53546011)(2616005)(26005)(186003)(55236004)(6486002)(508600001)(86362001)(6512007)(38100700002)(82960400001)(66946007)(31686004)(66476007)(8676002)(5660300002)(66556008)(44832011)(36756003)(2906002)(110136005)(8936002)(4326008)(316002)(45980500001)(20210929001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZVlJRHVSU2xEOGxzeVFXSU1zZVg0NkxZejZGU3FaaGxDamswTE1RMWt6TU8v?= =?utf-8?B?ZFprWFFzWDZ3UEgwczN0TnZvMzFvM3g3Wk1CRForZ3NESjE4czk5VmtTd0lq?= =?utf-8?B?Yk1UOW9Mc0IvT25ZaE9WZVdsZWlzQzJXYndrRjlrc0xaaDhxcFJKbm1ReWpU?= =?utf-8?B?d2VKT3grK2Q4SjQ2cndncmpOYkxOK1Z2cW5DZ0dyU2FRSlBUV295Sm1pb3N4?= =?utf-8?B?cExmR1ZoTDFGM2xHSUdoRzdsVG1MaHR1elJjdUV5cEw4aE1pMFNvT0tObTBZ?= =?utf-8?B?aWRyY0cxQWRQK1BZNkQrYzE3NkM2UzVNTzlaaER0OHh1NEdYOXltb0pQdmlj?= =?utf-8?B?OExwSGdDaVQ5cFY3Vm5nMXhaUmlNVXN4eENIMXVUbDdmdk1BZCtZekhuUzZx?= =?utf-8?B?Z1kyVmNFSk9NQURGbThMcGVHMnZvVHhDa29aVGUwN3pielF0WU1DZ2RHTFRn?= =?utf-8?B?ZFdFZnRZU3ZlNlhlRWtyUW5SUk5sMDFnVitLLzliaDd4M0Z2SmRzTFNmUzB2?= =?utf-8?B?TmdWVDc1dGJUR3FSS3BPV1F6TmFsL2Q0L3VMaXIzd0szUG1QNmYwSnpTWWVz?= =?utf-8?B?VFZqTEV0Q2UwcEVCRXRUTnhxQ1ZKdkpQRWZHWmJiTmRjNXdFRUNVbnJ4dUhL?= =?utf-8?B?YlVjcFplWkYzd0pSckNOR3RQdjNZQXRURlFNdEp5NEc3KzMyV0hQeC9PUmFi?= =?utf-8?B?WXNYeVVtdVI0SlkyTXRpenBFcExXRTVFZFVydnhZOVUwZWUzdTZGNk5NVkg3?= =?utf-8?B?TFJndU9oZ0pIMDRIS2NEVUJoWm9PdDlaWEx4RXFVVFl3T1pYMGx0bWlueG5p?= =?utf-8?B?aTJpWWtudEJHQUdqUmNhbEkxamxoWVhxb0lNM3EwSGdta1UwS0FPNU1zUlY3?= =?utf-8?B?NWNtd0dtb0hTa1dRSXRsTVdIN1k1OUIvYUlDdkZBOFl3bG5GMTlXOGJVdTY0?= =?utf-8?B?dzNicUZ1NlU5TmVFOGJFUDNZUFlwZkY0dHZaSjBETjZhRm1wbnB0ektFQ1dI?= =?utf-8?B?VjFHUDNjWXhhNnRuK2Vnb2pHb1lRWGJMeDJZOXh5UlRoOTRWTXBXWFVjMms5?= =?utf-8?B?ZGZJeDVMYmxSQ2R0c2xTWWQ5Vm9pNHhwQWJaNUU1REhaZitPRmJ6clZSSkgy?= =?utf-8?B?WGg2TVg3a2xKL2F3V1ZRczBDMVNib1RzYytzbUVnTXhVMnhORkRGMFNMNkoy?= =?utf-8?B?NDNYYjNZNGF4SE82eFZkS3NXNVVyOGVtME0rUnpCRHkzWXBic3hwa3NUR2xW?= =?utf-8?B?Q0wzMVF6NkN3SU5QQUhZL1Zxd2xieHY3VWpLWlhQNWx5NitOdWJFeDJUZHo0?= =?utf-8?B?SW5rNUNybm52SmVXME4yNUk1aWEzSlhackQwMVJKT0tXWkZlKzZZekJXTUVt?= =?utf-8?B?SEhsNzdUOGRzUzZwekNVTVE2T2tVcnByaUFwSFFqNXRpWTZHWTU2K1laNjdu?= =?utf-8?B?TFNBbHhuUERmamxxUTIvU1E4cWtxeXpUdmhlUEZReUJBYmx4RGp5T004eXdt?= =?utf-8?B?RStHUnJlbElGVTVYOURjZ3ZWQVI1dHdDYVFqaXVCcE5RUzBzSDNrM2JudlZ0?= =?utf-8?B?NGFRellTL1o3UUk2VDRISFNoYS9jcDh5MzMyenc1Q1QyUXFmVEpEV3V4eURi?= =?utf-8?B?WXVmUmFtbnFObTlFVlFvSzFkODdKKzd2a1FWZEpZWmVIMW8wYUw0L2xtcHlR?= =?utf-8?B?NmNoVGk2cnUzMWNJaWhMMTBldGlSZWthRDVQWEs1M05oU1dHTlczU1YreUJ5?= =?utf-8?B?VUwzbzVWRUZUYzVEc0JxekxLWk43cWZmcVh2Z3c0Uk45NG8vSVJaNUJWdHZv?= =?utf-8?B?bUFHREpXUzdWbURPTGhjMXhtNmlRaEIraUJUMjBkcFU3WkRmcE0zbysvV3lQ?= =?utf-8?B?WVAwN0FPVDlEbTlKc0NaMHc1UnhQclNEWml1MCtwUjNkRndzSnRUYWtUSTEx?= =?utf-8?B?c2JRYlFvWElxMlBxc1M3WXZwdWgvdlY2ZUdSQVlBa1NvWUNvektqTCsyMm8x?= =?utf-8?B?RmdUanhyM05Sa09LV2VqYVA5V2pGVkV6K1ZsY1VYdzRCc05IY1EwVnNjVDVi?= =?utf-8?B?bHN3RkFMYmN3MnlwM1pzZ2Y4dWlvNzR4aUJBQWxqb0NqUVZSUDFTRzdoNGtM?= =?utf-8?B?R3pETjZzYVhwZ2ZkaXF3TVVrQ3YvMFZ5SFJ5Q3JQOXJZbUJPemJDdHNXOHNX?= =?utf-8?Q?9e3YM4xl+UJFkvsZMv1d2BA=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 71f5ce7b-ee8c-46e9-f6e5-08d9e573e069 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2022 11:13:30.1332 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Bxae5VrBm4IW9uqWZFfFEZAh1yF7Rkg5fNldkofKFuC83QH3JI94JUVaZIusbNN9PbJyLa4m5j4DQH5ZrSpmTQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4888 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On 1/26/2022 8:44 AM, Sean Zhang wrote: > This patch set adds support for matching optional fields of GRE header. > The optional fields are checksum, key and sequence number. Currently, key > field is supported with pattern gre_key item '.. / gre / gre_key value is > xx / ..' with field gre_key in misc, but misc does not support matching of > checksum and sequence number of GRE. > To support matching of checksum and sequence number fields in GRE, > rdma-core needs the capbility of misc5 and support tunnel_header 0-3. Since > tunnel_header1 is used to match checksum, tunnel_header2 for key and > tunnel_header3 for sequence by hardware. If checksum and sequence number > not present in the pattern, use misc as before for the matching. > Application can still use gre_key item 'gre_key value is xx' for key > matching, the effect is the same if use 'gre_option key is xx'. > If using gre_option item, the flags in gre item should be correspondingly > set. For example, if using gre_option to match checksum, the c_bit should > be set '1' (.. / gre c_bit is 1 / gre_option checksum is xx / ..). > > Sean Zhang (4): > lib: add optional fields in GRE header > ethdev: support GRE optional fields > app/testpmd: add gre_option item command > net/mlx5: support matching optional fields of GRE > Look good to me (except that missing doc in mlx5 patch), but waiting for Ori's review to proceed.