From: "Etelson, Gregory" <getelson@nvidia.com>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>
Cc: "Morten Brørup" <mb@smartsharesystems.com>,
dev@dpdk.org, mkashani@nvidia.com, bruce.richardson@intel.com,
jasvinder.singh@intel.com, konstantin.v.ananyev@yandex.ru,
ruifeng.wang@arm.com, andrew.rybchenko@oktetlabs.ru,
cristian.dumitrescu@intel.com, ferruh.yigit@amd.com,
orika@nvidia.com, thomas@monjalon.net
Subject: Re: [PATCH] net: add bit fields to IPv6 header definition
Date: Wed, 19 Jun 2024 07:31:32 +0300 (IDT) [thread overview]
Message-ID: <732cb515-94e8-934e-d35f-455d33dc11cf@nvidia.com> (raw)
In-Reply-To: <20240619001104.GA13189@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
Hello,
>> The mbuf structure [1] has __extension__ here,
>> i.e. preceding the structure following the integer field,
>> instead of preceding the union.
>>
>> [1]: https://git.dpdk.org/dpdk/tree/lib/mbuf/rte_mbuf_core.h#n520
>
> +1 anonymous unions are standard C so __extension__ is not necessary, it
> is necessary for an anonymous struct.
>
That was fixed in the v4:
https://mails.dpdk.org/archives/dev/2024-June/295803.html
Regards,
Gregory
next prev parent reply other threads:[~2024-06-19 4:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 5:17 Gregory Etelson
2024-06-18 6:42 ` Morten Brørup
2024-06-18 7:02 ` Morten Brørup
2024-06-18 8:07 ` Etelson, Gregory
2024-06-19 0:11 ` Tyler Retzlaff
2024-06-19 4:31 ` Etelson, Gregory [this message]
2024-06-18 7:58 ` [PATCH v2] " Gregory Etelson
2024-06-18 8:11 ` Morten Brørup
2024-06-18 9:51 ` [PATCH v3] " Gregory Etelson
2024-06-18 10:47 ` Morten Brørup
2024-06-18 12:18 ` [PATCH v4] " Gregory Etelson
2024-06-18 12:44 ` Morten Brørup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=732cb515-94e8-934e-d35f-455d33dc11cf@nvidia.com \
--to=getelson@nvidia.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=bruce.richardson@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=jasvinder.singh@intel.com \
--cc=konstantin.v.ananyev@yandex.ru \
--cc=mb@smartsharesystems.com \
--cc=mkashani@nvidia.com \
--cc=orika@nvidia.com \
--cc=roretzla@linux.microsoft.com \
--cc=ruifeng.wang@arm.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).