From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Michal Jastrzebski <michalx.k.jastrzebski@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] test: fix test_tlb_tx_burst
Date: Wed, 05 Aug 2015 11:28:40 +0200 [thread overview]
Message-ID: <7330921.0l7ts1gtOu@xps13> (raw)
In-Reply-To: <1438765813-10932-1-git-send-email-michalx.k.jastrzebski@intel.com>
2015-08-05 11:10, Michal Jastrzebski:
> This patch fixes error in tlb_tx_burst function:
> Distribution is not even.
What was the error exactly?
> A condition in TEST_ASSERT macro was changed,
> as the previous one was random.
I think "random" can be better described.
> Also the time of generating packets can now be decreased.
> /* Generate 400000 test bursts in 2s of packets to transmit */
> - for (i = 0; i < 400000; i++) {
> + for (i = 0; i < 10000; i++) {
It is a good example of an useless comment which becomes easily out-of-date.
prev parent reply other threads:[~2015-08-05 9:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-05 9:10 Michal Jastrzebski
2015-08-05 9:28 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7330921.0l7ts1gtOu@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=michalx.k.jastrzebski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).