From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6DBB7A0350; Tue, 22 Feb 2022 10:21:40 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5FA8840DF6; Tue, 22 Feb 2022 10:21:40 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 290714113C for ; Tue, 22 Feb 2022 10:21:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645521698; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=02RMDbwHf03tWrm+TUdqzrDQZIv/YbeTLi4+HQoC4UE=; b=alau7Cr8XnkTJH4fmnPowJzIvg46Nqp3hC7QVnMIHs9L8dSup1lLohIwzP3l2MEHav9o6O wQ/XR17jjvvW7Q1h4cc6f3Tr5zhKm0F+1yK5hH9rjeD6zkzeZDaTjP9MMWeeVOkRvwuVlZ vjiVQYr4qpImaqBFf5xykmI36OjL1jM= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-547-e3WiPRQNOjORWIlvJEc3CA-1; Tue, 22 Feb 2022 04:21:33 -0500 X-MC-Unique: e3WiPRQNOjORWIlvJEc3CA-1 Received: by mail-wm1-f72.google.com with SMTP id l31-20020a05600c1d1f00b00380e3425ba7so99401wms.9 for ; Tue, 22 Feb 2022 01:21:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:cc:references:from:subject:in-reply-to :content-transfer-encoding; bh=02RMDbwHf03tWrm+TUdqzrDQZIv/YbeTLi4+HQoC4UE=; b=F+3ml+y+3+p0bTMo0YZImcUm9c41uJ5xyhFTauRtdSvQXL3MUQxmd6xYKnhAn5xUy8 6I8q5nxlAyJcwC00VadE6MuyX92H6SQPmsnfDaDXsGPebUGLHD+s1APJrogNv57ZGkf/ 1UWvuHSckc6+6UsAx/7LwcPvevj0si8vVbCfT1mZ3fwxE3F395XGteLFhuHQPzv1sgMe gWXkSlj9+zGubefocnOCwWbH93X6vbVfz0CZiRlAPJFbBWZ81nmuJy97NaTSMd1149yz XdTCB7iIfrG7bu+yqWpiHgomsi3CozFgcYCp7/sA9HE5XlF4vfvdf5VkrpTb3DOKCyTQ S6ew== X-Gm-Message-State: AOAM532XQ0LPgnPZdxbI//zDX7fUGjdv7OWV1XvgeQoUCGrshiSTJ7kx 7s0AiCSo9HypVFv/JBpUEF3KmDvXIXiqLNKsi2NXp1tWY3LJbSXJvHPX8SP17Slvy1WDfilsdkJ ohH0= X-Received: by 2002:a5d:5888:0:b0:1ea:118f:4a82 with SMTP id n8-20020a5d5888000000b001ea118f4a82mr8277436wrf.502.1645521692114; Tue, 22 Feb 2022 01:21:32 -0800 (PST) X-Google-Smtp-Source: ABdhPJypDshcxkwcXiR8ME49E0eERlDSJdzaUM3tM4WZ7r7PQUorqVvGjf9ZFfDYXb680fc8yhSc5w== X-Received: by 2002:a5d:5888:0:b0:1ea:118f:4a82 with SMTP id n8-20020a5d5888000000b001ea118f4a82mr8277413wrf.502.1645521691849; Tue, 22 Feb 2022 01:21:31 -0800 (PST) Received: from [192.168.0.36] ([78.16.131.8]) by smtp.gmail.com with ESMTPSA id f18sm2123195wmg.21.2022.02.22.01.21.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Feb 2022 01:21:31 -0800 (PST) Message-ID: <733185cb-95a4-c502-c4f4-77112331f390@redhat.com> Date: Tue, 22 Feb 2022 09:21:30 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 To: "Zhang, Qi Z" , Navin Srinivas Cc: "Wang, Yixue" , "Yang, Qiming" , "Zhang, Liheng" , "Dong, Yao" , "dev@dpdk.org" , "stable@dpdk.org" , "Xueming(Steven) Li" References: <20210524090759.980530-1-qi.z.zhang@intel.com> <8297b7a87913490f894ee38bdb22a1e2@intel.com> From: Kevin Traynor Subject: Re: [dpdk-dev] [PATCH] net/ice: fix wrong data path selection in secondary process In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 22/02/2022 04:30, Zhang, Qi Z wrote: > Hi Srinivas: > > This is the fix for PF driver only, for VF we have a separated fix and it is not be captured in 20.11.3, but I saw the patches are already merged in stable tree. > You can try with latest 20.11.4-rc1, or wait for 20.11.4 LTS. > 20.11.4 is already released. Xueming sent details here http://inbox.dpdk.org/announce/20220124084950.482883-1-xuemingl@nvidia.com/T/#u You can check the release notes (or git) for specific fixes https://git.dpdk.org/dpdk-stable/tree/doc/guides/rel_notes/release_20_11.rst?h=20.11 > Regards > Qi > > From: Navin Srinivas > Sent: Tuesday, February 22, 2022 11:56 AM > To: Zhang, Qi Z > Cc: Wang, Yixue ; Yang, Qiming ; Zhang, Liheng ; Dong, Yao ; dev@dpdk.org; stable@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/ice: fix wrong data path selection in secondary process > > Hi, > > Is this tested on VFs? I saw crash on both PF as well as VF, on 20.11.1, but did not see PF crash on 20.11.3, > I'm seeing a crash on the secondary process when it receives packet on the VF, but PF doesn't crash now on 20.11.3 > > So I suspect this is the patch which is fixing the issue on ICE secondary process crash on PF. > > Thanks & Regards, > Navin Srinivas > > On Thu, Jun 3, 2021 at 3:51 PM Zhang, Qi Z > wrote: > > >> -----Original Message----- >> From: Wang, Yixue > >> Sent: Thursday, June 3, 2021 6:04 PM >> To: Zhang, Qi Z >; Yang, Qiming >> > >> Cc: Zhang, Liheng >; Dong, Yao >> >; dev@dpdk.org; stable@dpdk.org >> Subject: RE: [PATCH] net/ice: fix wrong data path selection in secondary >> process >> >> Hi, Qi >> >> I've tested this patch and it works. >> >> Best Regards, >> Yixue. >> >>> -----Original Message----- >>> From: Zhang, Qi Z > >>> Sent: Monday, May 24, 2021 17:08 >>> To: Yang, Qiming > >>> Cc: Zhang, Liheng >; Wang, Yixue >>> >; Dong, Yao >; dev@dpdk.org; >>> Zhang, Qi Z >; stable@dpdk.org >>> Subject: [PATCH] net/ice: fix wrong data path selection in secondary >>> process >>> >>> The flag use_avx2 and use_avx512 are defined as local variables, they >>> will not be aware by the secondary process, then wrong data path is >>> selected. Fix the issue by moving them into struct ice_adapter. >>> >>> Fixes: ae60d3c9b227 ("net/ice: support Rx AVX2 vector") >>> Fixes: 2d5f6953d56d ("net/ice: support vector AVX2 in Tx") >>> Fixes: 7f85d5ebcfe1 ("net/ice: add AVX512 vector path") >>> Cc: stable@dpdk.org >>> >>> Reported-by: Yixue Wang > >>> Signed-off-by: Qi Zhang > > > Tested-by: Yixue Wang > > > Applied to dpdk-next-net-intel. > > Thanks > Qi