From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 36DF0A0562; Wed, 14 Apr 2021 23:47:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 14BBB161D5B; Wed, 14 Apr 2021 23:47:27 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 0B638161D59 for ; Wed, 14 Apr 2021 23:47:24 +0200 (CEST) IronPort-SDR: RENU6HOWKmD2DOUEG6dUcRJ868BNjssdaBITKh9BPlb398z8Fyym6Nc41Z2vIGIdseAzrpRoQ6 gmmteMZbAH4A== X-IronPort-AV: E=McAfee;i="6200,9189,9954"; a="181866587" X-IronPort-AV: E=Sophos;i="5.82,223,1613462400"; d="scan'208";a="181866587" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2021 14:47:22 -0700 IronPort-SDR: a2gPLSVw3QFfAKqOXPjYxsOenK8e1LCDci2WmWmzNLfXlcLEF/1yi0lI1gqK5LvFaWqc/GHOvZ GHQ9oZsJbDKQ== X-IronPort-AV: E=Sophos;i="5.82,223,1613462400"; d="scan'208";a="612251525" Received: from rmenon-desk.amr.corp.intel.com (HELO [10.166.30.253]) ([10.166.30.253]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2021 14:47:17 -0700 To: Thomas Monjalon Cc: Dmitry Kozlyuk , dev@dpdk.org References: <20210407222249.6729-1-dmitry.kozliuk@gmail.com> <2549908.9JeyF6cTkx@thomas> <3072229.f5VMXNVXpi@thomas> From: Ranjit Menon Message-ID: <7340b084-cca7-88da-8656-dafa4348cfc0@intel.com> Date: Wed, 14 Apr 2021 14:47:13 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: <3072229.f5VMXNVXpi@thomas> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v9 0/4] eal/windows: do not expose POSIX symbols X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Archived-At: List-Archive: On 4/14/2021 2:42 PM, Thomas Monjalon wrote: > 14/04/2021 23:34, Ranjit Menon: >> On 4/14/2021 2:12 PM, Thomas Monjalon wrote: >>> 13/04/2021 09:00, Dmitry Kozlyuk: >>>> Hi Ranjit, >>>> >>>> 2021-04-12 21:46 (UTC-0700), Ranjit Menon: >>>> [...] >>>>> The change to remove the networking shim breaks l2fwd compilation on >>>>> Windows, since l2fwd/main.c includes netinet/in.h explicitly. >>>>> >>>>> How do you propose we fix this, only for Windows? >>>> This include is redundant for this file on all platforms, it can be removed. >>>> Since -Dexamples=all doesn't work on Windows because of missing dependencies, >>>> I wonder which of them need fixing. >>> Let's fix the examples which are supported on Windows. >>> Other examples may require more updates anyway. >>> >> Thanks, Thomas. For now, this is only required in l2fwd. > Only l2fwd is supported on Windows? > >> Dmitry, can you please include this in your patch 4/4? > Ranjit, if you tell me what exactly is needed, I can do it > and merge the series quickly. Sure, Thomas. In l2wfd/main.c, all we need to do is remove the #include line. This include file will not exist on Windows anymore, and Dmitry determined that this include is not required in l2fwd on all platforms. ranjit m. >