From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 19B5B1BAFB for ; Wed, 27 Jun 2018 15:31:58 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 6507221B05; Wed, 27 Jun 2018 09:31:57 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 27 Jun 2018 09:31:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=/EUK9ENGCfsXYoLTKYyNUAcmyh gwpfpBhD+kDO52xjA=; b=Ua1hTUZ1tqgErQmaQ3JR25a0V4Ej9kVmvNpEUbVjYK EgDDMF/nmVVCvVO/4UoWDDFp0TSNFom7HpnXJk8UI5bzojiyJ6qJQgLu5jRt4sBa n8cjlLGjuPz1r6B8HwxLlutb6TJixH0TtaWLJr1u5i3vaPY0+piQRv4fRYsmab1X o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=/EUK9E NGCfsXYoLTKYyNUAcmyhgwpfpBhD+kDO52xjA=; b=CXLez4ZrrkGi/TUosuFnOQ /3trdVI+ZsYx8282ZDnGKnej0gWfRXn0duBww9B07uNMmRejqEVgCxnR4ICDM6Ol FzPc4fUpKC8gRUDrFw/bxNI8WQEwGV+jpasj5xpMtDJbuxUWopQukOrVpT9KD5/r T296fFXuH55/oHE0ieodax9sVS+rDv3FAqw46NbxehLc+qar8oh86/U6J7S2v4/n fxigvCyPCK26yKWdCvsSo+2dviohG5FdaqIzGcYhyj9T/pA2E6gpozRi+y60Wnor BsW4NR9j4ndmST2+VQUz2E7bwXPlv7H6fP+rfNcKkJERe2y5VCNO1HhkDeTFjzAQ == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 9BFE6103A0; Wed, 27 Jun 2018 09:31:56 -0400 (EDT) From: Thomas Monjalon To: Choonho Son Cc: dev@dpdk.org, Bruce Richardson Date: Wed, 27 Jun 2018 15:31:55 +0200 Message-ID: <7357136.ipTnM7Ko6i@xps> In-Reply-To: <20180621095502.GA436@bricha3-MOBL.ger.corp.intel.com> References: <1529573741-9606-1-git-send-email-choonho.son@gmail.com> <1529573741-9606-2-git-send-email-choonho.son@gmail.com> <20180621095502.GA436@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] usertools: fix build with gcc X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jun 2018 13:31:58 -0000 21/06/2018 11:55, Bruce Richardson: > On Thu, Jun 21, 2018 at 09:35:41AM +0000, Choonho Son wrote: > > dpdk-setup.sh fails to build with lack of environment variable > > > > Build complete [x86_64-native-linuxapp-gcc] > > Installation cannot run with T defined and DESTDIR undefined > > > > Signed-off-by: Choonho Son > > --- [...] > > - make install T=${RTE_TARGET} > > + make install T=${RTE_TARGET} DESTDIR=${DESTDIR} > > The message about no DESTDIR is not really an error, the build has > completed successfully. I don't think copying the build over to a new > directory is something we should always do as part of this script. Absolutely! The syntax "make install T=" is old. It should be replaced by "make config T=" + "make". You can look at devtools/test-build.sh to see how compilation can be done. It is also documented in various places like: doc/guides/linux_gsg/build_dpdk.rst doc/guides/prog_guide/dev_kit_root_make_help.rst More options: - use meson build system in dpdk-setup.sh - maybe too early - remove dpdk-setup.sh - maybe used by real users