Re: [dpdk-dev] [PATCH] ip_frag: fix ipv6 when MTU sizes not aligned to 8 bytes

[Thomas Monjalon <thomas@monjalon.net>]

28/11/2018 11:15, Luca Boccassi:
> On Mon, 2018-11-26 at 23:56 -0500, Chas Williams wrote:
> > From: Chas Williams <chas3@att.com>
> > 
> > The same issue was fixed on for the ipv4 version of this routine in
> > commit 8d4d3a4f7337 ("ip_frag: handle MTU sizes not aligned to 8
> > bytes").
> > Briefly, the size of an ipv6 header is always 40 bytes.  With an MTU
> > of
> > 1500, this will never produce a multiple of 8 bytes for the frag_size
> > and this routine can never succeed. Since RTE_ASSERTS are disabled by
> > default, this failure is tpyically ignored.
> > 
> > To fix this, round down to the nearest 8 bytes and use this when
> > producing the fragments.
> > 
> > Fixes: 0aa31d7a5929 ("ip_frag: add IPv6 fragmentation support")
> > 
> > Signed-off-by: Chas Williams <chas3@att.com>
> > ---
> >  lib/librte_ip_frag/rte_ip_frag.h            |  1 +
> >  lib/librte_ip_frag/rte_ipv6_fragmentation.c | 18 +++++++++++-------
> >  2 files changed, 12 insertions(+), 7 deletions(-)
> 
> Acked-by: Luca Boccassi <bluca@debian.org>

Konstantin, no comment?