From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id 735415683 for ; Fri, 27 Nov 2015 16:42:11 +0100 (CET) Received: by wmww144 with SMTP id w144so59845830wmw.1 for ; Fri, 27 Nov 2015 07:42:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=O/OjMQL4yHCEF8bmbHii3GHuvhlNLbr0softow/eqJ4=; b=RnRPhH1ej44XOThyRMyFRg+88dMfln9hBOjKGsxq3kXRnPXfmQD/ojZGO0F07Aure3 NVArqi6RaPkvWMW4vaSmnhKzMxedQVc5Mzytce48gOCBZ7rzxU9SzAlrXDJu1AYecriQ goJw2ZwINc2k8+sSSPdXYbu4PPyZpyuLKyOB8r3k8jXyEsf+7siYaQHJnPD3AyTug4aI 4+Zx70zN08/yKZfZd77z8Osx74/eiQDVSjgO2p9GrD215AC1MrdJ6yeQYZqTc+kF6Jb2 O1/ErABdeo9mxpt3vBxAHgBn1186sOc5lMGjdRAWPtqWV6rPD8cpPPCBXECB5iRXJ2zh iHLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=O/OjMQL4yHCEF8bmbHii3GHuvhlNLbr0softow/eqJ4=; b=T5SpDBywhd1YkRo4ggZ1AS0gSnLIBsAzRtxYlWcIZv2gonvFmhgNCkd8ybdGXlab9Z hkji5zPlmqSt9hAEEy4TqO6XefsPa01CERFqpZsGl+jT89HbO5aEV4yHwS8lLNbEvJ0c BEIgzmW9tj6wMvsd7Kgh6HU34rddtuFyV0aavySm37vXtVaBmAIKmfmKsIz0hgi+EHIm QqkSjz9AA7n4we5iY5r6Qq6i5JXexgyj1fM4QkJAK5X2K8sxjDt0zR9gJQxMtOKBlTLJ HhCDrBa1ZzvUclMrNbgF0tf53yafkSK+f/q3FdlUth+rh2H36z0je3enTmK4VHHTjQcK 2a7w== X-Gm-Message-State: ALoCoQlCLRV2W9PuHjhJr6qd6XZmRu5nSHxTZi44bNtZZ9uRWTwwebO/42ml/IQQyQP47yoszH/S X-Received: by 10.28.16.133 with SMTP id 127mr11931356wmq.24.1448638931290; Fri, 27 Nov 2015 07:42:11 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id m16sm8034146wmb.13.2015.11.27.07.42.10 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 27 Nov 2015 07:42:10 -0800 (PST) From: Thomas Monjalon To: Panu Matilainen Date: Fri, 27 Nov 2015 16:40:51 +0100 Message-ID: <7380042.Av6xXtCM9v@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <5600FB8B.6070909@redhat.com> References: <1442608390-12537-1-git-send-email-mario.alfredo.c.arevalo@intel.com> <1442608390-12537-8-git-send-email-mario.alfredo.c.arevalo@intel.com> <5600FB8B.6070909@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 7/7] mk: Add hierarchy-file support (linux mod) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Nov 2015 15:42:11 -0000 2015-09-22 09:56, Panu Matilainen: > On 09/18/2015 11:33 PM, Mario Carrillo wrote: > > +MOD_DIR := $(DESTDIR)/lib/modules > > +KERNEL_DIR := $(shell uname -r)/extra > > Please don't assume one is always building for the running kernel. > Defaulting around uname -r is perfectly reasonable, but there needs to > be a way to override it from the cli. For example rte.vars.mk has this: > > # can be overriden by make command line or exported environment variable > RTE_KERNELDIR ?= /lib/modules/$(shell uname -r)/build For info, the ?= operator is a way to give a default value after having included other makefiles which may set a different value. Both ?= and := (or simply =) are overriden by the command line. Only "override VAR =" will not be overriden by the command line.