From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3FBBC4550C; Thu, 27 Jun 2024 16:48:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2257940E09; Thu, 27 Jun 2024 16:48:32 +0200 (CEST) Received: from fout8-smtp.messagingengine.com (fout8-smtp.messagingengine.com [103.168.172.151]) by mails.dpdk.org (Postfix) with ESMTP id C26AA40BA3 for ; Thu, 27 Jun 2024 16:48:29 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailfout.nyi.internal (Postfix) with ESMTP id 75B021380236; Thu, 27 Jun 2024 10:48:29 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Thu, 27 Jun 2024 10:48:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1719499709; x=1719586109; bh=hAh77WX3jUxGzsG444vNqJlhNprgAexw+DSOLp5ZxK4=; b= Pk/0AYWUgYfJ10fdtPMEK0+4orvKu/Gsm/+Xgdt7TsmmvnYIDdrGOISwJ8rHq2Xy Y0XeRVikJIaYYkzX/ZWrdk3OrJOwLl3YucZxXToNryqwkuMMkadvHwszN8qRYXFH 5RolF6sKkhG2K84mdLvUAFnMJLGCxAQC16L1r7c1B/Dq1wcho9nBBBmV6NwOegyd wAiq7qA3WdP136l2vnFoKSH2fJ0Cng+HbQV8JnzbAmZSfpl5N2jD8ugzn9D+NGjO rJ354g9hm0+kwWke2Yq7rRG/9h3pj/VgO+AX3627lTRi1Pe5er0qji3n7AIyd327 inY53QBQ5Cr/EYo5HvAYUw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1719499709; x= 1719586109; bh=hAh77WX3jUxGzsG444vNqJlhNprgAexw+DSOLp5ZxK4=; b=u AXqOt+CFg5J3asWPkmqGSZOUZ9Il6aSZhjQcz1V73Q4KKfHltAziH4xJaNC6rCk4 U6HrSYZG+h/no6mJz3lIzq+M73G416HRUzXvhDcp7DnSC96bAklv76z+2eD9oHMC VbXYsRxJ30YmhE6ejyuWq0mVVIt3JQ6EUgippUjvCVQLSE6S6MRkiNguYiQBfazO +IZB8UUla+OUEGEPJ9+NxWCJW3PiLOr2kMLwmD5iEusTIrbl3eKqzjZj8VN+txEP MI7joOergXrla822MShIA2iU1tFnTT9qxIllO4ch02VZMIaKO4RBt9T1emAhxRfY hKNKMxg5ybAdc2AaTvwfw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrtdeggdekudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepjeduveehieevuddutdevfffgtdegkeeuveejffejgedtgeegkefg vdeugfefkeejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 27 Jun 2024 10:48:27 -0400 (EDT) From: Thomas Monjalon To: Yoan Picchi Cc: dev@dpdk.org, nd@arm.com, david.marchand@redhat.com, Yipeng Wang , Sameh Gobriel , Bruce Richardson , Vladimir Medvedkin Subject: Re: [PATCH v9 0/4] hash: add SVE support for bulk key lookup Date: Thu, 27 Jun 2024 16:48:26 +0200 Message-ID: <7382338.kIvqiD65kZ@thomas> In-Reply-To: <20240430162743.1525484-1-yoan.picchi@arm.com> References: <20231020165159.1649282-1-yoan.picchi@arm.com> <20240430162743.1525484-1-yoan.picchi@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 30/04/2024 18:27, Yoan Picchi: > This patchset adds SVE support for the signature comparison in the cuckoo > hash lookup and improves the existing NEON implementation. These > optimizations required changes to the data format and signature of the > relevant functions to support dense hitmasks (no padding) and having the > primary and secondary hitmasks interleaved instead of being in their own > array each. > > Benchmarking the cuckoo hash perf test, I observed this effect on speed: > There are no significant changes on Intel (ran on Sapphire Rapids) > Neon is up to 7-10% faster (ran on ampere altra) > 128b SVE is about 3-5% slower than the optimized neon (ran on a graviton > 3 cloud instance) > 256b SVE is about 0-3% slower than the optimized neon (ran on a graviton > 3 cloud instance) > > V2->V3: > Remove a redundant if in the test > Change a couple int to uint16_t in compare_signatures_dense > Several codding-style fix > > V3->V4: > Rebase > > V4->V5: > Commit message > > V5->V6: > Move the arch-specific code into new arch-specific files > Isolate the data struture refactor from adding SVE > > V6->V7: > Commit message > Moved RTE_HASH_COMPARE_SVE to the last commit of the chain > > V7->V8: > Commit message > Typos and missing spaces > > V8->V9: > Use __rte_unused instead of (void) > Fix an indentation mistake Waiting for a new version after comments sent in June please. Note: we didn't have a review from the lib maintainers.