From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 125BDA0542;
	Fri, 11 Nov 2022 09:52:26 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 0150940F16;
	Fri, 11 Nov 2022 09:52:26 +0100 (CET)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 111E240150
 for <dev@dpdk.org>; Fri, 11 Nov 2022 09:52:24 +0100 (CET)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 87E247D;
 Fri, 11 Nov 2022 11:52:23 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 87E247D
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1668156743;
 bh=6akM81MaICaCKKXOGdQz1qi/I0SyL1++5WLVjaZxAgI=;
 h=Date:Subject:From:To:Cc:References:In-Reply-To:From;
 b=sZ1DFixk+yfdjmD0+h1fYs2aHAkBY/PRHCc6wQuIThEnJr8L1zLCAFSVeUN1ApMtz
 807PC7FXXBgpsceFZ5S4hhDCj9EKIe2EMAVYqR+QTV8+iY9zvX61yOqKGJdcqAZQJF
 tCBYEaB7isTsG8duGnAcja80cRVIUqdvdS2ODRno=
Message-ID: <739b48f9-a835-6dab-b0dd-00c2601cbece@oktetlabs.ru>
Date: Fri, 11 Nov 2022 11:52:23 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH v2 0/2] app/testpmd: support TCP TSO in Tx only mode
Content-Language: en-US
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
To: Ferruh Yigit <ferruh.yigit@amd.com>
Cc: dev@dpdk.org
References: <20221111084929.1579639-1-andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
In-Reply-To: <20221111084929.1579639-1-andrew.rybchenko@oktetlabs.ru>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 11/11/22 11:49, Andrew Rybchenko wrote:
> Add command-line option to generate TSO packets with specified MSS
> in txonly mode.
> 
> I'm not sure that it is a good idea to enable TSO offload automaticaly
> when the options is specified, but it is convenient.
> 
> v2:
>      - fix wrong data length calculation (as per review notes from Ferruh)
> 
> Andrew Rybchenko (2):
>    app/testpmd: prepare to support TCP in Tx only mode
>    app/testpmd: support TCP TSO in Tx only mode
> 
>   app/test-pmd/parameters.c             |  16 ++-
>   app/test-pmd/testpmd.c                |  12 +++
>   app/test-pmd/testpmd.h                |   5 +-
>   app/test-pmd/txonly.c                 | 140 +++++++++++++++++++-------
>   doc/guides/testpmd_app_ug/run_app.rst |   4 +
>   5 files changed, 134 insertions(+), 43 deletions(-)
> 

Self NAK, I forgot --in-reply-to and finally changed my mind
about review notes processing. Sorry for spam. I'll send v3
shortly.