From: fengchengwen <fengchengwen@huawei.com>
To: Stephen Hemminger <stephen@networkplumber.org>, <dev@dpdk.org>
Subject: Re: [PATCH v2 0/6] Enable warnings about use of comma operator
Date: Fri, 15 Aug 2025 08:30:37 +0800 [thread overview]
Message-ID: <73b2a9a0-153c-4964-902d-a61c835ef341@huawei.com> (raw)
In-Reply-To: <20250814212901.88863-1-stephen@networkplumber.org>
Series-acked-by: Chengwen Feng <fengchengwen@huawei.com>
On 8/15/2025 5:28 AM, Stephen Hemminger wrote:
> This series was motivated by recent thread on netdev
> about build with -Wcomma in clang. This warning catches code
> that uses comma where a semi-colon is a better choice.
>
> v2 - rebase and drop any driver related changes
>
> Stephen Hemminger (6):
> eal: replace unnecessary comma operator
> ipsec: replace unnecessary comma operator
> graph: replace unnecessary comma operator
> test: replace unnecessary comma operators
> app/testpmd: replace comma operator with bracket
> config: enable comma warnings
>
> app/test-pmd/cmdline_flow.c | 6 ++++--
> app/test-pmd/config.c | 10 ++++++----
> app/test/test_compressdev.c | 4 ++--
> app/test/test_link_bonding_rssconf.c | 2 +-
> app/test/test_thash.c | 2 +-
> config/meson.build | 1 +
> drivers/meson.build | 2 +-
> lib/eal/common/rte_malloc.c | 4 ++--
> lib/eal/linux/eal_alarm.c | 6 ++++--
> lib/graph/graph_stats.c | 2 +-
> lib/ipsec/misc.h | 3 ++-
> 11 files changed, 25 insertions(+), 17 deletions(-)
>
> --
> 2.47.2
prev parent reply other threads:[~2025-08-15 0:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-12 23:26 [RFC 0/7] avoid unnecessary use of comma op Stephen Hemminger
2025-03-12 23:26 ` [RFC 1/7] eal: replace unnecessary comma operator Stephen Hemminger
2025-03-12 23:26 ` [RFC 2/7] ipsec: " Stephen Hemminger
2025-03-12 23:27 ` [RFC 3/7] graph: " Stephen Hemminger
2025-03-12 23:27 ` [RFC 4/7] net/mlx4: replace unnecessary comma operators Stephen Hemminger
2025-03-12 23:27 ` [RFC 5/7] net/mlx5: " Stephen Hemminger
2025-03-12 23:27 ` [RFC 6/7] test: " Stephen Hemminger
2025-03-12 23:27 ` [RFC 7/7] app/testpmd: replace comma operator with bracket Stephen Hemminger
2025-08-14 21:28 ` [PATCH v2 0/6] Enable warnings about use of comma operator Stephen Hemminger
2025-08-14 21:28 ` [PATCH v2 1/6] eal: replace unnecessary " Stephen Hemminger
2025-08-14 21:28 ` [PATCH v2 2/6] ipsec: " Stephen Hemminger
2025-08-14 21:28 ` [PATCH v2 3/6] graph: " Stephen Hemminger
2025-08-14 21:28 ` [PATCH v2 4/6] test: replace unnecessary comma operators Stephen Hemminger
2025-08-14 21:28 ` [PATCH v2 5/6] app/testpmd: replace comma operator with bracket Stephen Hemminger
2025-08-14 21:28 ` [PATCH v2 6/6] config: enable comma warnings Stephen Hemminger
2025-08-15 0:30 ` fengchengwen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73b2a9a0-153c-4964-902d-a61c835ef341@huawei.com \
--to=fengchengwen@huawei.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).