From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0AAD4A0552; Thu, 17 Nov 2022 16:01:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A049740DDC; Thu, 17 Nov 2022 16:01:23 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 79DC040DDA for ; Thu, 17 Nov 2022 16:01:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668697281; x=1700233281; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=HqVxvJMl0G8KXEQ/4yyHxcZO5lzSCc6CAaCMXzP8WWc=; b=VunbEGyVS5kVUb1lHBL5xnwcYUJfGtQsN1ilH+DYJ81W5b6uSdsFRYxq i9fMwA8MeTla0paZDd90RoJuyKw1Ti7x4/Jg6kQ8bWVwX2vBVCVpp9i2P hHE2Uo9Ko5ZJkASmpbZVbJztym1ePUEfK8u0pO+BWOP4XpFDXB/U3W2Cz GXfxHYu2PWsCYmYMfwOPMVzuXjCr0ljqvQz24B3n4I/fGgABmksBiu2FP 8s5JSXp4Q7CMqO2G/WdFX37XQTrG4zx0gYHJaHblXcVBVKRS04JuzyNH5 gScKLpTvMvu0gOdB3ZIP3QMaUKGCwgfllq6XM0yZ7q7GwVhDKNpcq1oJ+ Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10534"; a="293264990" X-IronPort-AV: E=Sophos;i="5.96,171,1665471600"; d="scan'208";a="293264990" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2022 07:00:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10534"; a="782247663" X-IronPort-AV: E=Sophos;i="5.96,171,1665471600"; d="scan'208";a="782247663" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga001.fm.intel.com with ESMTP; 17 Nov 2022 07:00:44 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 17 Nov 2022 07:00:43 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 17 Nov 2022 07:00:43 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Thu, 17 Nov 2022 07:00:43 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.170) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Thu, 17 Nov 2022 07:00:43 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FUAcImOEg58SwyJhyyWOL2haLPJ0f9DN9yC+pnmaNX4sngZtfXCS3gt22WC9fQIbs7Ye1o01FZVQkW+qSxitfOdc6X/ok8II5Ymx3W6ZED54BQzD4nnTk49L9Is5MdiEp1QsY0uqGNGJwwz+nvsYO+HnvCzYtxgT2aayynGDpfKrtpLUmfW0m2myaJrdtHL6bqLQ6zEQjis0jjOfhdqbNsP1jSv31mySIYOGVFbptqUg40nItYHZpC2AGgv8wpD6ZWA0CBnSX0PMrtCYCsvuUyXeg4VD4OxqV/k2HvOIuZXm1EkpmtZyROxPCDdVv2vF+1tegtaagq7NV4AyelEPHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=e/6sU6rJ723ZOyvK4wiu95UBOpxLXGrLh/H/pU7yGp8=; b=ZVP967mdRk0TeTy8LRSot35x6PspPXLNAKSo47cO9YAvNimiPxqJgpjmQREgNwJMFaHs7FxlDvI8gxKFaepkAgHGDJktBXVwWzB39XZDwlDGPzKazX6A8OlXyfmWohHGFbhlK9mxDa3RrmoOIOVD6NJ1ApdHyhbxwIuNklOFT2NXIDpYN5/WrKdi1k1hwDvjtQBNiHP/HcldBKz6Mba7QCIGEoeZENwo+4V/aB+IidvPswANT7b85j0J5UYvtWRgIxlOKysT46ZL1Ja/FUdCSYdSyy1EJKvAumHr2wXGDPH2ykGjdd6CA0M9ys02OEiN9jvez3LCYtwEsThmE8ry8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB0062.namprd11.prod.outlook.com (2603:10b6:301:67::34) by BL1PR11MB5978.namprd11.prod.outlook.com (2603:10b6:208:385::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17; Thu, 17 Nov 2022 15:00:39 +0000 Received: from MWHPR11MB0062.namprd11.prod.outlook.com ([fe80::edfe:aa7b:c5c6:fa7f]) by MWHPR11MB0062.namprd11.prod.outlook.com ([fe80::edfe:aa7b:c5c6:fa7f%6]) with mapi id 15.20.5813.018; Thu, 17 Nov 2022 15:00:39 +0000 Message-ID: <73db4a7a-a4c4-2512-2352-6ab0d7786c69@intel.com> Date: Thu, 17 Nov 2022 20:30:27 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v2 1/1] app/testpmd: add valid check to verify multi mempool feature Content-Language: en-US To: Hanumanth Pothula , Yuying Zhang CC: , , , <-yux.jiang@intel.com>, , References: <20221117113047.3088461-1-hpothula@marvell.com> <20221117125542.3091224-1-hpothula@marvell.com> From: "Singh, Aman Deep" In-Reply-To: <20221117125542.3091224-1-hpothula@marvell.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PN3PR01CA0082.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:9a::17) To MWHPR11MB0062.namprd11.prod.outlook.com (2603:10b6:301:67::34) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR11MB0062:EE_|BL1PR11MB5978:EE_ X-MS-Office365-Filtering-Correlation-Id: 43942198-d542-4b79-3d0d-08dac8ac7d81 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ghOnLclnPT6vPAK4dbbVymKFZlEsXFVNMqyp/pYmsecAP0QHmbKozzgOoi6OHEEIxUAQ1Z90uTzSL0JwXJ63LEoczv9s1gVvFXqEkN47DRW6qmAyEUJJeLyWH8y2BMtxLNUQuUqn8hYy1G+ILZEAk4A78nchTFfJzF63pGifRmorxqMvw87h7nQ7K+iUr0Hyxm5n4uafLypWZuXu9A81Zfshnccba09/7vP2tXokBa2gpfuAw6yydXZcuUQguG862LM4Jfa1jrNalxqOI4OVDXM9npUZtWfxP4HloeVU3ij4rflOJx3p7WLXoD5DtHJX64sWvvQF90IQGAyIuYh0pLgH8Hc0HdP11dwu8akSR5lahHO1ZIfKwF3GEuO2zq6q6/fwOsdVmfTM5HGhcYCWrpVgdblCBDR0rpn8tc1rse9Smjx9GDbPDPC03klvwwmqX9AtiUvNiQ+/ms4asfSC/Cu4HzSMPIzOF8unskj4iRAqYsXVfWGfgUpWCVc2mXzj8niT2SkioW0M2ZCExeE/vBM5wnmNRjR0/AWoLyBaLOiytLvxplHAHeBGyfrX+fXzSnDYULwsr6oWcaNyL0PLkB+UsOAUF77WWwgi9kG3m+Xt4RmZ1aHZ4j7HvBF2atKYPlPbmwLKCfv9lPH3PLDNY/ZvBVf7ZGzXjIhcpTPsSqc3nRddeMVVLQIdN33NIvqxGKFaaCunHHWP3BLN3p8Cj08wCx1CgxylzhXtcgDcQI0= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB0062.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(366004)(376002)(136003)(396003)(346002)(39860400002)(451199015)(31686004)(36756003)(38100700002)(86362001)(31696002)(6636002)(82960400001)(2616005)(83380400001)(26005)(2906002)(53546011)(6512007)(8936002)(41300700001)(15650500001)(6506007)(6486002)(6666004)(186003)(5660300002)(478600001)(66556008)(8676002)(4326008)(316002)(66476007)(110136005)(66946007)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MDBkNjVrQ3RxbSt3dVFVVzkreUM0bGlEb3ErUTNVM0JuNzBpeUdzTFF5Vzhk?= =?utf-8?B?VGxKYWtxZ2grSUtmZy8xVEtHbU1GNkR3T2pmaXNNRGw4KzE3YzBhOTBOYUo5?= =?utf-8?B?QWx1S2FRT0Y5Zml2YUpmYnRSczR4MTFOQ0wvZkxreHhlNWpVZkhZK21ZbFFZ?= =?utf-8?B?SG9qSEZrN1czNHRYQVFmWVNXTVpXTWwrcnIxV0ZCbG1LUVNKc0lpRXdrWFZn?= =?utf-8?B?ZEFDZWZFOFF3K3FaSGxibE5NUnVxVmoyaEFRTDl6azJLZDFFamVmR3lRRlc0?= =?utf-8?B?K21qeURaZDcrVXpLZzkzUGRBaUs2Z1cwUlVUMGRJSFRUZW80dGFUek5nYUpo?= =?utf-8?B?bHNIc2pna1FWSXlmalloblVVSDY4bjM1V2dpd0NXNlowb3JteUpxd3V1YVYv?= =?utf-8?B?Z2Z4Qi92QkovN01tSE12OTNhZTN2QTFVaFpEWm9HSHdoY3YyakgvZm51UGdj?= =?utf-8?B?WW94UGN4UUFGRExTUDNBKytEWnNXYlNPNXR5RHdxdVg0WXdIcjVvenhEODdQ?= =?utf-8?B?Ky9maWl0eXNVMXFGQ3E4UmY5WjIrZ3FzNlZvNnV4REgvZElJSFovd3d2SmJG?= =?utf-8?B?aEsvYld3ZVYvc09xSUh2NnRFTFROUERXaXBNMllUeDBSUTNWUWZLMzdJK0lC?= =?utf-8?B?MjRJc3hnR3J1Y1V2TnRpUlBXVFhSaytZdVR2VFNnQk9RZEh0S2JZZzdST1Nw?= =?utf-8?B?NkJLdWlIdE1TSU84TDM0ZkM5S3FEbmhtWHhDbXBkL2c4MWtFMVB2a1BMQ25J?= =?utf-8?B?K3Y1dW8zM3FvZzlJbC8yWVZpUGFBVzA4eDZuNWNsaFpOSzRPWTBlREFhcEJU?= =?utf-8?B?ekVGUWpyUFB5MldQYnp6b29ySDZLVzZ1Y01PVytQc0FPQldqTnRQRVYvZmtx?= =?utf-8?B?aGh2aUJXZjhvcE5CaTROdlFYMTFqZ0IxTDhtMm5McVRPYmxuNE5Bbi9FT1hU?= =?utf-8?B?Y1lWWk45OHJDelc3VUh2WFVRUlF3ZkFMREU1N24zRG8wZWV3ejhlUDNvaTdE?= =?utf-8?B?QmNBRGxVbW9Mcy83UE5tcm1UZnhnaG5FeFV0enloY2MyR0w5TG5yWkZTdmQz?= =?utf-8?B?d05yV3VnR0lxSWg0THhRcU56b3lJdURlcUZYNThkTGlPd0YwbWJWQzEzdDlK?= =?utf-8?B?ZGEwZk1RNi9nbk1UOFJvcUsrbXd1Njc0UkRmUVU5Y0NldUZRQVBlWFh6aGdj?= =?utf-8?B?eHhlNE1neVA5TlRyaWJicE16SFJ0NThtNkxBMTgrNS9sdnAyS0hMWTExNEhq?= =?utf-8?B?elZaUVY2cEVRemg1dHNwNUxEeXArWGdvdzZ4aERHQml3MEpJTGpHQmhpSkRR?= =?utf-8?B?eFcycDFxUHZKbmZ2Nk1ucWtEM01FRVFvRTZkSWJZQmF6NW9EVFVsUzlmWlZr?= =?utf-8?B?dWJLMW9XdlYyTUp2Y3dVTjRQaW1SejVTdEhiU0RjWjgzcEoyV3B5RlkrQm56?= =?utf-8?B?UitWV09aMXdBeUtieTNnbkh2eXlxVm1FVndWR1I1SGpHWEpGcEtWWHM5Kyty?= =?utf-8?B?dUdXRmtZV251NWxwVUtITFNqS2JUYmoxU25semlPRkRCWFZOeTJNckJmeExZ?= =?utf-8?B?ZWJtMHNteW1BNTErRTQ0TkNtUnlvOXVwVGd5U3FkQ3NzSWs5RFViTE5xbkkx?= =?utf-8?B?aFA3Y3cwUmZ1U05YNnRsUHhyOThUZjNQL05leHpmNWU1M1RTS3hDQmdLdjRC?= =?utf-8?B?c3pwbXZTenVKbFhFeEdVRGZnN2duU3FDV2xxVE1PY1hHNGpqZGNmMzl1ajlO?= =?utf-8?B?elNSc3NyNVQ4a2lmcGxadVB5eGdvMmVSUUFiQXVSZ2FPVzZJOGlpVGlIOGRH?= =?utf-8?B?eTB1aDQzcVZIdWxHSlJtSTgrSHZSRkFuYkt6THJDQ2k2clFPQzZBRFZEL0hG?= =?utf-8?B?YXViTlhOTEtxMUQvQVVZUFc3RHo2TEVqMGhLbEw0dS9Xa1I0aVY2M1J4ejNu?= =?utf-8?B?WFZMY3hTSTE5YW9xd2k1M1JHYWk1Z0lHTXhadE42aENWSmJ0RW8vejFvTTlG?= =?utf-8?B?eU80RzVobmhicnpMZmlaaGVQcXJyM0RobUxjM2h1SlRyZ2JsUnJlenJ5WStY?= =?utf-8?B?QVJSTWNPWlN6Q2ZIZFEyalliU1JzUlF3czNlRzBHNE5pSjhlWlhoamNLbTdC?= =?utf-8?B?dUtCMUljSEs5bjZxclNCNnZxZWFGMEwzNUtHYXUvajkzSHZMaG1DUXFyNUdm?= =?utf-8?B?Ymc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 43942198-d542-4b79-3d0d-08dac8ac7d81 X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB0062.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 15:00:39.5023 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AP2Ehn4k/4kL/3CPvoXlWgloRbeadzh15pC8TFaNBgdHY71Ca1EcUFB8EFLXe+QcabkmROS9ryriDD3sEH/Mt1dm47yLPKKwsOc3R8jBihk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5978 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/17/2022 6:25 PM, Hanumanth Pothula wrote: > Validate ethdev parameter 'max_rx_mempools' to know wheater device > supports multi-mempool feature or not. Spell check: whether > Bugzilla ID: 1128 > > Signed-off-by: Hanumanth Pothula Tested-by: Aman Singh > v2: > - Rebased on tip of next-net/main > --- > app/test-pmd/testpmd.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c > index 4e25f77c6a..fd634bd5e6 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -2655,16 +2655,22 @@ rx_queue_setup(uint16_t port_id, uint16_t rx_queue_id, > union rte_eth_rxseg rx_useg[MAX_SEGS_BUFFER_SPLIT] = {}; > struct rte_mempool *rx_mempool[MAX_MEMPOOL] = {}; > struct rte_mempool *mpx; > + struct rte_eth_dev_info dev_info; > unsigned int i, mp_n; > uint32_t prev_hdrs = 0; > int ret; > > + ret = rte_eth_dev_info_get(port_id, &dev_info); > + if (ret != 0) > + return ret; > + > /* Verify Rx queue configuration is single pool and segment or > * multiple pool/segment. > + * @see rte_eth_dev_info::max_rx_mempools > * @see rte_eth_rxconf::rx_mempools > * @see rte_eth_rxconf::rx_seg > */ > - if (!(mbuf_data_size_n > 1) && !(rx_pkt_nb_segs > 1 || > + if (!(dev_info.max_rx_mempools != 0) && !(rx_pkt_nb_segs > 1 || Can we make the check simpler "(dev_info.max_rx_mempools == 0)" > ((rx_conf->offloads & RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT) != 0))) { > /* Single pool/segment configuration */ > rx_conf->rx_seg = NULL;