From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B22F7A0547; Thu, 29 Apr 2021 15:38:56 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 73DAD410DD; Thu, 29 Apr 2021 15:38:56 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 12BB8406FF for ; Thu, 29 Apr 2021 15:38:53 +0200 (CEST) IronPort-SDR: 8Czqwci7RENvj0Xj2qxM63rm0z1jmdTkn+97s0qpZLZvY9V13H5BpQocUAmK8/p37GBeY1UEuA Vt0xXSZM5w2A== X-IronPort-AV: E=McAfee;i="6200,9189,9969"; a="176490367" X-IronPort-AV: E=Sophos;i="5.82,259,1613462400"; d="scan'208";a="176490367" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2021 06:37:41 -0700 IronPort-SDR: ybe1TAoq7jUVBTUSEDvCOW99YHZAQYxuNS0aD3mm7fGjb1C7l9qqOm8dqibYquqak4MzAiNbYO EtwWAxWDRh5g== X-IronPort-AV: E=Sophos;i="5.82,259,1613462400"; d="scan'208";a="526944303" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.208.65]) ([10.213.208.65]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2021 06:37:40 -0700 To: "Min Hu (Connor)" , dev@dpdk.org References: <1619063789-60922-3-git-send-email-humin29@huawei.com> <1619489325-31820-1-git-send-email-humin29@huawei.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <73ef50da-89b4-53c6-2130-1e7f8793680a@intel.com> Date: Thu, 29 Apr 2021 14:37:39 +0100 MIME-Version: 1.0 In-Reply-To: <1619489325-31820-1-git-send-email-humin29@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] net/kni: fix rewritten return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/27/2021 3:08 AM, Min Hu (Connor) wrote: > Return value of function 'eth_kni_dev_stop' passed to 'ret' is > rewritten later, and this is unreasonable. > > This patch fixes it. > > Fixes: 62024eb82756 ("ethdev: change stop operation callback to return int") > Cc: stable@dpdk.org > > Signed-off-by: Min Hu (Connor) Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.