From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 26DAD43AB3; Fri, 9 Feb 2024 16:20:35 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CE7E342E64; Fri, 9 Feb 2024 16:20:34 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) by mails.dpdk.org (Postfix) with ESMTP id 3ABDF40697 for ; Fri, 9 Feb 2024 16:20:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1707492033; x=1739028033; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=q7LiiijW8qFc4pQISiJt8lNE+th70i+QXbPvfdp7OB0=; b=O1d+Xbz7BeXQia6hqBxZL/RhOk/XAC9b95KtCa4kVQqXAoqqkWGSYf3t d7iqXTQzHMsnNEVcxT7a1U6KUFUmNt5Ote8XD8T0GZ3ifVBuakpzFJyes VxYpuU0SdtCZc//LIpO+1jGwd52CA6IvZIEwaRrCJAtTvk/vHNISNIJ50 ge68dBETF+jMNYhtx1a+VkekX3IHvWcfJYAGacSGGZVosh5aPD0+1pWxI EL3lZfmVeS9FgqRaTL3xv+HxUIbT4Ue074Pb+5TeDjOFrvNeGI1G/InUT gBcRSaVyAMV7tWb9LMwWWXuEGVR3RWYDBwil54T0hEywdwh3sSFW66TVl Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10979"; a="1337065" X-IronPort-AV: E=Sophos;i="6.05,257,1701158400"; d="scan'208";a="1337065" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Feb 2024 07:20:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,257,1701158400"; d="scan'208";a="2298008" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orviesa006.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 09 Feb 2024 07:20:32 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 9 Feb 2024 07:20:31 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 9 Feb 2024 07:20:30 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Fri, 9 Feb 2024 07:20:30 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 9 Feb 2024 07:20:30 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eEnuvHgqRl9kJASVbLUB8UWtO6eV/FqpRlD2ioo22XF7YdPqydug6Quh+6ldu5Wuukk2kPSniDHMe6jvHlJWw6LgUYpb+fYN7DOWUoybR9YYzfMHfemYnOrJK37CX/8lUjoZGWjI5207OH6+Iy6xUMs/8Vaw9VVBFRPlsVyo+oDnfFvLvedKW4rU+Roioi8+gh0DhT+AKz+vTlwZyJlWj6WbKWoru1wof2LQfkntnC6o0pOV/LnSbqTaGm0eryxxs5nCiYuFwWTF+520HQcOFCG03uagvY8ZGvsxIv+DFbOje2tFSBDzLL/LYMwOpkv1TyMXzhmPwyRpIwP3FMs3VA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/aLQD7fs/AbUIpcIujv3z6ALTU6dgwkFNWaXDzEjVv0=; b=H5DrglJZQ42EmdM/4pckrrf+PfhGX6SfzmX+7uWFB1BqowbQfmSlXfOPCXE0dRHo1sINHbc46001/kPMU11GVqPq3kwQ4/DYYgNDT9nZNW8uDQr81Qr1VZb+iVJEhy8J4RRktb/SqcHAmfGYZW6XtJXUPqkTHx2rqOiHdh32ba6YCd6SzZ1Vndwr2VIydLuL2ZZzLNLgXYGzk+NCgH7JwTzW+sckL9pwdU/ll+rBBtDdFL6hVH2Ho2j2p8WZC7HAe/p0SGwQ2rC5RgxdxNfHiJMPcGD+ar7mrQxmqHtkPgQiCUv7r3g4sfaNNFX08dDaEUPhyZt3TMsRSLJvPQuSoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH7PR11MB6498.namprd11.prod.outlook.com (2603:10b6:510:1f1::21) by SA2PR11MB4940.namprd11.prod.outlook.com (2603:10b6:806:fa::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.27; Fri, 9 Feb 2024 15:20:28 +0000 Received: from PH7PR11MB6498.namprd11.prod.outlook.com ([fe80::60f:d984:1a35:2085]) by PH7PR11MB6498.namprd11.prod.outlook.com ([fe80::60f:d984:1a35:2085%4]) with mapi id 15.20.7249.035; Fri, 9 Feb 2024 15:20:28 +0000 Message-ID: <73f8322b-d5c2-43f6-bfe4-a192de31ebcf@intel.com> Date: Fri, 9 Feb 2024 16:20:21 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v11] net/iavf: add diagnostic support in TX path Content-Language: en-US To: Mingjin Ye , CC: , Yuying Zhang , "Beilei Xing" , Wenjun Wu , Simei Su , Jingjing Wu References: <20240105095830.2402403-1-mingjinx.ye@intel.com> <20240110022555.3084426-1-mingjinx.ye@intel.com> From: "Burakov, Anatoly" In-Reply-To: <20240110022555.3084426-1-mingjinx.ye@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0433.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a9::6) To PH7PR11MB6498.namprd11.prod.outlook.com (2603:10b6:510:1f1::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH7PR11MB6498:EE_|SA2PR11MB4940:EE_ X-MS-Office365-Filtering-Correlation-Id: 73f5a49c-bb0c-4671-ecfd-08dc2982a547 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RBsyNItUxShcpl+fjz9z9mP+Hu0mpy9tVK/JR+5CUb6wtb1gdWeUZCu3VPHm8kDaM+cqq/53+JQNzMmG0ubkBnq+fM48iLqQE049RGmNFSxh4D2NUU5/OtOkDymzLnzjzZ2nveKpGBIaME2KAbaPuE/kPha2O0ewyVVD1BSRrd3cLu7CLzjzc3ppkf0Nv5jd5h75HLdam5gWTGcC341k/b1jwuWpgFz9u1zLGK/KbPYm1babwhxOyXc1Yd654DQLapjHZsArhODvrcwwpi3uMERmCZwEa5er2z5AKeres3BbJJqzbL0bqNcXdBDnJ3IzY1X1Zybr/FfDqa1teFRIZUBtDIkNvUpuo3+hlKnNF4HZ6hlqzCe3NhE/OYn2xjFn+uHu/B04foZBQ7mAqnqqCMls1PoyZoBk/IPkQ5avXuXLLJLI8rpEdUKwAdPPyeKA/2e+zsMSoCLw9//XNPlv9/H1b0ZeWKQ5MslI7hquv8pAR3TQoacaD9JljDKyUR67yQZHbc+gcs4fRb53XB41we+kAUuLLF1DZ1/ClnFb9x+pcDpN4x70Oo+TlNFayNPc X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH7PR11MB6498.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(136003)(39860400002)(376002)(346002)(366004)(230922051799003)(64100799003)(451199024)(1800799012)(186009)(53546011)(2616005)(6506007)(478600001)(6512007)(6486002)(41300700001)(31686004)(2906002)(5660300002)(66556008)(4326008)(66946007)(8676002)(8936002)(66476007)(54906003)(316002)(6666004)(26005)(107886003)(83380400001)(38100700002)(36756003)(31696002)(86362001)(82960400001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?akM2Sm5ncFBpVGpydWc1dDBiYis3QkxRUjV1czRmNGNKL3NkMG1WdGtCNXk3?= =?utf-8?B?YVFoSHBzT3paZmtXMDg2VlZFa3dkdGdNbUFLTXFZTzRtMVdHTUorclE2MUYx?= =?utf-8?B?VzF4d2RnN1RJOUtpU2h5b01SLzFicVJ6YVJrbGo4OGoxNk84WVpCZjk2ckpJ?= =?utf-8?B?blJ1cXQ2MGQwckxqQThsejVLVXR1UUNDS0ZGc1lZTFRZdDVvNG9Cc21kV2Zz?= =?utf-8?B?UGk3TEhlb3FCYUtVQ082VjNVZHo2UDlkbzNvT204OUlkUjEzaWdHMXQyQzEv?= =?utf-8?B?RmUyUy8wOVIzU0Q1MEltR0s1b1F1a1B4K29QdkR4NzAvSVJIWHA3Q2l0S1dp?= =?utf-8?B?WmtPVkorWmtTWWZuUFcxVTUzdU9GcW9Kdml0VUdVQjlqb2tYM2lrZ0pmSzAw?= =?utf-8?B?Nzg5Um10MDBRTzFVYmlqZklmUlljblczdUJTV1Y2ZlRpaDlOaERjVW1HQlFX?= =?utf-8?B?N0EweXVubFJla0ZzMnBySERENUJhMVVScUZEd0NJZWx0OHRGYTlSWHlsWUQr?= =?utf-8?B?MmwwcC82ZjR6dnVaUStleUZnWmJmbGRNemY3blBxY1U0RVZoNWNRaGYxUXpT?= =?utf-8?B?UWRzWitwTnloRitobjgzNmRKQ0FyY2FvT0JKUHdPV2Zna05vOXFPWWJoVkRj?= =?utf-8?B?eDF4VkIzR3p4RlBQcE9JZ3ZReHc1OFRCV2NKVmVud05MbXhLY245RnlUY0Zj?= =?utf-8?B?OEVHZFpSTEVXdGVLWjU0OU5qK1JTQUQxMzJoQ0NEL0xDVWMvUUErdnRYbnRi?= =?utf-8?B?dTIwd0RmSTNRUEZJNlNyQVd0RE05RTc2dGZNS1lsaE5lUTYyb3Z4dnBqUkUz?= =?utf-8?B?RHNBRnZ6R2J1RWNCVW92cWdwejZmbnUzdkRCS0R6ZlpRWHduWnVjdVRLOGU4?= =?utf-8?B?N2NCU1dlTFdIS2pnQUZFOC82bEtuWitqbzNhRUNSbENNVFlHVE1ZQkJqNVZu?= =?utf-8?B?eVRidkZSNGt3bXMwellEUU1TQ05rUVdLUDJrRTBHeGJ4SmhPMVhXMkhjaklk?= =?utf-8?B?WUQzQzZwOEp5MTdvaGNLOVh2T2hibUJzTVdFL2hNQXlzYjNCS3FKUGxlU1Bt?= =?utf-8?B?RkVoNjdrRDdhNWUrQU44VXI0VlJDTDhMZkRXSCtYbFVnZ1BFcHZUMHBicUFi?= =?utf-8?B?akdReitmK25XNWVKQ1NTclE0T0xnVCtWQ1phMlFmTnNzdlR2NElib0h2T1V4?= =?utf-8?B?UStjL2piOElEVlpFcnF5djM2dzdmd0xkbmZIYzV0L2UzWTE1WjhtbVpQVi9G?= =?utf-8?B?YXFubjBRMVpRMUVYNlcwWWRiSHhDTUdoMm40MzNuSEZlaDluUFZpd0hOcGVs?= =?utf-8?B?UExDeEYxODJwMVVVN2NadEJSc1VFdDM3UVdlWDhrdTQ2NUZ0dG9aSjhmR0tx?= =?utf-8?B?OThkb0tMbW82ZmkrRUM5ZEZpSGZWd3lSaERJTW80dTRWNys1dXVHQ2NsU1pF?= =?utf-8?B?ZktjVVdpZ2dDZ00xNEVTaEhMVVhQZWlLM1R2Q1NPanl4ejJZcGk4RGQ1SHF5?= =?utf-8?B?S3NFbVZPNGVuSFAxWWQ4MU1JQjhVaEFiOVhuKzE0bXkyY0ZRYmhSbmUwbE5G?= =?utf-8?B?SSszV1AvMXVEdXhQQVdDa05SNnNYVCtLL1U3SEhibDhQZmU4N05HTTdMZVls?= =?utf-8?B?MllxdTZscU0ydFlnM05DZzNOeWZ5bnV2TGI3MXhkYk5CMDkwdGhVLzIwWjdO?= =?utf-8?B?d1BMZ3hhWE1Obkg1TVhkQkIrY1VWSm8xWVdCb1g2dWFBNHlXSnlOb0svVzdN?= =?utf-8?B?aDZSRVFIL0cycUFCTktiRkV5SEdyVWQxQ3JSdGJwUnhHeUtqYkxKTEE1eHZN?= =?utf-8?B?WlFiNENOS1JCVFlOV1R0d1JUMHFkZ0tTZ0lVQXowd2tpakc1Ry9TSWdIMWdR?= =?utf-8?B?UnJKOFRwYy9FZHlaYUtWbmNwbEd4eUN2SzA0aEZlR3pyOXFaRExJVHJiUGV6?= =?utf-8?B?bHUrMzJaZ3ozQWxGWWZDU2ExVnJPVnVpK3lGK1ZCaDlUSXF3aVBzU1VvdXI3?= =?utf-8?B?UkpqVnhmUisvTkVxb2xHWmNRUTBsSC9kQmVJQkd3cTZ2akZRcXNkQzhzSVZO?= =?utf-8?B?cWZIdmV4akFGaVM4QzBkMTQzZUxjUzlDY3RRSUlGNTNnT1NpL1FiMnhPWk15?= =?utf-8?B?VFNJZ1BuNTQ3MjVxT3U5cFNRd2pUMEVheFJlVmI0SjFZWGpad3RXeGJ1Mjhy?= =?utf-8?B?TUE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 73f5a49c-bb0c-4671-ecfd-08dc2982a547 X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB6498.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2024 15:20:27.8578 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Qmo/wthnrrewrI8ELs9gkpnN2O2pA7FGtWd8lIw+6f6SErTPVkuDl5ubvx5TStnbQ5FSISHRP+P0ph2u9UyHZiGehKkuhFTtWbW66agHm3s= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4940 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/10/2024 3:25 AM, Mingjin Ye wrote: > Implemented a Tx wrapper to perform a thorough check on mbufs, > categorizing and counting invalid cases by types for diagnostic > purposes. The count of invalid cases is accessible through xstats_get. > > Also, the devarg option "mbuf_check" was introduced to configure the > diagnostic parameters to enable the appropriate diagnostic features. > > supported cases: mbuf, size, segment, offload. > 1. mbuf: check for corrupted mbuf. > 2. size: check min/max packet length according to hw spec. > 3. segment: check number of mbuf segments not exceed hw limitation. > 4. offload: check any unsupported offload flag. > > parameter format: "mbuf_check=" or "mbuf_check=[,]" > eg: dpdk-testpmd -a 0000:81:01.0,mbuf_check=[mbuf,size] -- -i > > Signed-off-by: Mingjin Ye > --- > v2: Remove call chain. > --- > v3: Optimisation implementation. > --- > v4: Fix Windows os compilation error. > --- > v5: Split Patch. > --- > v6: remove strict. > --- > v9: Modify the description document. > --- > v10: Modify vf rst document. > --- > v11: modify comment log. > --- Acked-by: Anatoly Burakov -- Thanks, Anatoly