From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 590D41B472 for ; Tue, 9 Oct 2018 14:49:53 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Oct 2018 05:49:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,360,1534834800"; d="scan'208";a="93586348" Received: from rhorton-mobl1.ger.corp.intel.com (HELO [163.33.179.30]) ([163.33.179.30]) by fmsmga002.fm.intel.com with ESMTP; 09 Oct 2018 05:38:02 -0700 To: Thomas Monjalon , dev@dpdk.org References: <20181009021858.19216-1-thomas@monjalon.net> <20181009021858.19216-4-thomas@monjalon.net> Cc: gaetan.rivet@6wind.com, ophirmu@mellanox.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, olivier.matz@6wind.com From: Remy Horton Organization: Intel Shannon Limited Message-ID: <73ffc68e-0a1f-de2a-790e-6bd4941fddef@intel.com> Date: Tue, 9 Oct 2018 13:38:01 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <20181009021858.19216-4-thomas@monjalon.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 3/4] ethdev: move representor parsing functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Oct 2018 12:49:53 -0000 On 09/10/2018 03:18, Thomas Monjalon wrote: > The functions for representor devargs parsing were static > in the file rte_ethdev.c. > In order to reuse them in the file rte_class_eth.c, > they are moved to the files ethdev_private.c/.h. > > Signed-off-by: Thomas Monjalon There is overlap between these functions and some of the rte_kvargs_*() functions. Is it feasible/desirable to combine them? ..Remy