From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 792A944C3 for ; Mon, 29 Apr 2019 11:52:15 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 20FC189D; Mon, 29 Apr 2019 05:52:14 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 29 Apr 2019 05:52:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=rjeX8j8UwXmS5SPk6uCAiJsVduab0Pd6EsCzCK66a4I=; b=XrYYAUWSsYOV Uj/9tcwPqVBJ5jleY81dcQA/9hh8ZPwv11uSEluQIFMYDgSsrqvjEn2BDmc3IqrG rd5PFVbuAsGq3HnJLdijzkgwiB9x0TgJVBUegqb9qSNJPYorGF/N0TTLQakqVpPc VTUjB5hqZnkj9blFTx0mUJdhhxFrsHs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=rjeX8j8UwXmS5SPk6uCAiJsVduab0Pd6EsCzCK66a 4I=; b=o2C1d4o9aY7zf3xl2iLX9OiGLtvg7BkeA61b/iw3dSEDoF0IxG7fDo0Gr ssZMMGV4w+YjlWFKKs4zt79d9CEa2eiJUc2Mvx+hoF7dvR0O/dEYXOxux0WBKNIo 9sH6Q8mBsCny60ob3sgw3VIY0CYBvklG+CI8pZ3XuL07PK9ZBdmG2Q4rztHQHzoM 0ab0IED9+ehZV/W5tnL3NSIRu2WXRMfasGId/FtpcM1zo0MdJ4ZRjMiZt5TdgRZa jFiOo8MmbRZg1SMeYbT/pHQiIzXICGaozh8aVb5itAsHsJ9S6tKX+wcfiGD3LKZV 9ffCzMmSrttFOyLio2V3d5RWH75MA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddriedvgddvudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 46573103CC; Mon, 29 Apr 2019 05:52:12 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org, Wenzhuo Lu , Jingjing Wu , Bernard Iremonger , Andrew Rybchenko , WenjieX A Li Date: Mon, 29 Apr 2019 11:52:11 +0200 Message-ID: <7401294.VrTtjXMbYf@xps> In-Reply-To: <8bed3a94-6ef2-10d8-1dad-e5743d4725b6@intel.com> References: <20190424220309.84270-1-ferruh.yigit@intel.com> <1838455.hGyFdCOQE1@xps> <8bed3a94-6ef2-10d8-1dad-e5743d4725b6@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] Revert "app/testpmd: set fixed flag for exact link speed" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Apr 2019 09:52:15 -0000 25/04/2019 17:27, Ferruh Yigit: > On 4/25/2019 2:29 PM, Thomas Monjalon wrote: > > 25/04/2019 13:47, Ferruh Yigit: > >> On 4/25/2019 9:19 AM, Thomas Monjalon wrote: > >>> 25/04/2019 00:03, Ferruh Yigit: > >>>> This reverts commit bdca79053b6aea504d02691d9319fa976062457f. > >>>> > >>>> Not all PMDs support the fixed link speed set, and link speed can be set > >>>> even with auto negotiation enabled. Reverting the patch to not break > >>>> existing usage. > >>> > >>> Which PMDs do not support this flag? > >>> Why not fixing the PMDs? > >>> > >> > >> At least ixgbe and i40e is not supporting setting a fixed speed. > >> But I am not sure if this is something to fix, the command in testpmd is to set > >> the link speed, what is the problem with setting the link speed without > >> disabling the auto-negotiation? > > > > It means it will negotiate with only one speed proposed. > > Yes. > > > The real issue is to not support the fixed flag. > > I don't know if this is a real issue but > even it is, is it an issue in the scope of this testpmd command? > > right now we are first updating the command to set fixed speed flag, and > requesting PMDs to fix for it, I am suggesting not to update the command at all. I understand. But this change shows a broken behaviour. This is the intent of testpmd to show what works or not in PMDs. How hard is it to fix the PMDs in your opinion? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 48984A0679 for ; Mon, 29 Apr 2019 11:52:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C372B1B142; Mon, 29 Apr 2019 11:52:16 +0200 (CEST) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 792A944C3 for ; Mon, 29 Apr 2019 11:52:15 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 20FC189D; Mon, 29 Apr 2019 05:52:14 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 29 Apr 2019 05:52:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=rjeX8j8UwXmS5SPk6uCAiJsVduab0Pd6EsCzCK66a4I=; b=XrYYAUWSsYOV Uj/9tcwPqVBJ5jleY81dcQA/9hh8ZPwv11uSEluQIFMYDgSsrqvjEn2BDmc3IqrG rd5PFVbuAsGq3HnJLdijzkgwiB9x0TgJVBUegqb9qSNJPYorGF/N0TTLQakqVpPc VTUjB5hqZnkj9blFTx0mUJdhhxFrsHs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=rjeX8j8UwXmS5SPk6uCAiJsVduab0Pd6EsCzCK66a 4I=; b=o2C1d4o9aY7zf3xl2iLX9OiGLtvg7BkeA61b/iw3dSEDoF0IxG7fDo0Gr ssZMMGV4w+YjlWFKKs4zt79d9CEa2eiJUc2Mvx+hoF7dvR0O/dEYXOxux0WBKNIo 9sH6Q8mBsCny60ob3sgw3VIY0CYBvklG+CI8pZ3XuL07PK9ZBdmG2Q4rztHQHzoM 0ab0IED9+ehZV/W5tnL3NSIRu2WXRMfasGId/FtpcM1zo0MdJ4ZRjMiZt5TdgRZa jFiOo8MmbRZg1SMeYbT/pHQiIzXICGaozh8aVb5itAsHsJ9S6tKX+wcfiGD3LKZV 9ffCzMmSrttFOyLio2V3d5RWH75MA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddriedvgddvudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 46573103CC; Mon, 29 Apr 2019 05:52:12 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org, Wenzhuo Lu , Jingjing Wu , Bernard Iremonger , Andrew Rybchenko , WenjieX A Li Date: Mon, 29 Apr 2019 11:52:11 +0200 Message-ID: <7401294.VrTtjXMbYf@xps> In-Reply-To: <8bed3a94-6ef2-10d8-1dad-e5743d4725b6@intel.com> References: <20190424220309.84270-1-ferruh.yigit@intel.com> <1838455.hGyFdCOQE1@xps> <8bed3a94-6ef2-10d8-1dad-e5743d4725b6@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] Revert "app/testpmd: set fixed flag for exact link speed" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190429095211.TYq3xmAykOTSqSEhCdmn-s43crPxuagJS0UIodWEimU@z> 25/04/2019 17:27, Ferruh Yigit: > On 4/25/2019 2:29 PM, Thomas Monjalon wrote: > > 25/04/2019 13:47, Ferruh Yigit: > >> On 4/25/2019 9:19 AM, Thomas Monjalon wrote: > >>> 25/04/2019 00:03, Ferruh Yigit: > >>>> This reverts commit bdca79053b6aea504d02691d9319fa976062457f. > >>>> > >>>> Not all PMDs support the fixed link speed set, and link speed can be set > >>>> even with auto negotiation enabled. Reverting the patch to not break > >>>> existing usage. > >>> > >>> Which PMDs do not support this flag? > >>> Why not fixing the PMDs? > >>> > >> > >> At least ixgbe and i40e is not supporting setting a fixed speed. > >> But I am not sure if this is something to fix, the command in testpmd is to set > >> the link speed, what is the problem with setting the link speed without > >> disabling the auto-negotiation? > > > > It means it will negotiate with only one speed proposed. > > Yes. > > > The real issue is to not support the fixed flag. > > I don't know if this is a real issue but > even it is, is it an issue in the scope of this testpmd command? > > right now we are first updating the command to set fixed speed flag, and > requesting PMDs to fix for it, I am suggesting not to update the command at all. I understand. But this change shows a broken behaviour. This is the intent of testpmd to show what works or not in PMDs. How hard is it to fix the PMDs in your opinion?