From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42])
 by dpdk.org (Postfix) with ESMTP id 13E412BC9
 for <dev@dpdk.org>; Wed,  9 Mar 2016 11:38:29 +0100 (CET)
Received: by mail-wm0-f42.google.com with SMTP id p65so186192137wmp.1
 for <dev@dpdk.org>; Wed, 09 Mar 2016 02:38:29 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:organization:user-agent
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=NqWZ8D2ozov2YkJumuKv3icIy0yTMz39UY43uCazHxk=;
 b=O/wWgTAVYrr3seWfM9sRbiFrwXgq2j41axED5+yEmUnkgnt9TzTwBEk0GmBC4Ly0Q1
 Ke6qk/MjxLM6P4XJjtBXy1t++jX6nsos2/f6lEqhnFeJH1rWEqJQkGMDnFAnU3DpT4sr
 8mSDK7MDz/KIAL/F3f9OLpXqy3aVK77Std872skBTxd7OtHsiwP784mcswNmbJIrSwFv
 DiLtejLZh8YWIB1hF/mPFBuFpu52cp/FPDY/1IMbk5DezBfOBR3UA/hWVpQC1SL1ZDGC
 p1rg3ma6pR11I0to8xdRCVehVXCbeaBl0cWACBUqiuH/KkWIBHMbo8QyiiKLsWmqjuEz
 YbYg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding;
 bh=NqWZ8D2ozov2YkJumuKv3icIy0yTMz39UY43uCazHxk=;
 b=gvZcN4SfWaoI646Gfz7KDaqX/9xkkRUjrTqh2CkiKiiUzBwvVBKZGtX3BbsNQ9UL7h
 xxTDIz/47tgzhfHAUHo3+dIPVcGvXzCuCfMevurIq+9xi/TsRJlNtDBuv2Pp2lvXy/yu
 m1UpjrGgjDuXo5dSdVNfVuk0HhPCUThftkuwSYbdd4saIjahMl6vUoIiE73je60bL4rf
 XD9t8ojP43IltZiic15Y4ojWUw97lV5WoRh/NEDX62irH8clTC1rdLkchH9Gjd1oQhDL
 R7GsnUGbdc4ZHU7t57yrJsArqK6noW1uoWZMxHxKxDO/CHDACsX79eEoXCFZ/DPYIj8G
 aRvw==
X-Gm-Message-State: AD7BkJJrkCCXsxOhCKQqY8YmiXnxRN5Ms1M8UXDzepWHTp4jKzmLcnza2Aw8AAnF7Xo8e6XO
X-Received: by 10.28.183.84 with SMTP id h81mr13223532wmf.100.1457519908877;
 Wed, 09 Mar 2016 02:38:28 -0800 (PST)
Received: from xps13.localnet (171.36.101.84.rev.sfr.net. [84.101.36.171])
 by smtp.gmail.com with ESMTPSA id ls5sm7219341wjb.33.2016.03.09.02.38.27
 (version=TLSv1/SSLv3 cipher=OTHER);
 Wed, 09 Mar 2016 02:38:28 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Wu, Jingjing" <jingjing.wu@intel.com>
Date: Wed, 09 Mar 2016 11:36:49 +0100
Message-ID: <7414420.bicRBi3CqG@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <9BB6961774997848B5B42BEC655768F8DD16C1@SHSMSX104.ccr.corp.intel.com>
References: <1456918207-31696-1-git-send-email-jingjing.wu@intel.com>
 <1518710.DqorvmVtZj@xps13>
 <9BB6961774997848B5B42BEC655768F8DD16C1@SHSMSX104.ccr.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3 01/12] ethdev: extend flow director for
	input selection
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 09 Mar 2016 10:38:29 -0000

2016-03-09 10:26, Wu, Jingjing:
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > 2016-03-09 13:42, Jingjing Wu:
> > >  struct rte_eth_ipv4_flow {
> > >  	uint32_t src_ip;      /**< IPv4 source address to match. */
> > >  	uint32_t dst_ip;      /**< IPv4 destination address to match. */
> > > +	uint8_t  tos;         /**< Type of service to match. */
> > > +	uint8_t  ttl;         /**< Time to live */
> > > +	uint8_t  proto;
> > 
> > L4 protocol?
> > 
> > >  };
> > >
> > >  /**
> > > @@ -443,6 +448,9 @@ struct rte_eth_sctpv4_flow {  struct
> > > rte_eth_ipv6_flow {
> > >  	uint32_t src_ip[4];      /**< IPv6 source address to match. */
> > >  	uint32_t dst_ip[4];      /**< IPv6 destination address to match. */
> > > +	uint8_t  tc;             /**< Traffic class to match. */
> > > +	uint8_t  proto;          /**< Protocol, next header. */
> > > +	uint8_t  hop_limits;
> > >  };
> > 
> > Why some fields are not commented?
> > I guess the values must be the ones found in the IPv4 header.
> 
> Yes, you are correct. The fields defined in rte_eth_ipvx_flow are the ones in IP header.
> Should I comments all of them?

Please, do I really need to confirm that the API must be clearly documented?