DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "Hunt, David" <david.hunt@intel.com>
Cc: dev@dpdk.org, "shreyansh.jain@nxp.com" <shreyansh.jain@nxp.com>
Subject: Re: [dpdk-dev] [PATCH v3 1/3] mk: add sensible default target with defconfig
Date: Fri, 04 Aug 2017 12:05:48 +0200	[thread overview]
Message-ID: <7428277.FEDDLdAvNx@xps> (raw)
In-Reply-To: <6606996c-f7b1-439f-aa73-8aeaa585f062@intel.com>

04/08/2017 11:53, Hunt, David:
> 
> On 4/8/2017 10:36 AM, Thomas Monjalon wrote:
> > 04/08/2017 10:22, Hunt, David:
> >> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> >> 07/06/2017 16:37, David Hunt:
> >>> Users can now use 'make defconfig' to generate a configuration using
> >>> the most appropriate defaults for the current machine.
> >>>
> >>> <arch-machine-execenv-toolchain>
> >>>    arch taken from uname -m
> >>>    machine defaults to native
> >>>    execenv is taken from uname, Linux=linuxapp, otherwise bsdapp
> >>>    toolchain is taken from $CC -v to see which compiler to use
> >>>
> >>> Signed-off-by: David Hunt <david.hunt@intel.com>
> >>> Acked-by: Shreyansh Jain <shreyansh.jain@nxp.com>
> >> Looks to be a good idea if it is really automatic.
> >>
> >>> +                ${CC} -v 2>&1 | \
> >>> +                grep " version " | cut -d ' ' -f 1)
> >> Unfortunately, it depends on $CC which is not commonly exported.
> >> What about defaulting to gcc?
> >>
> >>> -	@echo "Configuration done"
> >>> +	@echo "Configuration done using "$(shell basename \
> >>> +		$(RTE_CONFIG_TEMPLATE) | sed "s/defconfig_//g")
> >> RTE_CONFIG_TEMPLATE is not defined in this patch (and I do not see the benefit in next patch).
> >>
> >> Thomas,
> >>       Does this mean that this patch is not going into this release? It has been acked for almost a month now, with no further comment. The one hour between your comment and the release of RC4 did not give me a reasonable amount of time to address your concerns. I also feel that the lack of comments in the last month should mean that the patch should be applied as is. If changes are required, I am happy to address in the next release.
> > You're right, I'm very sorry not taking time to review it before.
> > I think only the first patch should be integrated, without the comment for
> > RTE_CONFIG_TEMPLATE.
> > Opinion?
> 
> OK, I would be OK with the first patch. However, I think the 
> RTE_CONFIG_TEMPLATE comment part of the patch is fine, we just tested it 
> here. It's only RTE_TEMPLATE I'm introducing in the second patch, nor 
> RTE_CONFIG_TEMPLATE. That existed before this patch set. So the echo 
> command in the first patch works fine, and shows the user what template 
> the script has used to configure itself.

Ah OK I totally missed it :)

> I could upload another patch with just the first patch (and the relevant 
> 2 lines from the docs patch) as a v4?

Yes perfect

  reply	other threads:[~2017-08-04 10:05 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-23 10:28 [dpdk-dev] mk: make config enhancements David Hunt
2017-05-23 10:28 ` [dpdk-dev] [PATCH v1 1/2] mk: allow use of environment var for make config David Hunt
2017-05-23 10:28 ` [dpdk-dev] [PATCH v1 2/2] mk: add sensible default target with defconfig David Hunt
2017-05-24  6:10   ` Shreyansh Jain
2017-05-25 13:04     ` Hunt, David
2017-05-25 13:19       ` Shreyansh Jain
2017-05-26  8:52   ` [dpdk-dev] [PATCH v2 0/2] mk: make config enhancements David Hunt
2017-05-26  8:52     ` [dpdk-dev] [PATCH v2 1/2] mk: allow use of environment var for make config David Hunt
2017-06-07  8:39       ` Hunt, David
2017-06-07  9:36         ` Shreyansh Jain
2017-06-07 10:28           ` Hunt, David
2017-06-07 11:46             ` Shreyansh Jain
2017-06-07 12:07               ` Bruce Richardson
2017-06-07 14:37       ` [dpdk-dev] [PATCH v3 0/3] mk: make config enhancements David Hunt
2017-06-07 14:37         ` [dpdk-dev] [PATCH v3 1/3] mk: add sensible default target with defconfig David Hunt
2017-06-12  8:36           ` Jerin Jacob
2017-08-03 22:39           ` Thomas Monjalon
2017-08-04  8:22             ` Hunt, David
2017-08-04  9:36               ` Thomas Monjalon
2017-08-04  9:53                 ` Hunt, David
2017-08-04 10:05                   ` Thomas Monjalon [this message]
2017-08-04 10:42                     ` Hunt, David
2017-08-04 10:28           ` [dpdk-dev] [PATCH v4] " David Hunt
2017-08-04 10:39             ` [dpdk-dev] [PATCH v5] " David Hunt
2017-08-05  8:24               ` Thomas Monjalon
2017-06-07 14:37         ` [dpdk-dev] [PATCH v3 2/3] mk: allow use of environment var for template David Hunt
2017-06-12  8:37           ` Jerin Jacob
2017-08-03 22:42           ` Thomas Monjalon
2017-06-07 14:37         ` [dpdk-dev] [PATCH v3 3/3] doc: update build-sdk-quick txt file David Hunt
2017-06-12 12:50           ` Mcnamara, John
2018-02-13 12:18             ` Ferruh Yigit
2018-02-13 23:41               ` Thomas Monjalon
2018-04-11  8:44                 ` Hunt, David
2018-04-11  8:49                   ` Thomas Monjalon
2017-05-26  8:52     ` [dpdk-dev] [PATCH v2 2/2] mk: add sensible default target with defconfig David Hunt
2017-05-29  7:31     ` [dpdk-dev] [PATCH v2 0/2] mk: make config enhancements Shreyansh Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7428277.FEDDLdAvNx@xps \
    --to=thomas@monjalon.net \
    --cc=david.hunt@intel.com \
    --cc=dev@dpdk.org \
    --cc=shreyansh.jain@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).