From: "Polehn, Mike A" <mike.a.polehn@intel.com>
To: "dev@dpdk.org" <dev@dpdk.org>
Subject: [dpdk-dev] [Patch] Eth Driver: Optimization for improved NIC processing rates
Date: Tue, 27 Oct 2015 20:56:31 +0000 [thread overview]
Message-ID: <745DB4B8861F8E4B9849C970520ABBF14974C1DF@ORSMSX102.amr.corp.intel.com> (raw)
Prefetch of interface access variables while calling into driver RX and TX subroutines.
For converging zero loss packet task tests, a small drop in latency for zero loss measurements
and small drop in lost packet counts for the lossy measurement points was observed,
indicating some savings of execution clock cycles.
Signed-off-by: Mike A. Polehn <mike.a.polehn@intel.com>
diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
index 8a8c82b..09f1069 100644
--- a/lib/librte_ether/rte_ethdev.h
+++ b/lib/librte_ether/rte_ethdev.h
@@ -2357,11 +2357,15 @@ rte_eth_rx_burst(uint8_t port_id, uint16_t queue_id,
struct rte_mbuf **rx_pkts, const uint16_t nb_pkts)
{
struct rte_eth_dev *dev;
+ void *rxq;
dev = &rte_eth_devices[port_id];
- int16_t nb_rx = (*dev->rx_pkt_burst)(dev->data->rx_queues[queue_id],
- rx_pkts, nb_pkts);
+ /* rxq is going to be immediately used, prefetch it */
+ rxq = dev->data->rx_queues[queue_id];
+ rte_prefetch0(rxq);
+
+ int16_t nb_rx = (*dev->rx_pkt_burst)(rxq, rx_pkts, nb_pkts);
#ifdef RTE_ETHDEV_RXTX_CALLBACKS
struct rte_eth_rxtx_callback *cb = dev->post_rx_burst_cbs[queue_id];
@@ -2499,6 +2503,7 @@ rte_eth_tx_burst(uint8_t port_id, uint16_t queue_id,
struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
{
struct rte_eth_dev *dev;
+ void *txq;
dev = &rte_eth_devices[port_id];
@@ -2514,7 +2519,11 @@ rte_eth_tx_burst(uint8_t port_id, uint16_t queue_id,
}
#endif
- return (*dev->tx_pkt_burst)(dev->data->tx_queues[queue_id], tx_pkts, nb_pkts);
+ /* txq is going to be immediately used, prefetch it */
+ txq = dev->data->tx_queues[queue_id];
+ rte_prefetch0(txq);
+
+ return (*dev->tx_pkt_burst)(txq, tx_pkts, nb_pkts);
}
#endif
next reply other threads:[~2015-10-27 20:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-27 20:56 Polehn, Mike A [this message]
2015-10-28 10:44 ` Bruce Richardson
2015-10-28 21:27 ` Polehn, Mike A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=745DB4B8861F8E4B9849C970520ABBF14974C1DF@ORSMSX102.amr.corp.intel.com \
--to=mike.a.polehn@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).