From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id B0D4A8D96 for ; Wed, 11 Nov 2015 14:56:26 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP; 11 Nov 2015 05:56:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,276,1444719600"; d="scan'208";a="598283751" Received: from orsmsx107.amr.corp.intel.com ([10.22.240.5]) by FMSMGA003.fm.intel.com with ESMTP; 11 Nov 2015 05:56:25 -0800 Received: from orsmsx102.amr.corp.intel.com ([169.254.1.190]) by ORSMSX107.amr.corp.intel.com ([169.254.1.197]) with mapi id 14.03.0248.002; Wed, 11 Nov 2015 05:56:24 -0800 From: "Polehn, Mike A" To: Stephen Hemminger Thread-Topic: [dpdk-dev] [PATCH v2] ethdev: Prefetch driver variable structure Thread-Index: AdEbwoCqRm8AWwtpTaSp5FTdLRCnIgAWjoyAABr4g6A= Date: Wed, 11 Nov 2015 13:56:24 +0000 Message-ID: <745DB4B8861F8E4B9849C970520ABBF14975C415@ORSMSX102.amr.corp.intel.com> References: <745DB4B8861F8E4B9849C970520ABBF14975BCC7@ORSMSX102.amr.corp.intel.com> <20151110090309.644517d5@xeon-e3> In-Reply-To: <20151110090309.644517d5@xeon-e3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsIiwiaWQiOiIwODQzNzI0YS1mNmNiLTQ5YzEtYTY4Yy0xZTZhNmFhNDFmMDUiLCJwcm9wcyI6W3sibiI6IkludGVsRGF0YUNsYXNzaWZpY2F0aW9uIiwidmFscyI6W3sidmFsdWUiOiJDVFBfSUMifV19XX0sIlN1YmplY3RMYWJlbHMiOltdLCJUTUNWZXJzaW9uIjoiMTUuNC4xMC4xOSIsIlRydXN0ZWRMYWJlbEhhc2giOiJiTFhcL1lUUFwvZlVmWWpJR3VSRmhDNFRCWTVKckdTTEVQSGtXK0JkWGszR3c9In0= x-inteldataclassification: CTP_IC x-originating-ip: [10.22.254.140] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2] ethdev: Prefetch driver variable structure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Nov 2015 13:56:27 -0000 It is probably the usual MS operation issues, I'll resubmit. -----Original Message----- From: Stephen Hemminger [mailto:stephen@networkplumber.org]=20 Sent: Tuesday, November 10, 2015 9:03 AM To: Polehn, Mike A Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] ethdev: Prefetch driver variable structu= re On Tue, 10 Nov 2015 14:17:41 +0000 "Polehn, Mike A" wrote: > Adds ethdev driver prefetch of variable structure to CPU cache 0 while=20 > calling into tx or rx device driver operation. >=20 > RFC 2544 test of NIC task test measurement points show improvement of=20 > lower latency and/or better packet throughput indicating clock cycles=20 > saved. >=20 > Signed-off-by: Mike A. Polehn Good idea, but lots of whitespace issues. Please also check your mail client.. ERROR: patch seems to be corrupt (line wrapped?) #80: FILE: lib/librte_ether/rte_ethdev.h:2457: , WARNING: please, no spaces at the start of a line #84: FILE: lib/librte_ether/rte_ethdev.h:2460: + int16_t nb_rx;$ WARNING: please, no spaces at the start of a line #89: FILE: lib/librte_ether/rte_ethdev.h:2462: + { /* limit scope of rxq variable */$ ERROR: code indent should use tabs where possible #90: FILE: lib/librte_ether/rte_ethdev.h:2463: + /* rxq is going to be immediately used, prefetch it */$ ERROR: code indent should use tabs where possible #91: FILE: lib/librte_ether/rte_ethdev.h:2464: + void *rxq =3D3D dev->data->rx_queues[queue_id];$ WARNING: please, no spaces at the start of a line #91: FILE: lib/librte_ether/rte_ethdev.h:2464: + void *rxq =3D3D dev->data->rx_queues[queue_id];$ ERROR: spaces required around that '=3D' (ctx:WxV) #91: FILE: lib/librte_ether/rte_ethdev.h:2464: + void *rxq =3D3D dev->data->rx_queues[queue_id]; ^ ERROR: code indent should use tabs where possible #92: FILE: lib/librte_ether/rte_ethdev.h:2465: + rte_prefetch0(rxq);$ WARNING: Missing a blank line after declarations #92: FILE: lib/librte_ether/rte_ethdev.h:2465: + void *rxq =3D3D dev->data->rx_queues[queue_id]; + rte_prefetch0(rxq); WARNING: please, no spaces at the start of a line #92: FILE: lib/librte_ether/rte_ethdev.h:2465: + rte_prefetch0(rxq);$ ERROR: code indent should use tabs where possible #93: FILE: lib/librte_ether/rte_ethdev.h:2466: + nb_rx =3D3D (*dev->rx_pkt_burst)(rxq, rx_pkts, nb_pkts);$ WARNING: please, no spaces at the start of a line #93: FILE: lib/librte_ether/rte_ethdev.h:2466: + nb_rx =3D3D (*dev->rx_pkt_burst)(rxq, rx_pkts, nb_pkts);$ WARNING: space prohibited between function name and open parenthesis '(' #93: FILE: lib/librte_ether/rte_ethdev.h:2466: + nb_rx =3D3D (*dev->rx_pkt_burst)(rxq, rx_pkts, nb_pkts); ERROR: spaces required around that '=3D' (ctx:WxV) #93: FILE: lib/librte_ether/rte_ethdev.h:2466: + nb_rx =3D3D (*dev->rx_pkt_burst)(rxq, rx_pkts, nb_pkts); ^ WARNING: please, no spaces at the start of a line #94: FILE: lib/librte_ether/rte_ethdev.h:2467: + }$ WARNING: please, no spaces at the start of a line #102: FILE: lib/librte_ether/rte_ethdev.h:2607: + void *txq;$ WARNING: please, no spaces at the start of a line #110: FILE: lib/librte_ether/rte_ethdev.h:2624: + txq =3D3D dev->data->tx_queues[queue_id];$ ERROR: spaces required around that '=3D' (ctx:WxV) #110: FILE: lib/librte_ether/rte_ethdev.h:2624: + txq =3D3D dev->data->tx_queues[queue_id]; ^ WARNING: please, no spaces at the start of a line #111: FILE: lib/librte_ether/rte_ethdev.h:2625: + rte_prefetch0(txq);$ WARNING: please, no spaces at the start of a line #113: FILE: lib/librte_ether/rte_ethdev.h:2627: + return (*dev->tx_pkt_burst)(txq, tx_pkts, nb_pkts);$ total: 8 errors, 12 warnings, 38 lines checked