From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1AFA443676; Tue, 5 Dec 2023 10:41:54 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4C58342DFF; Tue, 5 Dec 2023 10:41:53 +0100 (CET) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2061.outbound.protection.outlook.com [40.107.93.61]) by mails.dpdk.org (Postfix) with ESMTP id 19084402D2; Tue, 5 Dec 2023 10:41:52 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fIl1uo79q+DYTZDfD3KF24f0w00EVU6DhxPVB4RXNcF6SQY5cKcxew1nJS+k1uY3Va9vrVino2l3QdV3eoIjY+LNF5Gbkd5n+/z0Q5snpdmZEUOsU8+fC3wHB0988cFikNIGirjKo8+evSh2dfFLXpOjduC1x9xVzbl3r2kZDZbMS4n6ulcO+4x6kuSN7T8otoDqw45EHinFPllYD0nKtkoOi+oxAegMbdNlxS0rkdoJf9D4muItMolV/8GpUBEKWIvQ3XgOa/R6luwrTKJdw0FO1h89MrAIvoWcbL+ZOqxkvESkIlcYP1Nt78OfS5KUxYr/J0rcB1phs7um9cZYEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4JBbVDkfB6tyikRnuR7b7VWTjkuh2FLGzljX4ieaBkM=; b=HKAOE0s9vRD/M5YOO8W8quxDzlsozqqCxZlvGHF0Xkww08MOBlBBgYf/D477KX+59wxAo1I4vlbE6ZGiPhck8x3z7SRnqw/GYKBX7KsJ9FUzwP/Z18BsNEyhSPliR2vxAbVXLPfadTXcCs8Ngfg0Cr7hM4y68WCudM9HcDXnLjcIIsArVoy6lkRhidr6+ewN8Rh0mR+DJad8tZ8cb4j7DsBtw3I0wNlvmHbm6Q+noTOKJPrB8mY+FFWfEzGk/yYWfKbaP0qh+blx9uEEFdxTYzpIZsD3UZ8DwJySlM8qct3X19sjohHkI9Qk3h4XIH6a2eYAQE1VvLamJUjtNyMpVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4JBbVDkfB6tyikRnuR7b7VWTjkuh2FLGzljX4ieaBkM=; b=rn9INmKfVHIEC2dOtLkS66iTgdFwlXY+773VX6RJpUheCFdCcL9VJfTRylt921zUqn/iLTF/SKkL7XiQ3goIOhz3KezF0sRRMfGMt0OUlZCp/sZlG41QgG+W5PiTgI9waK2iJYkWwMMjmrGC8EckiPnpCN/YiA53FQuIK+xv3yU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DS7PR12MB8292.namprd12.prod.outlook.com (2603:10b6:8:e2::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.34; Tue, 5 Dec 2023 09:41:48 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f%6]) with mapi id 15.20.7046.034; Tue, 5 Dec 2023 09:41:47 +0000 Message-ID: <746decf7-616f-4158-86f9-bc45425c46a1@amd.com> Date: Tue, 5 Dec 2023 09:41:41 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [dpdk-dev] [PATCH] net/af_xdp: fix memzone leak in error path Content-Language: en-US To: wangyunjian , "dev@dpdk.org" Cc: "ciara.loftus@intel.com" , "qi.z.zhang@intel.com" , xudingke , "Lilijun (Jerry)" , "stable@dpdk.org" References: <64117415a68e8c920efdf905f799b26dcbc3f8fb.1701415014.git.wangyunjian@huawei.com> <747e0b0425ca4699904352d047048190@huawei.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <747e0b0425ca4699904352d047048190@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0149.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:95::20) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DS7PR12MB8292:EE_ X-MS-Office365-Filtering-Correlation-Id: 7ba9e33b-b776-46c6-5bed-08dbf5766632 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ztPQv6GOznXVvkynEI/5LGr3eFEjWeN2ZuB/itiMv/fOMBSlQ6x/EWidcoUen80L78z/YLt2uigYz18HfDdZtAOt07zV4thjt3gvWeYgbXI0EF4b9Jilo4dCDcclFSrmeFlrdGFsrnGUcDn93XAYXj/b7yNE00cnfWO0RQRpo6NPzkQHIs4hkMvfY/Fkk+WFL1RmeAkwVjgNJ3QlhqUITweUtjQ7FD2T1hlFc/iVyoUmZKYh8kHkfxjLgmuWqA/L3keWelua2+wgHCmwzr+Vpaun8nZ8tWnEwoWbtIpbWf2hpxWSyOS+nOGlJvvquoKmebcWBU00c3EGKeZXT256BjlUKMwgCTSscdtP5hEwyo3UsvTAfIfedWenK4/zVCs52l82SU1TwnnZqF/nSIASBQ0AP+HZ0nce0wT69/HJDEa24oUHeKeAWK81fofoCntQvnaW6VOh+WFqMvuz9ug63jfXPUrG9DHd64hAV8Ln4ApW95t5XDylRwp5jplxQ9PR6/3zHIG4qthGgJk2b+Zk3tLIToqrDWBQuSxjXozu35uir6pmL+3iM77tfTbT9U5KaNji0gljjQU0NcuYCx96W6mzvJ3DUeGEQyeT9NGVxUbxHRE2MGbvimn/SmBIw9MeKjjUGguIGpVz3jgRUgr0ag== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(396003)(346002)(366004)(376002)(39860400002)(230922051799003)(451199024)(186009)(64100799003)(1800799012)(2616005)(53546011)(6506007)(6512007)(31696002)(38100700002)(36756003)(86362001)(41300700001)(26005)(83380400001)(5660300002)(4326008)(316002)(54906003)(110136005)(31686004)(8936002)(44832011)(66476007)(66556008)(66946007)(8676002)(2906002)(478600001)(6666004)(6486002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dUN0T3czZU9yZE9kTFIyU1M4VUQxZmpVTVRhNXdmcEdHVTlET1JRUCt2OW5n?= =?utf-8?B?Q0thNVhuc3BMZUl0bWxVbjdIQzdIRzRGSjEyeTd2RElDZThLWWV5bUhFQXZh?= =?utf-8?B?ZHFSeGlNeks0NlNGcjViMW5tcU9wbk1TZWpyTWg5SVZNek9zTDBtenBHNmpO?= =?utf-8?B?bTFRSzhqNkZQK3VzZVp1bzJlcW13R3ROSTVEb2NsblZlL2ZqSjNuSFJ3T2pT?= =?utf-8?B?QlYwWkhDYU5zQzBmcHBGS1JXajFWa2VRTk9MdFNMMUlMUDNQaUF1cGIxVEhQ?= =?utf-8?B?ZkJ3VmhLbG9DWHhnbVNBR1hOaVBmKzlvK1FGd3l1UmltMCt6bzdJcjl6RTZF?= =?utf-8?B?MldzZENIclZSK0pLVEpFRTNIYjh3YXYxaHFkSk5vRlVDYklBWE5NYjV3VDEy?= =?utf-8?B?c1BGS2VLTEFZa3Fqd2orUnRKNldnUUNqdnMxUXlmOStRQ28ySXBOMWxYd1pT?= =?utf-8?B?b2pxMGVMVWFYOHcyc1N6UFBiZ3hITTYxcXovZkNhVjVJSlllSjVoblpFZ3pt?= =?utf-8?B?bE9SeTQ1Ullmc25lQ2o3VkdJVFZSZFR2SXBaZHVsdEdaUHBkZndha0VyY2Mr?= =?utf-8?B?ckZLenNjcTlVcXJLZ1U4VHBGWUQ1ZHJmUWYxc1ZVMzFwcGtsbUpsL0x0NHpp?= =?utf-8?B?NEtmNDRyL2sxelpIbnVrZCttSlFaYzhqNG9YNzZJUURiTERJM1NZYXYzUEFh?= =?utf-8?B?bkNMejdtdzl3a3Zqb3Z4b1A0U05JTjFRRVRXQzFDWmNMeHVRSUJvMklkUGI4?= =?utf-8?B?ZE85QjlDdm4ycXBsWWNEMzB4eCs0cEwyRWd4ZmJTci9SVTFQalp4RUhLSDQy?= =?utf-8?B?dkFFVjgvSU5HUFcvNHc5cWNGMnlMNGFDd0JvT2lRQkVnV0I2bHU2emNZZnhB?= =?utf-8?B?bFRvU05VMkFqNWlkOWxXT3VmYVNsOXUvZUUzc09FbzZvN0JyVHBBaXRNQUdE?= =?utf-8?B?TlpWS0FndmFDbU9OdENnREtYdzlaSk5IeDR4T3lPMjZEdGkzVlVnS3A0VjJz?= =?utf-8?B?SmVoVitZV3FVU2wyeEpWVnI4YkozcGY2WnZISzRGSjI2K2pWSTJQVm4xdGsr?= =?utf-8?B?citlVFBmdERleHJTM284Uk5nSXdCYitNeXZTdE1YSldMa3VmU2RiT3dtOFo3?= =?utf-8?B?eWNYRmlYbTJUTzFXTUFFR1dkNUdWRE1TTXBlUlU3ang4OFdIRi9rNWJxbzZw?= =?utf-8?B?aTlxR0duY0lYekVteUp2V2N1RGQwZzNBeVBIV2RUdUlUeDR0THVjNS9vSGhP?= =?utf-8?B?OWplM004UVo5SU5BMGhDUFZWcjl2UHJmVlRQWWZjeDdNbkpVdFR1NWdGNDB0?= =?utf-8?B?bk1VS0JybFcyU0ZaRFlLU25Qd2l1RXMrKyt3MWJESit5aUluaEVNY0RVem01?= =?utf-8?B?c1YwUklzdEhSQk0vTTk3RzFUWFd6QTNBSVp3WDgxTnRWQmlKM01iajZVZWtQ?= =?utf-8?B?dlA0bHduS2FTZ1hrdjF2d29PYnF6dDNkNGRuTWFtNmRoelJTK0cvNWVuK3Nk?= =?utf-8?B?c2t1UWRmY2VnT01RTFlXQ0JFaHNoUUxHRUFLWXNrRzF4R2ppVkJsWkI0d1pF?= =?utf-8?B?WVk2bjRYekNDM0ZTVC9wVlRxd3lMam5Wd0xZcUJDTTU4cmUwTmYreFQycW8v?= =?utf-8?B?dVhDUFFtT1FBQjJHSWRVV04yZjlRYkFEUG1LcTFUNzJLOXFleVVsVEpKZzFh?= =?utf-8?B?cGhYZmNWL3Q0Yk9GUFJhUUtBRThlY2EzUEwxKy9Vd2psRzhnOWkrSzZwZkoy?= =?utf-8?B?UjNPOVlQUlhDQUtxa2Q5b0gwYlpVN3hFNkQ5NVVOVWVZYkxJVExkditkWXB5?= =?utf-8?B?Mlo2MEt5d2sxS3ZaSDhkRmxtZ3BoS0VsN0VteW5Sc044Mjl5a2V0RGdkbTh5?= =?utf-8?B?RUZsLzB1QngzRGhOVk9Ya3kyMXgvMmxCOGhEbmY4WkxsTy9NQjJyR2hTYlA3?= =?utf-8?B?Nmt1UENHVzVENVA3Y3hidHRQdjFMcENKZVdnVS9sT2tXYkdxeGtCVEZPUit4?= =?utf-8?B?cThsTU1hbHE5eS9qa0Z4Sis4V0tPY3BPUXN3TVhUK1N4ODNMakZncTAvVHN4?= =?utf-8?B?WUIzeEdSNjdodmJsckpsLzFRMFpLaW5qYnBYa2RoWDh5VkpzYlh2QlI1TDNM?= =?utf-8?Q?XIEY=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7ba9e33b-b776-46c6-5bed-08dbf5766632 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Dec 2023 09:41:47.5217 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Xx9OhvjvTRnbhv/kEsy6hubgHV6kAAlCMuaifsd/pAJEeSRTw8h3ENRQF86Kbmxd X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB8292 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 12/5/2023 1:23 AM, wangyunjian wrote: > > >> -----Original Message----- >> From: Ferruh Yigit [mailto:ferruh.yigit@amd.com] >> Sent: Monday, December 4, 2023 10:10 PM >> To: wangyunjian ; dev@dpdk.org >> Cc: ciara.loftus@intel.com; qi.z.zhang@intel.com; xudingke >> ; Lilijun (Jerry) ; >> stable@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH] net/af_xdp: fix memzone leak in error path >> >> On 12/1/2023 8:03 AM, Yunjian Wang wrote: >>> In xdp_umem_configure() allocated memzone for the 'umem', we should >>> free it when xsk_umem__create() call fails, otherwise it will lead to >>> memory zone leak. >>> >>> Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD") >>> Cc: stable@dpdk.org >>> >>> Signed-off-by: Yunjian Wang >>> --- >>> drivers/net/af_xdp/rte_eth_af_xdp.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c >>> b/drivers/net/af_xdp/rte_eth_af_xdp.c >>> index 2a20a6960c..2a1fdafb3c 100644 >>> --- a/drivers/net/af_xdp/rte_eth_af_xdp.c >>> +++ b/drivers/net/af_xdp/rte_eth_af_xdp.c >>> @@ -1229,6 +1229,7 @@ xsk_umem_info *xdp_umem_configure(struct >>> pmd_internals *internals, >>> >>> if (ret) { >>> AF_XDP_LOG(ERR, "Failed to create umem\n"); >>> + rte_memzone_free(mz); >>> >> >> Doesn't 'xdp_umem_destroy()', in the label 'err', already free it? > > In this case, 'mz' is not assigned to 'umem->mz'. Therefore, > the'xdp_umem_destroy()' does not free 'mz'. > > True. What do you think to move 'umem->mz = mz;' assignment after 'mz == NULL' check? So related code can be grouped together.