From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D3074A00C5; Wed, 14 Sep 2022 21:25:00 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6D5474021E; Wed, 14 Sep 2022 21:25:00 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 36E044021D for ; Wed, 14 Sep 2022 21:24:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663183498; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gmr0txuGvAAZ+Hzz1FcIrWkW21Z7KxZhmeTL3yqrW5U=; b=dLlOdXYrMQk21aB7a5aSny6Ngt5BS/BBsKRs+fw+ewngb5yZKa6A5jiaVth/J8fwwl6eNH p0MKWAGYrQsrnaoksRWZeK7+qPUy8VZ3lWS6iyY6K1KQf5h0UQr+O5OjZN4ElCWfnznDdo sH7YRSGkeq14loRA1tGIEUT1dJH+a9E= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-475-2NqAZ2NcOFmAjAeiyTE9fw-1; Wed, 14 Sep 2022 15:24:55 -0400 X-MC-Unique: 2NqAZ2NcOFmAjAeiyTE9fw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 43514185A78B; Wed, 14 Sep 2022 19:24:55 +0000 (UTC) Received: from [10.39.208.12] (unknown [10.39.208.12]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0D62C2027061; Wed, 14 Sep 2022 19:24:53 +0000 (UTC) Message-ID: <747301ed-cc51-3ae7-aa14-d0904829d276@redhat.com> Date: Wed, 14 Sep 2022 21:24:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v2 06/37] baseband/acc100: add default e value for FCW To: Hernan Vargas , dev@dpdk.org, gakhil@marvell.com, trix@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com References: <20220820023157.189047-1-hernan.vargas@intel.com> <20220820023157.189047-7-hernan.vargas@intel.com> From: Maxime Coquelin In-Reply-To: <20220820023157.189047-7-hernan.vargas@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 8/20/22 04:31, Hernan Vargas wrote: > Refactor frame control word LDPC encoder fill function to take a default e > value as a parameter. No functional impact. > > Signed-off-by: Hernan Vargas > --- > drivers/baseband/acc100/rte_acc100_pmd.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c > index 586d06d1b3..cc7d146e74 100644 > --- a/drivers/baseband/acc100/rte_acc100_pmd.c > +++ b/drivers/baseband/acc100/rte_acc100_pmd.c > @@ -1268,7 +1268,7 @@ get_k0(uint16_t n_cb, uint16_t z_c, uint8_t bg, uint8_t rv_index) > /* Fill in a frame control word for LDPC encoding. */ > static inline void > acc100_fcw_le_fill(const struct rte_bbdev_enc_op *op, > - struct acc100_fcw_le *fcw, int num_cb) > + struct acc100_fcw_le *fcw, int num_cb, uint32_t default_e) > { > fcw->qm = op->ldpc_enc.q_m; > fcw->nfiller = op->ldpc_enc.n_filler; > @@ -1277,7 +1277,7 @@ acc100_fcw_le_fill(const struct rte_bbdev_enc_op *op, > fcw->ncb = op->ldpc_enc.n_cb; > fcw->k0 = get_k0(fcw->ncb, fcw->Zc, op->ldpc_enc.basegraph, > op->ldpc_enc.rv_index); > - fcw->rm_e = op->ldpc_enc.cb_params.e; > + fcw->rm_e = (default_e == 0) ? op->ldpc_enc.cb_params.e : default_e; > fcw->crc_select = check_bit(op->ldpc_enc.op_flags, > RTE_BBDEV_LDPC_CRC_24B_ATTACH); > fcw->bypass_intlv = check_bit(op->ldpc_enc.op_flags, > @@ -2525,7 +2525,7 @@ enqueue_ldpc_enc_n_op_cb(struct acc100_queue *q, struct rte_bbdev_enc_op **ops, > uint16_t desc_idx = ((q->sw_ring_head + total_enqueued_cbs) > & q->sw_ring_wrap_mask); > desc = q->ring_addr + desc_idx; > - acc100_fcw_le_fill(ops[0], &desc->req.fcw_le, num); > + acc100_fcw_le_fill(ops[0], &desc->req.fcw_le, num, 0); > > /** This could be done at polling */ > acc100_header_init(&desc->req); > @@ -2587,7 +2587,7 @@ enqueue_ldpc_enc_one_op_cb(struct acc100_queue *q, struct rte_bbdev_enc_op *op, > uint16_t desc_idx = ((q->sw_ring_head + total_enqueued_cbs) > & q->sw_ring_wrap_mask); > desc = q->ring_addr + desc_idx; > - acc100_fcw_le_fill(op, &desc->req.fcw_le, 1); > + acc100_fcw_le_fill(op, &desc->req.fcw_le, 1, 0); > > input = op->ldpc_enc.input.data; > output_head = output = op->ldpc_enc.output.data; Reviewed-by: Maxime Coquelin Thanks, Maxime