DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/tap: fix ICC compilation fails
@ 2018-02-01  4:43 Zhiyong Yang
  2018-02-01 10:02 ` Thomas Monjalon
  0 siblings, 1 reply; 2+ messages in thread
From: Zhiyong Yang @ 2018-02-01  4:43 UTC (permalink / raw)
  To: dev; +Cc: stable, pascal.mazon, ferruh.yigit, thomas, ophirmu, Zhiyong Yang

The following error is reported when compiling 18.02-rc2 usng ICC,
"transfer of control bypasses initialization of".
The patch fixes the issue.

Fixes: 1911c5edc6cd ("net/tap: fix eBPF RSS map key handling")
Cc: stable@dpdk.org
Cc: pascal.mazon@6wind.com
Cc: ferruh.yigit@intel.com
Cc: thomas@monjalon.net
Cc: ophirmu@mellanox.com

Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
---
 drivers/net/tap/tap_flow.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/tap/tap_flow.c b/drivers/net/tap/tap_flow.c
index 212992e49..65657f0a0 100644
--- a/drivers/net/tap/tap_flow.c
+++ b/drivers/net/tap/tap_flow.c
@@ -1930,6 +1930,7 @@ static int bpf_rss_key(enum bpf_rss_key_e cmd, __u32 *key_idx)
 	static __u32 num_used_keys;
 	static __u32 rss_keys[MAX_RSS_KEYS] = {KEY_STAT_UNSPEC};
 	static __u32 rss_keys_initialized;
+	__u32 key;
 
 	switch (cmd) {
 	case KEY_CMD_GET:
@@ -1975,7 +1976,7 @@ static int bpf_rss_key(enum bpf_rss_key_e cmd, __u32 *key_idx)
 		 * map index as an out-of-range value and the release operation
 		 * will be silently ignored.
 		 */
-		__u32 key = *key_idx - KEY_IDX_OFFSET;
+		key = *key_idx - KEY_IDX_OFFSET;
 		if (key >= RTE_DIM(rss_keys))
 			break;
 
-- 
2.13.3

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] net/tap: fix ICC compilation fails
  2018-02-01  4:43 [dpdk-dev] [PATCH] net/tap: fix ICC compilation fails Zhiyong Yang
@ 2018-02-01 10:02 ` Thomas Monjalon
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2018-02-01 10:02 UTC (permalink / raw)
  To: Zhiyong Yang; +Cc: dev, pascal.mazon, ferruh.yigit, ophirmu

01/02/2018 05:43, Zhiyong Yang:
> The following error is reported when compiling 18.02-rc2 usng ICC,
> "transfer of control bypasses initialization of".
> The patch fixes the issue.
> 
> Fixes: 1911c5edc6cd ("net/tap: fix eBPF RSS map key handling")
> Cc: stable@dpdk.org

stable is not needed here

> Cc: pascal.mazon@6wind.com
> Cc: ferruh.yigit@intel.com
> Cc: thomas@monjalon.net
> Cc: ophirmu@mellanox.com
> 
> Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-02-01 10:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-01  4:43 [dpdk-dev] [PATCH] net/tap: fix ICC compilation fails Zhiyong Yang
2018-02-01 10:02 ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).