From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7DCFC43BA4; Fri, 23 Feb 2024 12:42:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 14CFC402E3; Fri, 23 Feb 2024 12:42:24 +0100 (CET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40]) by mails.dpdk.org (Postfix) with ESMTP id BC3C64021E; Fri, 23 Feb 2024 12:42:22 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GqcJF2IBCN4GWh9mPp2CJiXn+4vQXsCaRv9mfVB3aR6B3rZg6WUOSpOW6LTQEyy1VvTG+389+hHiMjxuZCi8P2hD0bTGA3u/mfVEpTlXPrCZ/ANs/xsa1A+HJ0ZIuHx84A4JcLoyjGb3Rb1jtomwl5lYQniPo6KR9+MD4oTAkPU3BHO+ox83tcrXzYnymRf5ujRI8uzy8hiIUbowLUG4pSu5GBw6cB5Dao3GbiYizVMWkT5aJECH3EMrunNROWVejpEpIOcMXBa2SROyYer33CxLM+wasUAyPv6TTpJoQHf0crwDMHQ94V5uDt/b0f1+AHGWTDkNgL+HgeaIfCdxEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kLAMpIuYMGI5ch1GL3pr7g/V5fXSAzT+BqIGy8a889w=; b=RHfsyr1EwWhGTG7OltTZhLFRbcofD4kCt3zcf4AJi48iCNlszdtmsHvckP+KXSLHsa08A9qCx/HLIrOk5B2RiG55L9UoAD9fdebnunB5mrD2ZlX+6jj6QCBAaA7PH1HpUXkaDJ9n0RtO4kfL7xFMv/2LpwXl4DZm98GQ2K4LoHq6lPROf+FVDtaOUV+2HV3bekkBOXkYaMMQtMBzq+LMbdMBJZiKxeeNkQNj+zxQ91V090IJhGqOvnEsWWceLolvYzYZ1IX+eqfXLz/+k9CzfEM5L7NwTkyc7tpq+JZ8/GsnRCZ8Cff+Hm5N9w32hyejW/H6fg7Q39TTw4tOEvOx4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kLAMpIuYMGI5ch1GL3pr7g/V5fXSAzT+BqIGy8a889w=; b=aw+Dd/yp9bacNrtGgAIeUI78DV+ZY/COApZGBdCpY11rEDiJ1tHXSq2PxpIIJBnxRmZqByBD+GQnBzZFWEeCzh7iIleSHdPGF13/hdUQONXuVJYtaz0pFfNhPh21hN2jp3aoDgoiu5DQDUXwhmKCLsd4tb1+xqoljI9Tebx+QPw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DS7PR12MB6213.namprd12.prod.outlook.com (2603:10b6:8:97::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.24; Fri, 23 Feb 2024 11:42:20 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529%5]) with mapi id 15.20.7316.018; Fri, 23 Feb 2024 11:42:20 +0000 Message-ID: <7484378a-c6b9-48d6-9ec5-aa9b0b56da1b@amd.com> Date: Fri, 23 Feb 2024 11:42:15 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] net/af_xdp: fix resources leak when xsk configure fails Content-Language: en-US To: Yunjian Wang , dev@dpdk.org Cc: ciara.loftus@intel.com, xudingke@huawei.com, stable@dpdk.org References: <1708608939-14440-1-git-send-email-wangyunjian@huawei.com> <1708652745-18556-1-git-send-email-wangyunjian@huawei.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <1708652745-18556-1-git-send-email-wangyunjian@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0597.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:295::14) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DS7PR12MB6213:EE_ X-MS-Office365-Filtering-Correlation-Id: 58f59e23-c897-4a19-5357-08dc34647e64 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MYGHbU0agiSsD+iPLDH8U+zGswpN4nr7KSGri+QcG+iX2YkxTy6q5ZsxRoAMN/1J1XDqkISWahtAKkQP//ED0NlkyoLNUaEZQRM2k2DZNe7oCZ/X7HJkDw5ocjPuCLD+QOGNRKWELYhxlBU05FWkB2/VLm2Lvp0eq1E1WdJQVo/IVegr7esFSwX0RWxZobBDDxmSWwHOboh8INrNhvHGej9VQBABtU9TkJXOCHHnIkT3CeoBs2nTgoWQsAeSZwLAz5G+MI9xhIG6Jn5Rx7ZjgCGJ4bKyWv6DmhpkmWGhct4ijO0LuytQd3EGyfLn9vY2NvbKzTpzqh9CBKHiTSpvzkgPMxa/ruakyThS9lZGeeab1o6uP71f9RysPWILHTtVdfQaB0BQ3x5rRfiDiY5SUHnKxOwhBrpH/VCWctuJympfyjq9UKtwStYV74TUr6MRBxwno3Z7LfaAu5iNR9mi0s1MdwAuHjhDf7ixgx6u5fQQ2flvJ+PvIzYVTnBzsVRmkOBD7J1qQfym/nrCGfyFmYsl5n73SxcSULi/lXXXgt0= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SUsxMlByUlRzL3A3bjBXc3VENmJ3cTZNY0JoRmVOWndNbkJYUUF3cEFxOFc4?= =?utf-8?B?UU5lZlRzaW5Bdm9GQitDYWRVOG8wZEI5d0ZqYWxKUGU2UXpLV210R01hOVNr?= =?utf-8?B?STBMOEh2TGc2VVVKbXVGMlk1d245eW5NZkhlU2hIY212MVZhVUU0ckFkaWIw?= =?utf-8?B?ekZOYmpIY1BPblhUTTBQTjBlbjhydkhmb3ZqKzJ5cEFjdGJTZnZMQ05neVVx?= =?utf-8?B?ek1EMmJnUWlmVEdBbUk4dFl3c2JkVFlHVVlpNUZVRHZ3VXUrbVA1b2U3MEt3?= =?utf-8?B?b28zMjlqL3YrdDg4YkNXeDFJTnp6TExEU0E2NWJRV0pBVkZVWnRsUjZYSU1p?= =?utf-8?B?dDB5RG5EcnRvempieHN1c2tkeWZRUnlRSlFKQUhZVG8rZlZ3bitUYnlEenEz?= =?utf-8?B?RElTN045RjVVa2hjOUU0OWY3NVYxUzk5RUZSVlAwQzF0VFQxVGRlRy9SU3ZR?= =?utf-8?B?RHpPVmcrdEVGeG00a25iQWNrTzI0Ri9XS2F4cnRFYUdCZnhHRWxZczhqNVJu?= =?utf-8?B?M21TYk1SZ2xTakMxQVNnaFZNUlE1UXAyVldmOFk1MmZoRk1hYkxoK1J6VUxS?= =?utf-8?B?ank5bWw0TDJmOTcwVFhtY0FDcEFqeGdWeGdWYlJwWUNSVXkwNFNSditzVjdq?= =?utf-8?B?RmZyZWpQYUtwdnFkK3kwQjd6d1VqV1dJaDZ4NE1JQnloZzhFQ2hnQW9zWDJi?= =?utf-8?B?WExMbC9JbmRSSjdzbWZTK2VacTBVaWJCL3BxMUJBV1pHK2JrZHVDZytpQlIw?= =?utf-8?B?emNSRTNhaVBiRTM2TXptdlFDMjJpWUpMcTBPaXdzTHc1REozaWxzUGhDSnRs?= =?utf-8?B?UEVvcjdNWW9lR01MTWpLMzZVVmhhR2h2WEJRVVA2YXBoVnVDZWd4NnVERFNx?= =?utf-8?B?dS9BM043OVdURjEvVE9reEVkbTA1eTR3NDU2bm10dVhBVjJneDMyT0xHQW1Y?= =?utf-8?B?dWlkUjdsSnQ1ZFFacnJWNnVHQmplL0wrMkxwVURvaUxCeVorMEZvWXlFOUpW?= =?utf-8?B?YS82SlZHeGoyMm5FeGpqd0xRTWtZWXNLOHBRUDRiUjlDcHNwMnJ5WWNtc25B?= =?utf-8?B?OFdYK3AwZmJzcVBGaGdGb2dOS0J6clV5NW9iT0U1cmViVHAzQXNDcDlRVmEx?= =?utf-8?B?NGdidG1xSXNlZG52RXpDNlEzd0c1K1NCMkZhemRXaFVSUlF6TlhiRDRkRUdr?= =?utf-8?B?WUptL20yeGlOcUJsd3JlQXlid080M25rVnFhOE8vMmtmUE5yQzhNRXo1dThY?= =?utf-8?B?Qmtuc1Nkb1hMZkdyUFJvMUxBQ0hKTHNKUFNtcCtqdlhDZFlKUGEyYkJIM1hn?= =?utf-8?B?OHdtZ1UwVno3M1QxZG9BRlEzenlTZEVtcTZKYys2QmZRNlJIV3pjamNWMks3?= =?utf-8?B?MTRscXM5WFN4MFg4SnNEMUV1ZTRTVUN6R2FjNzd5WFZWNXYvZGRlK0VXREs4?= =?utf-8?B?SUpRUVliMW01M3ZiQmM0S3NPQXRRMHBpanhrekR1RDBtdFFRUDlBUUhPTXVI?= =?utf-8?B?RXBEYjlQYks3cDVBYU9BNjVUUlg3UjdsbEFTbzRocnc0V3l4bjROc0RpMExY?= =?utf-8?B?VFBkdWVzTHU2dkQ4TkxxV0JsTUUrOFFGdFhhNU5oVGRiSjh6WlNidzducEtM?= =?utf-8?B?UHZleWh3YnVaSXBVaUZMSFZGU0M3K3hVMDlpbkVRZTNxNWhPU205NVJQK0dz?= =?utf-8?B?MUpTK3pEdlZKblJEVGdra1JQV0pXUGhNLzBMWXdCbitIRHQzYjkvU1QwQVF3?= =?utf-8?B?ejYwbVJTTGJBcXpzdGpyQ1l6eE9HU0svS2plQWZzVUE3RndobXNlU0NxVmVZ?= =?utf-8?B?YlRmYjZySFF1Q3ptMWZGSkwrcm5Gd3cwMG5iK1pCVjZrbUNPYWpiNzNxTElO?= =?utf-8?B?amo5TmFiNUpVU1piNnBOaWw2aktKbkp0UlAwZWpadXpBd1dtKzN4OG9WYW9n?= =?utf-8?B?UjBsWjgxY1ViSWZBUm93M1hqRnJLQWxCTmR1MU1UNTduallIZjhlYis3K2Vy?= =?utf-8?B?Q2VMV0E2WGt1M1VPZzNMRjJxWitCMTJMWnJSNkZaU25NZklnaDd4Y2JqNWRq?= =?utf-8?B?cmtyNi8xMmV6K2ZUU3JmQWt3ZnlVaVJJUGZCM3JxK3VKMk5FdTJHV2dPQlg4?= =?utf-8?Q?fXV04GxOGjiHp+OsDSCDroOqw?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 58f59e23-c897-4a19-5357-08dc34647e64 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2024 11:42:20.3655 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ds6uzbLUbBdzIkhaGjJ4/hsX5YhafNcTA2A8mMc3jFOwD3sztsCFntB5Qow9GFch X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6213 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/23/2024 1:45 AM, Yunjian Wang wrote: > In xdp_umem_configure() allocated some resources for the > xsk umem, we should delete them when xsk configure fails, > otherwise it will lead to resources leak. > > Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD") > Cc: stable@dpdk.org > > Signed-off-by: Yunjian Wang > Moving from previous version: Reviewed-by: Ciara Loftus Acked-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.