From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7FBCDA052A; Fri, 10 Jul 2020 23:07:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6449E1DEBE; Fri, 10 Jul 2020 23:07:22 +0200 (CEST) Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by dpdk.org (Postfix) with ESMTP id 789221D6B0 for ; Fri, 10 Jul 2020 23:07:21 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id C3E1D580359; Fri, 10 Jul 2020 17:07:20 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Fri, 10 Jul 2020 17:07:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= uUcmBKHeZDpRVp8D6jF7fCxaH1wwyyeudIA92nCEvgQ=; b=pdd7VPWeFth1Tk9o WyZOqNADa+xdslGIBaONYFX/FRFhlw4VnGWY907dfqRjSUgrtDHLVVh7ZHDlnlbv GtXA5zsQwrYrRYvKBwEvQVn7+0kO4oq74OPha6wC4sD7dDBmt+Rn3k1tLKXrUVrU Pl9UwI9H7VGa2xOQft0vH/8KjeB/foNU9XMiKhlHio+wcEVdy8mzrLucLHVDyqG2 82ZeaieMarU+tjGb3AiRS+bVsn+cd19PF8KADOKPdMqx0dC7713hj4g1fxAJGWRD Esw0EWaMo4blgOTxCn1smEelRxJcexaALtONjOxc3psLrUTx8jqH5uoCPle37z2L j5ADdQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=uUcmBKHeZDpRVp8D6jF7fCxaH1wwyyeudIA92nCEv gQ=; b=Rj20cCCynzRNMljYyRxEKFbjoxeTwfNEx1yzHOZrryz9VkNxvgjjDci4G lJ+D1wGU5JRfpFXJjgrBTn43yteFKxyEmeFFGQNfhngQZcBKg5ynrz2HVCrMv3do 0Rwo0QRqMmKwdOiGV2hvnh6E+l+gx3UfY+VoD6UqvY1uY5gtexASciuzAHh6eSmK n8D2UV7VteEDuAhfb3NnHN8Z0LwrXuQjaUrWsRflnvqSdij2nyVCQCl51opxi6ah 28ryDi/TxYIagHjpwUfxa+DC8T2mraPigfhnP9qy6mVpbzlFcMqzwQQK7npMMliQ FocVNkcdZjyqnmKB/xoTIHe6fgvSw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrvddugdduiedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkjghfggfgtgesthfure dttddtvdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshes mhhonhhjrghlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpedugefgvdefudfftdefge elgffhueekgfffhfeujedtteeutdejueeiiedvffegheenucfkphepjeejrddufeegrddv tdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 045EB306005F; Fri, 10 Jul 2020 17:07:18 -0400 (EDT) From: Thomas Monjalon To: luyicai Cc: dev@dpdk.org, chas3@att.com, zhangliang@bigo.sg, chenchanghu@huawei.com, jerry.lilijun@huawei.com, haifeng.lin@huawei.com, guohongzhi1@huawei.com, ferruh.yigit@intel.com, matan@mellanox.com, rasland@mellanox.com Date: Fri, 10 Jul 2020 23:07:18 +0200 Message-ID: <7487826.b65qEJXc0Y@thomas> In-Reply-To: <3071696.IbEkSYjo7c@thomas> References: <1589887092-26360-1-git-send-email-luyicai@huawei.com> <3071696.IbEkSYjo7c@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] drivers/net/bonding: fix bug for lacp negotiation failed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Still no review. Please give your real name in the Signed-off so it can be merged. 24/06/2020 12:43, Thomas Monjalon: > Any review please? > > 19/05/2020 13:18, luyicai: > > When two host is connected directly without any devices like switch, > > and also enable dedicated tx/rx queues on bonding devices slaves, > > rx_machine_update would recieving partner lacp negotiation packets, > > which partner's port mac filled with zeros. So in this situation, > > it would never go rx_machine branch with correct mac! > > Thus bond mode 4 will negotiation failed. > > > > Signed-off-by: luyicai > > --- > > drivers/net/bonding/rte_eth_bond_8023ad.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c > > index b77a37d..2002ec0 100644 > > --- a/drivers/net/bonding/rte_eth_bond_8023ad.c > > +++ b/drivers/net/bonding/rte_eth_bond_8023ad.c > > @@ -798,7 +798,8 @@ > > RTE_ASSERT(lacp->lacpdu.subtype == SLOW_SUBTYPE_LACP); > > > > partner = &lacp->lacpdu.partner; > > - if (rte_is_same_ether_addr(&partner->port_params.system, > > + if (rte_is_zero_ether_addr(&partner->port_params.system) || > > + rte_is_same_ether_addr(&partner->port_params.system, > > &internals->mode4.mac_addr)) { > > /* This LACP frame is sending to the bonding port > > * so pass it to rx_machine. > > > > > > > >