From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D5594A0032; Tue, 29 Mar 2022 11:26:36 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AEC6341151; Tue, 29 Mar 2022 11:26:36 +0200 (CEST) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mails.dpdk.org (Postfix) with ESMTP id 788AC40691; Tue, 29 Mar 2022 11:26:35 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id A69B73202161; Tue, 29 Mar 2022 05:26:33 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 29 Mar 2022 05:26:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; bh=ldkp9sL1DQVxeb JmerqzIVlraiOs1JOkQJOKGgwVTxM=; b=pHLgRSu/y3qE533DX4bLaUH7URUOpL ARY7LnlnqKHnlbt8t1gI+Wuk5WFUlvH0sYmNP9lhJ5d9gW7r5Gagc8K7XpnJW2iq vpC2LozXA0uw3b7l9xa0WmLt4ZGiQX7kdEFfZRCaJj3h3QVMLloXyKbdzT/cS/mH E9ZRVd1Uqklhh9DOmltUSM+7S55Oz7eGB0JtGM6eSpusL3EtKCnfTa9NZXZ7d7jA OMyYEwDOtKZWvNW7vUO8cZZltCHJCzEBO34jCw8IYcXq66QoEjYHoGZRDsj5rJq+ rJYkwbR3pQpG1Nw28iqJKTJwdpkRovy0vuOSbjXzN5sdWXMvM7b18RnA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=ldkp9sL1DQVxebJmerqzIVlraiOs1JOkQJOKGgwVT xM=; b=M1yOVVoFlPBGoMQdalKXXB9+zUJhoIIjI0eb524DUdnzntE5gAs1PEji0 SR6Sz2/QQ9AlxxtvSf9cW5/do4D75qDMbGegoG0sF97+lS5fXVNuqwFhBMsUej0M vk/B7hP8KAH0mTLrx83RTN7AcMbkRHsBQB0mSvUsKxuUa6qxfZwcuYexVvERuUXi mDUVqYfuHFVtdANlbl+vSIj0A8hlu6/lrt1SXs6sJuBHx3eUPsgmzCeHSt8355pE KUl+sHDCQab5ywm/fBy8w7tnm33tMbTUcfhUXKF++mq4By8j/2aV/ZgJxXypx7lT L8MqqirziPdS0gy3/aJTdeE//Fa5Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudehledgudefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 29 Mar 2022 05:26:32 -0400 (EDT) From: Thomas Monjalon To: David Marchand Cc: dev@dpdk.org, stable@dpdk.org, Ori Kam , Xiaoyun Li , Aman Singh , Yuying Zhang , Ferruh Yigit , Wei Zhao Subject: Re: [PATCH] app/testpmd: remove useless pointer checks Date: Tue, 29 Mar 2022 11:26:30 +0200 Message-ID: <7495551.lvqk35OSZv@thomas> In-Reply-To: <20220324161503.13047-1-david.marchand@redhat.com> References: <20220324161503.13047-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 24/03/2022 17:15, David Marchand: > Parameters to this static helper can't be NULL. > str has already been dereferenced in caller. > dst and size point to variable in stack. The same function is copy/pasted in several places. Why simplifying only this one? because of its static nature? Shouldn't we make it a common function as other string helpers?